Commit 51d7bc16 authored by Daniel Rubery's avatar Daniel Rubery Committed by Commit Bot

Remove NOTIMPLEMENTED in BinaryFCMService

There's a few NOTIMPLEMENTED in BinaryFCMService that really should
just do nothing. This CL removes them.

Fixed: 1019875
Change-Id: I6b63e687b69d2da268d4dd12bcf0d892556f45f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893524
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Auto-Submit: Daniel Rubery <drubery@chromium.org>
Reviewed-by: default avatarBettina Dea <bdea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711508}
parent f7eae4b0
......@@ -105,9 +105,7 @@ void BinaryFCMService::ShutdownHandler() {
gcm_driver_ = nullptr;
}
void BinaryFCMService::OnStoreReset() {
NOTIMPLEMENTED();
}
void BinaryFCMService::OnStoreReset() {}
void BinaryFCMService::OnMessage(const std::string& app_id,
const gcm::IncomingMessage& message) {
......@@ -143,20 +141,14 @@ void BinaryFCMService::OnMessage(const std::string& app_id,
callback_it->second.Run(std::move(response));
}
void BinaryFCMService::OnMessagesDeleted(const std::string& app_id) {
NOTIMPLEMENTED();
}
void BinaryFCMService::OnMessagesDeleted(const std::string& app_id) {}
void BinaryFCMService::OnSendError(
const std::string& app_id,
const gcm::GCMClient::SendErrorDetails& send_error_details) {
NOTIMPLEMENTED();
}
const gcm::GCMClient::SendErrorDetails& send_error_details) {}
void BinaryFCMService::OnSendAcknowledged(const std::string& app_id,
const std::string& message_id) {
NOTIMPLEMENTED();
}
const std::string& message_id) {}
bool BinaryFCMService::CanHandle(const std::string& app_id) const {
return app_id == kBinaryFCMServiceAppId;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment