Commit 51e58227 authored by Mythri Alle's avatar Mythri Alle Committed by Commit Bot

Enable memory metric, v8.compile category on v8.runtimestats.browse*

We plan to merge v8.browse and v8.runtimestats benchmarks into a single
benchmark. So, enable the memory metric on the v8.runtimestats benchmark.
Though the expectedQueueingTimeMetric is alredy enabled on v8.runtimestats*
it requires v8.compile trace events to work correctly. Also enable
v8.compile category for the expectedQueueingTimeMetric.

The only other metric tracked by v8.browsing and not by
v8.runtimestats.browsing is the v8 executionMetric. This is not required
since the runtimeStatsMetric is a super set of the executionMetric.


Bug: chromium:690921
Change-Id: I574c8c27515d3a62dc6d94c759be0eed32543f20
Reviewed-on: https://chromium-review.googlesource.com/574171Reviewed-by: default avatarUlan Degenbaev <ulan@chromium.org>
Reviewed-by: default avatarNed Nguyen <nednguyen@google.com>
Commit-Queue: Mythri Alle <mythria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487075}
parent 12629605
......@@ -126,10 +126,15 @@ class _V8RuntimeStatsBrowsingBenchmark(_v8BrowsingBenchmarkBaseClass):
# V8 categories.
'blink.console',
'disabled-by-default-v8.gc',
'disabled-by-default-v8.compile',
'renderer.scheduler',
'v8',
'webkit.console',
'disabled-by-default-v8.runtime_stats',
# TODO(crbug.com/616441, primiano): Remove this temporary workaround,
# which enables memory-infra V8 code stats in V8 code size benchmarks
# only (to not slow down detailed memory dumps in other benchmarks).
'disabled-by-default-memory-infra.v8.code_stats',
]
options = timeline_based_measurement.Options(
chrome_trace_category_filter.ChromeTraceCategoryFilter(
......@@ -141,7 +146,8 @@ class _V8RuntimeStatsBrowsingBenchmark(_v8BrowsingBenchmarkBaseClass):
options.config.chrome_trace_config.SetMemoryDumpConfig(memory_dump_config)
options.SetTimelineBasedMetrics([
'expectedQueueingTimeMetric', 'runtimeStatsTotalMetric', 'gcMetric'])
'expectedQueueingTimeMetric', 'runtimeStatsTotalMetric', 'gcMetric',
'memoryMetric'])
return options
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment