Commit 51f122c8 authored by Mike Wittman's avatar Mike Wittman Committed by Commit Bot

Fix ModuleCacheTest.GetDebugBasename for component debug ASAN

Updates the test expectation to account for the component debug ASAN
build using a .cr.so extension on the base unittests module.

Bug: 1126928
Change-Id: I49fba26c817d6e2e1b0aeeedadea8f440e4d6a98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404301
Auto-Submit: Mike Wittman <wittman@chromium.org>
Reviewed-by: default avatarNico Weber <thakis@chromium.org>
Commit-Queue: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805847}
parent 9b884d82
...@@ -106,8 +106,13 @@ MAYBE_TEST(ModuleCacheTest, GetDebugBasename) { ...@@ -106,8 +106,13 @@ MAYBE_TEST(ModuleCacheTest, GetDebugBasename) {
cache.GetModuleForAddress(reinterpret_cast<uintptr_t>(&AFunctionForTest)); cache.GetModuleForAddress(reinterpret_cast<uintptr_t>(&AFunctionForTest));
ASSERT_NE(nullptr, module); ASSERT_NE(nullptr, module);
#if defined(OS_ANDROID) #if defined(OS_ANDROID)
EXPECT_EQ("libbase_unittests__library.so", EXPECT_EQ("libbase_unittests__library",
module->GetDebugBasename().value()); // Different build configurations varyingly use .so vs. .cr.so for
// the module extension. Remove all the extensions in both cases.
module->GetDebugBasename()
.RemoveFinalExtension()
.RemoveFinalExtension()
.value());
#elif defined(OS_POSIX) #elif defined(OS_POSIX)
EXPECT_EQ("base_unittests", module->GetDebugBasename().value()); EXPECT_EQ("base_unittests", module->GetDebugBasename().value());
#elif defined(OS_WIN) #elif defined(OS_WIN)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment