GitLab

Revert of Restore tests for single-sample storage in histograms. (patchset #1...

Revert of Restore tests for single-sample storage in histograms. (patchset #1 id:1 of https://codereview.chromium.org/2850233002/ )

Reason for revert:
The mac dbg builder has started failing again. See https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.mac%2FMac10.9_Tests__dbg_%2F40054%2F%2B%2Frecipes%2Fsteps%2Fbase_unittests%2F0%2Flogs%2FNonThreadSafeDeathTest.DestructorNotAllowedOnDifferentThreadInDebug%2F0 :
[ RUN      ] NonThreadSafeDeathTest.DestructorNotAllowedOnDifferentThreadInDebug

[WARNING] ../../testing/gtest/src/gtest-death-test.cc:834:: Death tests use fork(), which is unsafe particularly in a threaded context. For this test, Google Test detected 4 threads.
../../base/threading/non_thread_safe_unittest.cc:140: Failure
Death test: { NonThreadSafeClass::DestructorOnDifferentThreadImpl(); }
    Result: died but not with expected error.
  Expected: Check failed
Actual msg:
[  DEATH   ] The process has forked and you cannot use this CoreFoundation functionality safely. You MUST exec().
[  DEATH   ] Break on __THE_PROCESS_HAS_FORKED_AND_YOU_CANNOT_USE_THIS_COREFOUNDATION_FUNCTIONALITY___YOU_MUST_EXEC__() to debug.
[  DEATH   ] The process has forked and you cannot use this CoreFoundation functionality safely. You MUST exec().
[  DEATH   ] Break on __THE_PROCESS_HAS_FORKED_AND_YOU_CANNOT_USE_THIS_COREFOUNDATION_FUNCTIONALITY___YOU_MUST_EXEC__() to debug.
[  DEATH   ] Received signal 11 SEGV_MAPERR 000000000110
[  DEATH   ]  [0x00010bd9c12e]
[  DEATH   ]  [0x00010bd9c1cd]
[  DEATH   ]  [0x00010bd9a65c]
[  DEATH   ]  [0x00010bd9c017]
[  DEATH   ]  [0x7fff915c85aa]
[  DEATH   ]  [0x000000000000]
[  DEATH   ]  [0x7fff95a203f9]
[  DEATH   ]  [0x7fff95a2001b]
[  DEATH   ]  [0x7fff95a1fbed]
[  DEATH   ]  [0x7fff957349cb]
[  DEATH   ]  [0x7fff90a97899]
[  DEATH   ]  [0x7fff90a9772a]
[  DEATH   ]  [0x7fff90a9bfc9]
[  DEATH   ] [end of stack trace]
[  DEATH   ]
[  FAILED  ] NonThreadSafeDeathTest.DestructorNotAllowedOnDifferentThreadInDebug (533 ms)

From looking at 705342 it seems as though your changes failed with a similar error before and were reverted. Specifically NonThreadSafeDeathTest.DestructorNotAllowedOnDifferentThreadInDebug . I'm going to revert and see if it fixes things.

Original issue's description:
> Restore tests for single-sample storage in histograms.
>
> These tests were removed from the main CL because they were
> believed to be the cause of some instability in other tests.
> Without the tests, everything seems fine so now it's time to
> restore these.
>
> Main CL: https://codereview.chromium.org/2811713003/
>
> BUG=705342
>
> Review-Url: https://codereview.chromium.org/2850233002
> Cr-Commit-Position: refs/heads/master@{#468396}
> Committed: https://chromium.googlesource.com/chromium/src/+/da4b99838d459396d412bc278358b7f335ac0fdc

TBR=asvitkine@chromium.org,bcwhite@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=705342

Review-Url: https://codereview.chromium.org/2851363002
Cr-Commit-Position: refs/heads/master@{#468430}