GitLab

[Signin][Android] Revise SigninManagerTest

Refactors SigninManagerTest:
* Switches to explicit creation for SigninManager, thus allowing writing
  tests for SigninManager ctor. Such a test will be added in a
  subsequent CL.
* Adds explicit SigninManager.destroy call.
* Removes redundant Mockito stubs (doNothing & doReturn(null)) where
  they don't improve the readability of the test.
* Switches to @Mock annotations instead of manual mock(...) in setUp.

Bug: 1132290
Change-Id: I630cc95d84c6ba4f5d2fc737dbb8a786e6dd6f8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431486
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Alice Wang <aliceywang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811684}