Commit 52511a00 authored by Jay Harris's avatar Jay Harris Committed by Commit Bot

Adds flag for using custom tab UI.

This flag will control whether or not the new custom tab bar UI is used.

Bug: 853593
Change-Id: Ie8ab91d10fc6543ab560a50795dd5e26b8e31146
Reviewed-on: https://chromium-review.googlesource.com/c/1312135
Commit-Queue: Jay Harris <harrisjay@chromium.org>
Reviewed-by: default avatarMatt Giuca <mgiuca@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604787}
parent 31d0dd65
...@@ -2298,6 +2298,10 @@ const FeatureEntry kFeatureEntries[] = { ...@@ -2298,6 +2298,10 @@ const FeatureEntry kFeatureEntries[] = {
{"enable-system-webapps", flag_descriptions::kEnableSystemWebAppsName, {"enable-system-webapps", flag_descriptions::kEnableSystemWebAppsName,
flag_descriptions::kEnableSystemWebAppsDescription, kOsDesktop, flag_descriptions::kEnableSystemWebAppsDescription, kOsDesktop,
FEATURE_VALUE_TYPE(features::kSystemWebApps)}, FEATURE_VALUE_TYPE(features::kSystemWebApps)},
{"enable-desktop-pwas-custom-tab-ui",
flag_descriptions::kDesktopPWAsCustomTabUIName,
flag_descriptions::kDesktopPWAsCustomTabUIDescription, kOsDesktop,
FEATURE_VALUE_TYPE(features::kDesktopPWAsCustomTabUI)},
{"enable-desktop-pwas-stay-in-window", {"enable-desktop-pwas-stay-in-window",
flag_descriptions::kDesktopPWAsStayInWindowName, flag_descriptions::kDesktopPWAsStayInWindowName,
flag_descriptions::kDesktopPWAsStayInWindowDescription, kOsDesktop, flag_descriptions::kDesktopPWAsStayInWindowDescription, kOsDesktop,
......
...@@ -531,11 +531,16 @@ const char kEnableDesktopPWAsLinkCapturingDescription[] = ...@@ -531,11 +531,16 @@ const char kEnableDesktopPWAsLinkCapturingDescription[] =
"URLs that are in-scope of Desktop PWAs will open in a window. Requires " "URLs that are in-scope of Desktop PWAs will open in a window. Requires "
"#enable-desktop-pwas."; "#enable-desktop-pwas.";
const char kDesktopPWAsCustomTabUIName[] = "Desktop PWAs Custom Tab UI";
const char kDesktopPWAsCustomTabUIDescription[] =
"Browsing out-of-scope links in a desktop PWA will use the custom tab UI "
"for displaying the page title and origin instead of the location bar.";
const char kDesktopPWAsStayInWindowName[] = const char kDesktopPWAsStayInWindowName[] =
"Desktop PWAs out-of-scope links open in the app window"; "Desktop PWAs out-of-scope links open in the app window";
const char kDesktopPWAsStayInWindowDescription[] = const char kDesktopPWAsStayInWindowDescription[] =
"Links to sites in a different scope will open in a custom " "Links to sites in a different scope will open inside the PWA window as "
"tab (inside the PWA window) as opposed to in the browser."; "opposed to in the browser.";
const char kEnableSystemWebAppsName[] = "System Web Apps"; const char kEnableSystemWebAppsName[] = "System Web Apps";
const char kEnableSystemWebAppsDescription[] = const char kEnableSystemWebAppsDescription[] =
......
...@@ -349,6 +349,9 @@ extern const char kEnableDesktopPWAsDescription[]; ...@@ -349,6 +349,9 @@ extern const char kEnableDesktopPWAsDescription[];
extern const char kEnableDesktopPWAsLinkCapturingName[]; extern const char kEnableDesktopPWAsLinkCapturingName[];
extern const char kEnableDesktopPWAsLinkCapturingDescription[]; extern const char kEnableDesktopPWAsLinkCapturingDescription[];
extern const char kDesktopPWAsCustomTabUIName[];
extern const char kDesktopPWAsCustomTabUIDescription[];
extern const char kDesktopPWAsStayInWindowName[]; extern const char kDesktopPWAsStayInWindowName[];
extern const char kDesktopPWAsStayInWindowDescription[]; extern const char kDesktopPWAsStayInWindowDescription[];
......
...@@ -204,6 +204,11 @@ const base::Feature kDesktopPWAWindowing { ...@@ -204,6 +204,11 @@ const base::Feature kDesktopPWAWindowing {
const base::Feature kDesktopPWAsLinkCapturing{ const base::Feature kDesktopPWAsLinkCapturing{
"DesktopPWAsLinkCapturing", base::FEATURE_DISABLED_BY_DEFAULT}; "DesktopPWAsLinkCapturing", base::FEATURE_DISABLED_BY_DEFAULT};
// Determines whether out of scope pages in the hosted app will use the
// custom tab UI.
const base::Feature kDesktopPWAsCustomTabUI{"DesktopPWAsCustomTabUI",
base::FEATURE_ENABLED_BY_DEFAULT};
// Determines whether in scope requests are always opened in the same window. // Determines whether in scope requests are always opened in the same window.
const base::Feature kDesktopPWAsStayInWindow{"DesktopPWAsStayInWindow", const base::Feature kDesktopPWAsStayInWindow{"DesktopPWAsStayInWindow",
base::FEATURE_ENABLED_BY_DEFAULT}; base::FEATURE_ENABLED_BY_DEFAULT};
......
...@@ -128,6 +128,9 @@ extern const base::Feature kDesktopPWAWindowing; ...@@ -128,6 +128,9 @@ extern const base::Feature kDesktopPWAWindowing;
COMPONENT_EXPORT(CHROME_FEATURES) COMPONENT_EXPORT(CHROME_FEATURES)
extern const base::Feature kDesktopPWAsLinkCapturing; extern const base::Feature kDesktopPWAsLinkCapturing;
COMPONENT_EXPORT(CHROME_FEATURES)
extern const base::Feature kDesktopPWAsCustomTabUI;
COMPONENT_EXPORT(CHROME_FEATURES) COMPONENT_EXPORT(CHROME_FEATURES)
extern const base::Feature kDesktopPWAsStayInWindow; extern const base::Feature kDesktopPWAsStayInWindow;
......
...@@ -29447,6 +29447,7 @@ from previous Chrome versions. ...@@ -29447,6 +29447,7 @@ from previous Chrome versions.
<int value="-1174267639" label="ClientLoFi:disabled"/> <int value="-1174267639" label="ClientLoFi:disabled"/>
<int value="-1172572865" label="NTPShowGoogleGInOmnibox:enabled"/> <int value="-1172572865" label="NTPShowGoogleGInOmnibox:enabled"/>
<int value="-1172204005" label="enable-offline-auto-reload-visible-only"/> <int value="-1172204005" label="enable-offline-auto-reload-visible-only"/>
<int value="-1167992523" label="DesktopPWAsCustomTabUI:disabled"/>
<int value="-1166715563" label="ChromeOSAssistant:disabled"/> <int value="-1166715563" label="ChromeOSAssistant:disabled"/>
<int value="-1162944097" label="enable-color-correct-rendering"/> <int value="-1162944097" label="enable-color-correct-rendering"/>
<int value="-1161409696" label="MediaRemotingEncrypted:enabled"/> <int value="-1161409696" label="MediaRemotingEncrypted:enabled"/>
...@@ -30070,6 +30071,7 @@ from previous Chrome versions. ...@@ -30070,6 +30071,7 @@ from previous Chrome versions.
<int value="37045987" label="AutofillPreviewStyleExperiment:disabled"/> <int value="37045987" label="AutofillPreviewStyleExperiment:disabled"/>
<int value="42098736" label="TranslateAndroidManualTrigger:disabled"/> <int value="42098736" label="TranslateAndroidManualTrigger:disabled"/>
<int value="42844603" label="AndroidSurfaceControl:disabled"/> <int value="42844603" label="AndroidSurfaceControl:disabled"/>
<int value="43951968" label="DesktopPWAsCustomTabUI:enabled"/>
<int value="44088203" label="ExpensiveBackgroundTimerThrottling:enabled"/> <int value="44088203" label="ExpensiveBackgroundTimerThrottling:enabled"/>
<int value="48159177" label="reduced-referrer-granularity"/> <int value="48159177" label="reduced-referrer-granularity"/>
<int value="48223610" label="SiteSettings:disabled"/> <int value="48223610" label="SiteSettings:disabled"/>
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment