[Sheriff] Disable ExtensionContextMenuLazyTest.IncognitoSplit on Windows/Mac for real
crrev.com/726101 intended to do this it seems but only covered IncognitoSplitContextMenuCount. IncognitoSplit is still flakily timing out on multiple Windows/Mac bots: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=EventPage/ExtensionContextMenuLazyTest.IncognitoSplit/0 Most often on win-asan and dbg bots, e.g. https://ci.chromium.org/p/chromium/builders/ci/win-asan/9190 suggesting a race (those bots are slower and races resolve differently on average) which results in a hang (hint: awaited notification arriving before the observer is installed is a typical reason for this). The hang is @ ExtensionTestMessageListener::WaitUntilSatisfied @ extension_test_message_listener.cc:48 when invoked from ASSERT_TRUE(onclick.WaitUntilSatisfied()) @ extension_context_menu_browsertest.cc:789 TBR=rdvelin.cronin@chromium.org Bug: 1035062 Change-Id: I29f237b3acd311967d14cdc58d3489ddd5bfd767 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980350 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#727159}
Showing
Please register or sign in to comment