Commit 5265381b authored by Taylor Bergquist's avatar Taylor Bergquist Committed by Commit Bot

Remove NTB from toolbar in webui mode.

Bug: 1045669
Change-Id: Ib5d5afeb13b5ab50293a03dbeaafe388ff0a8522
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018341
Commit-Queue: Taylor Bergquist <tbergquist@chromium.org>
Reviewed-by: default avatarPeter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735571}
parent 1a47137d
...@@ -123,6 +123,7 @@ class WebUITabStripContainerView : public TabStripUIEmbedder, ...@@ -123,6 +123,7 @@ class WebUITabStripContainerView : public TabStripUIEmbedder,
Browser* const browser_; Browser* const browser_;
views::WebView* const web_view_; views::WebView* const web_view_;
views::View* tab_contents_container_; views::View* tab_contents_container_;
// TODO(1045669): Remove this, or run an experiment on bringing it back.
ToolbarButton* new_tab_button_ = nullptr; ToolbarButton* new_tab_button_ = nullptr;
views::View* tab_counter_ = nullptr; views::View* tab_counter_ = nullptr;
......
...@@ -58,10 +58,6 @@ TEST_F(WebUITabStripContainerViewTest, TouchModeTransition) { ...@@ -58,10 +58,6 @@ TEST_F(WebUITabStripContainerViewTest, TouchModeTransition) {
} }
TEST_F(WebUITabStripContainerViewTest, ButtonsPresentInToolbar) { TEST_F(WebUITabStripContainerViewTest, ButtonsPresentInToolbar) {
ASSERT_NE(nullptr,
browser_view()->webui_tab_strip()->new_tab_button_for_testing());
EXPECT_TRUE(browser_view()->toolbar()->Contains(
browser_view()->webui_tab_strip()->new_tab_button_for_testing()));
ASSERT_NE(nullptr, ASSERT_NE(nullptr,
browser_view()->webui_tab_strip()->tab_counter_for_testing()); browser_view()->webui_tab_strip()->tab_counter_for_testing());
EXPECT_TRUE(browser_view()->toolbar()->Contains( EXPECT_TRUE(browser_view()->toolbar()->Contains(
......
...@@ -362,8 +362,6 @@ void ToolbarView::UpdateForWebUITabStrip() { ...@@ -362,8 +362,6 @@ void ToolbarView::UpdateForWebUITabStrip() {
#if BUILDFLAG(ENABLE_WEBUI_TAB_STRIP) #if BUILDFLAG(ENABLE_WEBUI_TAB_STRIP)
if (browser_view_->webui_tab_strip() && app_menu_button_) { if (browser_view_->webui_tab_strip() && app_menu_button_) {
const int insertion_index = GetIndexOf(app_menu_button_); const int insertion_index = GetIndexOf(app_menu_button_);
AddChildViewAt(browser_view_->webui_tab_strip()->CreateNewTabButton(),
insertion_index);
AddChildViewAt(browser_view_->webui_tab_strip()->CreateTabCounter(), AddChildViewAt(browser_view_->webui_tab_strip()->CreateTabCounter(),
insertion_index); insertion_index);
LoadImages(); LoadImages();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment