Commit 5277ec60 authored by Katie D's avatar Katie D Committed by Commit Bot

Re-enable autoclick tests since ScopedTaskEnvironment bug is fixed.

ScopedTaskEnvironment::NextScheduledRunTime was returning Now()
(aka now_ticks_) because sequence_manager is idle, but then
ScopedTaskEnvironment::MaybeFastForwardToNextTask DCHECKS that now_ticks_
is strictly < run_time, which was causing test failures. Now that
ScopedTaskEnviornment is fixed we can re-enable these tests.

Bug: 935651
Change-Id: I5a0cb2967001995a54f2245bac4e5f9022514001
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500018Reviewed-by: default avatarDavid Tseng <dtseng@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638648}
parent 3331cac2
......@@ -515,8 +515,7 @@ TEST_F(AutoclickTest, AutoclickRevertsToLeftClick) {
EXPECT_TRUE(ui::EF_RIGHT_MOUSE_BUTTON & events[1].flags());
}
// TODO(crbug.com/935651): The test has flaky crashes.
TEST_F(AutoclickTest, DISABLED_WaitsToDrawAnimationAfterDwellBegins) {
TEST_F(AutoclickTest, WaitsToDrawAnimationAfterDwellBegins) {
float ratio = GetAutoclickController()->GetStartGestureDelayRatioForTesting();
int full_delay = ceil(1.0 / ratio) * 5;
int animation_delay = 5;
......@@ -626,9 +625,8 @@ TEST_F(AutoclickTest, LeftClicksOnTrayButtonWhenInDifferentModes) {
Shell::Get()->accessibility_controller()->SetAutoclickEnabled(false);
}
TEST_F(
AutoclickTest,
DISABLED_StartsGestureOnTrayButtonButDoesNotClickIfMouseMovedWhenPaused) {
TEST_F(AutoclickTest,
StartsGestureOnTrayButtonButDoesNotClickIfMouseMovedWhenPaused) {
Shell::Get()->accessibility_controller()->SetAutoclickEnabled(true);
GetAutoclickController()->set_revert_to_left_click(false);
GetAutoclickController()->SetAutoclickEventType(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment