Commit 52788b20 authored by Renjie Tang's avatar Renjie Tang Committed by Commit Bot

Log coalesced stream frames.

Change-Id: I99d8d77190b66eda62a5116a224ae23d94845d82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128470Reviewed-by: default avatarBence Béky <bnc@chromium.org>
Commit-Queue: Renjie Tang <renjietang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755461}
parent b6918d8c
......@@ -1812,6 +1812,15 @@ EVENT_TYPE(QUIC_SESSION_STREAM_FRAME_RECEIVED)
// }
EVENT_TYPE(QUIC_SESSION_STREAM_FRAME_SENT)
// A stream frame is coalesced with an existing stream frame.
// {
// "stream_id": <The id of the stream which this data is for>,
// "fin": <True if this is the final data set by the peer on this stream>,
// "offset": <Offset in the byte stream where this data starts>,
// "length": <Length of the data in this frame>,
// }
EVENT_TYPE(QUIC_SESSION_STREAM_FRAME_COALESCED)
// Session received an ACK frame.
// {
// "sent_info": <Details of packet sent by the peer>
......
......@@ -593,6 +593,14 @@ void QuicConnectionLogger::OnFrameAddedToPacket(const quic::QuicFrame& frame) {
}
}
void QuicConnectionLogger::OnStreamFrameCoalesced(
const quic::QuicStreamFrame& frame) {
if (!net_log_.IsCapturing())
return;
net_log_.AddEvent(NetLogEventType::QUIC_SESSION_STREAM_FRAME_COALESCED,
[&] { return NetLogQuicStreamFrameParams(frame); });
}
void QuicConnectionLogger::OnPacketSent(
const quic::SerializedPacket& serialized_packet,
quic::TransmissionType transmission_type,
......
......@@ -44,6 +44,7 @@ class NET_EXPORT_PRIVATE QuicConnectionLogger
// quic::QuicPacketCreator::DebugDelegateInterface
void OnFrameAddedToPacket(const quic::QuicFrame& frame) override;
void OnStreamFrameCoalesced(const quic::QuicStreamFrame& frame) override;
// QuicConnectionDebugVisitorInterface
void OnPacketSent(const quic::SerializedPacket& serialized_packet,
......
......@@ -20,7 +20,6 @@ namespace {
base::Value NetLogSettingsParams(const quic::SettingsFrame& frame) {
base::Value dict(base::Value::Type::DICTIONARY);
// TODO(renjietang): Use string literal for setting identifiers.
for (auto setting : frame.values) {
dict.SetIntKey(
quic::SpdyUtils::H3SettingsToString(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment