Commit 52ba31d9 authored by Wez's avatar Wez Committed by Chromium LUCI CQ

[blink] Report |location| and |message| from ReportFatalErrorInMainThread().

ReportFatalErrorInMainThread() is supplied with a |location| and |message|, which are logged in
Debug builds with verbose logging enabled, but not otherwise.  The function then invokes LOG(FATAL).

Combine the two so that |location| and |message| are passed to LOG(FATAL), thereby providing useful
context in crash reports.

Bug: 1157386
Change-Id: I43e877b3d537b759c9db3c64534349009fefa7ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584852Reviewed-by: default avatarMichael Lippautz <mlippautz@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836607}
parent e901a909
...@@ -92,8 +92,7 @@ namespace blink { ...@@ -92,8 +92,7 @@ namespace blink {
static void ReportFatalErrorInMainThread(const char* location, static void ReportFatalErrorInMainThread(const char* location,
const char* message) { const char* message) {
DVLOG(1) << "V8 error: " << message << " (" << location << ")."; LOG(FATAL) << "V8 error: " << message << " (" << location << ").";
LOG(FATAL);
} }
static void ReportOOMErrorInMainThread(const char* location, bool is_js_heap) { static void ReportOOMErrorInMainThread(const char* location, bool is_js_heap) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment