Commit 53189197 authored by Yuki Shiino's avatar Yuki Shiino Committed by Commit Bot

bind-gen: Fix Win component build of v8_context_snapshot_impl.cc

Bug: 839389
Change-Id: Ia300db2ed184529cd8ae587b3a40c3a84d100167
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291520
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: default avatarHitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#787642}
parent 92b1e593
...@@ -73,6 +73,15 @@ using InstallPropsPerIsolate = ...@@ -73,6 +73,15 @@ using InstallPropsPerIsolate =
v8::Local<v8::ObjectTemplate> prototype_template, v8::Local<v8::ObjectTemplate> prototype_template,
v8::Local<v8::FunctionTemplate> interface_template); v8::Local<v8::FunctionTemplate> interface_template);
// Construction of |type_info_table| requires non-trivial initialization due
// to cross-component address resolution. We ignore this issue because the
// issue happens only on component builds and the official release builds
// (statically-linked builds) are never affected by this issue.
#if defined(COMPONENT_BUILD) && defined(WIN32) && defined(__clang__)
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wglobal-constructors"
#endif
const struct { const struct {
const WrapperTypeInfo* wrapper_type_info; const WrapperTypeInfo* wrapper_type_info;
// Installs context-independent properties to per-isolate templates. // Installs context-independent properties to per-isolate templates.
...@@ -103,6 +112,10 @@ const struct { ...@@ -103,6 +112,10 @@ const struct {
{true, true}}, {true, true}},
}; };
#if defined(COMPONENT_BUILD) && defined(WIN32) && defined(__clang__)
#pragma clang diagnostic pop
#endif
enum class InternalFieldSerializedValue : uint8_t { enum class InternalFieldSerializedValue : uint8_t {
// ScriptWrappable pointer // ScriptWrappable pointer
kSwHTMLDocument = 1, kSwHTMLDocument = 1,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment