Skip to content

GitLab

T
tangled
Commit 532e8d1c authored by Anupam Snigdha's avatar Anupam Snigdha Committed by Commit Bot
Browse files
Options

Initialize the boundingRect property of VirtualKeyboard. 

Initialized the boundingRect property of the virtualKeyboard object
to default values during construction.

Bug: 1147243

Change-Id: I2a751d08aaff2c70f3cf06931e4b8d183a29b413
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527564
Commit-Queue: Anupam Snigdha <snianu@microsoft.com>
Reviewed-by: default avatarAvi Drissman <avi@chromium.org>
Reviewed-by: default avatarKent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825728}
parent 350b8a72
Hide whitespace changes
Inline Side-by-side
Showing with 55 additions and 7 deletions
content/browser/renderer_host/render_widget_host_view_aura_vk_browsertest.cc
View file @ 532e8d1c
......@@ -277,7 +277,7 @@ IN_PROC_BROWSER_TEST_F(RenderWidgetHostViewAuraBrowserMockIMETest,
const char kVirtualKeyboardDataURL[] =
"data:text/html,<!DOCTYPE html>"
"<script>"
" let VKRect, numEvents = 0;"
" let VKRect = navigator.virtualKeyboard.boundingRect, numEvents = 0;"
" navigator.virtualKeyboard.overlaysContent = true;"
" navigator.virtualKeyboard.addEventListener('geometrychange',"
" evt => {"
......@@ -287,6 +287,11 @@ IN_PROC_BROWSER_TEST_F(RenderWidgetHostViewAuraBrowserMockIMETest,
"</script>";
EXPECT_TRUE(NavigateToURL(shell(), GURL(kVirtualKeyboardDataURL)));
// Check the boundingRect property so it's not null when queried.
EXPECT_EQ(0, EvalJs(shell(), "VKRect.x"));
EXPECT_EQ(0, EvalJs(shell(), "VKRect.y"));
EXPECT_EQ(0, EvalJs(shell(), "VKRect.width"));
EXPECT_EQ(0, EvalJs(shell(), "VKRect.height"));
// Send a touch event so that RenderWidgetHostViewAura will create the
// keyboard observer (requires last_pointer_type_ to be TOUCH).
ui::TouchEvent press(ui::ET_TOUCH_PRESSED, gfx::Point(30, 30),
......
third_party/blink/renderer/modules/virtualkeyboard/virtual_keyboard.cc
View file @ 532e8d1c
......@@ -37,6 +37,7 @@ VirtualKeyboard::VirtualKeyboard(Navigator& navigator)
: Supplement<Navigator>(navigator),
VirtualKeyboardOverlayChangedObserver(
navigator.DomWindow() ? navigator.DomWindow()->GetFrame() : nullptr) {
bounding_rect_ = DOMRect::Create();
}
ExecutionContext* VirtualKeyboard::GetExecutionContext() const {
......
third_party/blink/web_tests/fast/dom/Window/property-access-on-cached-properties-after-frame-navigated-expected.txt
View file @ 532e8d1c
......@@ -57,7 +57,14 @@ PASS window.cached_navigator_userActivation.isActive is false
PASS window.cached_navigator_userAgentData.brands[0].brand is ''
PASS window.cached_navigator_userAgentData.brands[0].version is ''
PASS window.cached_navigator_userAgentData.mobile is false
PASS window.cached_navigator_virtualKeyboard.boundingRect is null
PASS window.cached_navigator_virtualKeyboard.boundingRect.bottom is 0
PASS window.cached_navigator_virtualKeyboard.boundingRect.height is 0
PASS window.cached_navigator_virtualKeyboard.boundingRect.left is 0
PASS window.cached_navigator_virtualKeyboard.boundingRect.right is 0
PASS window.cached_navigator_virtualKeyboard.boundingRect.top is 0
PASS window.cached_navigator_virtualKeyboard.boundingRect.width is 0
PASS window.cached_navigator_virtualKeyboard.boundingRect.x is 0
PASS window.cached_navigator_virtualKeyboard.boundingRect.y is 0
PASS window.cached_navigator_virtualKeyboard.ongeometrychange is null
PASS window.cached_navigator_virtualKeyboard.overlaysContent is false
PASS window.cached_navigator_xr.ondevicechange is null
......
third_party/blink/web_tests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced-expected.txt
View file @ 532e8d1c
......@@ -57,7 +57,14 @@ PASS window.cached_navigator_userActivation.isActive is false
PASS window.cached_navigator_userAgentData.brands[0].brand is ''
PASS window.cached_navigator_userAgentData.brands[0].version is ''
PASS window.cached_navigator_userAgentData.mobile is false
PASS window.cached_navigator_virtualKeyboard.boundingRect is null
PASS window.cached_navigator_virtualKeyboard.boundingRect.bottom is 0
PASS window.cached_navigator_virtualKeyboard.boundingRect.height is 0
PASS window.cached_navigator_virtualKeyboard.boundingRect.left is 0
PASS window.cached_navigator_virtualKeyboard.boundingRect.right is 0
PASS window.cached_navigator_virtualKeyboard.boundingRect.top is 0
PASS window.cached_navigator_virtualKeyboard.boundingRect.width is 0
PASS window.cached_navigator_virtualKeyboard.boundingRect.x is 0
PASS window.cached_navigator_virtualKeyboard.boundingRect.y is 0
PASS window.cached_navigator_virtualKeyboard.ongeometrychange is null
PASS window.cached_navigator_virtualKeyboard.overlaysContent is false
PASS window.cached_navigator_xr.ondevicechange is null
......
third_party/blink/web_tests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-expected.txt
View file @ 532e8d1c
......@@ -57,7 +57,14 @@ PASS window.cached_navigator_userActivation.isActive is false
PASS window.cached_navigator_userAgentData.brands[0].brand is ''
PASS window.cached_navigator_userAgentData.brands[0].version is ''
PASS window.cached_navigator_userAgentData.mobile is false
PASS window.cached_navigator_virtualKeyboard.boundingRect is null
PASS window.cached_navigator_virtualKeyboard.boundingRect.bottom is 0
PASS window.cached_navigator_virtualKeyboard.boundingRect.height is 0
PASS window.cached_navigator_virtualKeyboard.boundingRect.left is 0
PASS window.cached_navigator_virtualKeyboard.boundingRect.right is 0
PASS window.cached_navigator_virtualKeyboard.boundingRect.top is 0
PASS window.cached_navigator_virtualKeyboard.boundingRect.width is 0
PASS window.cached_navigator_virtualKeyboard.boundingRect.x is 0
PASS window.cached_navigator_virtualKeyboard.boundingRect.y is 0
PASS window.cached_navigator_virtualKeyboard.ongeometrychange is null
PASS window.cached_navigator_virtualKeyboard.overlaysContent is false
PASS window.cached_navigator_xr.ondevicechange is null
......
third_party/blink/web_tests/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt
View file @ 532e8d1c
......@@ -67,7 +67,14 @@ PASS oldChildWindow.navigator.userAgentData.brands[0].version is newChildWindow.
PASS oldChildWindow.navigator.userAgentData.mobile is newChildWindow.navigator.userAgentData.mobile
PASS oldChildWindow.navigator.vendor is newChildWindow.navigator.vendor
PASS oldChildWindow.navigator.vendorSub is newChildWindow.navigator.vendorSub
PASS oldChildWindow.navigator.virtualKeyboard.boundingRect is newChildWindow.navigator.virtualKeyboard.boundingRect
PASS oldChildWindow.navigator.virtualKeyboard.boundingRect.bottom is newChildWindow.navigator.virtualKeyboard.boundingRect.bottom
PASS oldChildWindow.navigator.virtualKeyboard.boundingRect.height is newChildWindow.navigator.virtualKeyboard.boundingRect.height
PASS oldChildWindow.navigator.virtualKeyboard.boundingRect.left is newChildWindow.navigator.virtualKeyboard.boundingRect.left
PASS oldChildWindow.navigator.virtualKeyboard.boundingRect.right is newChildWindow.navigator.virtualKeyboard.boundingRect.right
PASS oldChildWindow.navigator.virtualKeyboard.boundingRect.top is newChildWindow.navigator.virtualKeyboard.boundingRect.top
PASS oldChildWindow.navigator.virtualKeyboard.boundingRect.width is newChildWindow.navigator.virtualKeyboard.boundingRect.width
PASS oldChildWindow.navigator.virtualKeyboard.boundingRect.x is newChildWindow.navigator.virtualKeyboard.boundingRect.x
PASS oldChildWindow.navigator.virtualKeyboard.boundingRect.y is newChildWindow.navigator.virtualKeyboard.boundingRect.y
PASS oldChildWindow.navigator.virtualKeyboard.ongeometrychange is newChildWindow.navigator.virtualKeyboard.ongeometrychange
PASS oldChildWindow.navigator.virtualKeyboard.overlaysContent is newChildWindow.navigator.virtualKeyboard.overlaysContent
PASS oldChildWindow.navigator.xr.ondevicechange is newChildWindow.navigator.xr.ondevicechange
......
third_party/blink/web_tests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt
View file @ 532e8d1c
......@@ -33,7 +33,14 @@ PASS childWindow.navigator.userActivation.isActive is false
PASS childWindow.navigator.userAgent is ''
PASS childWindow.navigator.vendor is window.navigator.vendor
PASS childWindow.navigator.vendorSub is ''
PASS childWindow.navigator.virtualKeyboard.boundingRect is null
PASS childWindow.navigator.virtualKeyboard.boundingRect.bottom is 0
PASS childWindow.navigator.virtualKeyboard.boundingRect.height is 0
PASS childWindow.navigator.virtualKeyboard.boundingRect.left is 0
PASS childWindow.navigator.virtualKeyboard.boundingRect.right is 0
PASS childWindow.navigator.virtualKeyboard.boundingRect.top is 0
PASS childWindow.navigator.virtualKeyboard.boundingRect.width is 0
PASS childWindow.navigator.virtualKeyboard.boundingRect.x is 0
PASS childWindow.navigator.virtualKeyboard.boundingRect.y is 0
PASS childWindow.navigator.virtualKeyboard.ongeometrychange is null
PASS childWindow.navigator.virtualKeyboard.overlaysContent is false
PASS childWindow.onabort is null
......
third_party/blink/web_tests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt
View file @ 532e8d1c
......@@ -33,7 +33,14 @@ PASS childWindow.navigator.userActivation.isActive is false
PASS childWindow.navigator.userAgent is ''
PASS childWindow.navigator.vendor is window.navigator.vendor
PASS childWindow.navigator.vendorSub is ''
PASS childWindow.navigator.virtualKeyboard.boundingRect is null
PASS childWindow.navigator.virtualKeyboard.boundingRect.bottom is 0
PASS childWindow.navigator.virtualKeyboard.boundingRect.height is 0
PASS childWindow.navigator.virtualKeyboard.boundingRect.left is 0
PASS childWindow.navigator.virtualKeyboard.boundingRect.right is 0
PASS childWindow.navigator.virtualKeyboard.boundingRect.top is 0
PASS childWindow.navigator.virtualKeyboard.boundingRect.width is 0
PASS childWindow.navigator.virtualKeyboard.boundingRect.x is 0
PASS childWindow.navigator.virtualKeyboard.boundingRect.y is 0
PASS childWindow.navigator.virtualKeyboard.ongeometrychange is null
PASS childWindow.navigator.virtualKeyboard.overlaysContent is false
PASS childWindow.onabort is null
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment