Commit 5341642d authored by avi@chromium.org's avatar avi@chromium.org

Add OVERRIDE to chrome/renderer.

BUG=104314
TEST=no change

Review URL: http://codereview.chromium.org/8613004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110942 0039d316-1c4b-4281-b951-d872f2087c98
parent dacbf2c3
...@@ -62,11 +62,11 @@ class PasswordAutofillManager : public content::RenderViewObserver, ...@@ -62,11 +62,11 @@ class PasswordAutofillManager : public content::RenderViewObserver,
typedef std::map<WebKit::WebElement, PasswordInfo> LoginToPasswordInfoMap; typedef std::map<WebKit::WebElement, PasswordInfo> LoginToPasswordInfoMap;
// RenderViewObserver: // RenderViewObserver:
virtual bool OnMessageReceived(const IPC::Message& message); virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
virtual void DidFinishDocumentLoad(WebKit::WebFrame* frame); virtual void DidFinishDocumentLoad(WebKit::WebFrame* frame) OVERRIDE;
virtual void DidFinishLoad(WebKit::WebFrame* frame); virtual void DidFinishLoad(WebKit::WebFrame* frame) OVERRIDE;
virtual void FrameDetached(WebKit::WebFrame* frame); virtual void FrameDetached(WebKit::WebFrame* frame) OVERRIDE;
virtual void FrameWillClose(WebKit::WebFrame* frame); virtual void FrameWillClose(WebKit::WebFrame* frame) OVERRIDE;
// PageClickListener: // PageClickListener:
virtual bool InputElementClicked(const WebKit::WebInputElement& element, virtual bool InputElementClicked(const WebKit::WebInputElement& element,
......
...@@ -30,9 +30,9 @@ class BlockedPlugin : public content::RenderViewObserver, ...@@ -30,9 +30,9 @@ class BlockedPlugin : public content::RenderViewObserver,
webkit::npapi::WebViewPlugin* plugin() { return plugin_; } webkit::npapi::WebViewPlugin* plugin() { return plugin_; }
// WebViewPlugin::Delegate methods: // WebViewPlugin::Delegate methods:
virtual void BindWebFrame(WebKit::WebFrame* frame); virtual void BindWebFrame(WebKit::WebFrame* frame) OVERRIDE;
virtual void WillDestroyPlugin(); virtual void WillDestroyPlugin() OVERRIDE;
virtual void ShowContextMenu(const WebKit::WebMouseEvent&); virtual void ShowContextMenu(const WebKit::WebMouseEvent&) OVERRIDE;
private: private:
virtual ~BlockedPlugin(); virtual ~BlockedPlugin();
......
...@@ -49,7 +49,7 @@ class ChromeMockRenderThread : public content::MockRenderThread { ...@@ -49,7 +49,7 @@ class ChromeMockRenderThread : public content::MockRenderThread {
private: private:
// Overrides base class implementation to add custom handling for // Overrides base class implementation to add custom handling for
// print and extensions. // print and extensions.
virtual bool OnMessageReceived(const IPC::Message& msg); virtual bool OnMessageReceived(const IPC::Message& msg) OVERRIDE;
// The callee expects to be returned a valid channel_id. // The callee expects to be returned a valid channel_id.
void OnMsgOpenChannelToExtension( void OnMsgOpenChannelToExtension(
......
...@@ -67,9 +67,9 @@ class ContentSettingsObserver ...@@ -67,9 +67,9 @@ class ContentSettingsObserver
private: private:
// RenderViewObserver implementation. // RenderViewObserver implementation.
virtual bool OnMessageReceived(const IPC::Message& message); virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
virtual void DidCommitProvisionalLoad(WebKit::WebFrame* frame, virtual void DidCommitProvisionalLoad(WebKit::WebFrame* frame,
bool is_new_navigation); bool is_new_navigation) OVERRIDE;
// Message handlers. // Message handlers.
void OnLoadBlockedPlugins(); void OnLoadBlockedPlugins();
......
...@@ -59,7 +59,7 @@ class ChromeV8Extension : public v8::Extension { ...@@ -59,7 +59,7 @@ class ChromeV8Extension : public v8::Extension {
// order to expose common native functions, like GetChromeHidden, to the // order to expose common native functions, like GetChromeHidden, to the
// v8 extension. // v8 extension.
virtual v8::Handle<v8::FunctionTemplate> virtual v8::Handle<v8::FunctionTemplate>
GetNativeFunction(v8::Handle<v8::String> name); GetNativeFunction(v8::Handle<v8::String> name) OVERRIDE;
protected: protected:
template<class T> template<class T>
......
...@@ -88,9 +88,9 @@ class ExtensionDispatcher : public content::RenderProcessObserver { ...@@ -88,9 +88,9 @@ class ExtensionDispatcher : public content::RenderProcessObserver {
friend class RenderViewTest; friend class RenderViewTest;
// RenderProcessObserver implementation: // RenderProcessObserver implementation:
virtual bool OnControlMessageReceived(const IPC::Message& message); virtual bool OnControlMessageReceived(const IPC::Message& message) OVERRIDE;
virtual void WebKitInitialized(); virtual void WebKitInitialized() OVERRIDE;
virtual void IdleNotification(); virtual void IdleNotification() OVERRIDE;
void OnMessageInvoke(const std::string& extension_id, void OnMessageInvoke(const std::string& extension_id,
const std::string& function_name, const std::string& function_name,
......
...@@ -56,14 +56,14 @@ class ExtensionHelper ...@@ -56,14 +56,14 @@ class ExtensionHelper
private: private:
// RenderViewObserver implementation. // RenderViewObserver implementation.
virtual bool OnMessageReceived(const IPC::Message& message); virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
virtual void DidFinishDocumentLoad(WebKit::WebFrame* frame); virtual void DidFinishDocumentLoad(WebKit::WebFrame* frame) OVERRIDE;
virtual void DidFinishLoad(WebKit::WebFrame* frame); virtual void DidFinishLoad(WebKit::WebFrame* frame) OVERRIDE;
virtual void DidCreateDocumentElement(WebKit::WebFrame* frame); virtual void DidCreateDocumentElement(WebKit::WebFrame* frame) OVERRIDE;
virtual void DidStartProvisionalLoad(WebKit::WebFrame* frame); virtual void DidStartProvisionalLoad(WebKit::WebFrame* frame) OVERRIDE;
virtual void FrameDetached(WebKit::WebFrame* frame); virtual void FrameDetached(WebKit::WebFrame* frame) OVERRIDE;
virtual void DidCreateDataSource(WebKit::WebFrame* frame, virtual void DidCreateDataSource(WebKit::WebFrame* frame,
WebKit::WebDataSource* ds); WebKit::WebDataSource* ds) OVERRIDE;
void OnExtensionResponse(int request_id, bool success, void OnExtensionResponse(int request_id, bool success,
const std::string& response, const std::string& response,
......
...@@ -106,8 +106,8 @@ class PrintWebViewHelper ...@@ -106,8 +106,8 @@ class PrintWebViewHelper
#endif // defined(OS_WIN) || defined(OS_MACOSX) #endif // defined(OS_WIN) || defined(OS_MACOSX)
// RenderViewObserver implementation. // RenderViewObserver implementation.
virtual bool OnMessageReceived(const IPC::Message& message); virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
virtual void PrintPage(WebKit::WebFrame* frame); virtual void PrintPage(WebKit::WebFrame* frame) OVERRIDE;
// Message handlers --------------------------------------------------------- // Message handlers ---------------------------------------------------------
......
...@@ -29,7 +29,7 @@ class RendererHistogramSnapshots : public HistogramSender, ...@@ -29,7 +29,7 @@ class RendererHistogramSnapshots : public HistogramSender,
private: private:
// RenderProcessObserver implementation. // RenderProcessObserver implementation.
virtual bool OnControlMessageReceived(const IPC::Message& message); virtual bool OnControlMessageReceived(const IPC::Message& message) OVERRIDE;
void OnGetRendererHistograms(int sequence_number); void OnGetRendererHistograms(int sequence_number);
...@@ -46,10 +46,10 @@ class RendererHistogramSnapshots : public HistogramSender, ...@@ -46,10 +46,10 @@ class RendererHistogramSnapshots : public HistogramSender,
// HistogramSender interface (override) methods. // HistogramSender interface (override) methods.
virtual void TransmitHistogramDelta( virtual void TransmitHistogramDelta(
const base::Histogram& histogram, const base::Histogram& histogram,
const base::Histogram::SampleSet& snapshot); const base::Histogram::SampleSet& snapshot) OVERRIDE;
virtual void InconsistencyDetected(int problem); virtual void InconsistencyDetected(int problem) OVERRIDE;
virtual void UniqueInconsistencyDetected(int problem); virtual void UniqueInconsistencyDetected(int problem) OVERRIDE;
virtual void SnapshotProblemResolved(int amount); virtual void SnapshotProblemResolved(int amount) OVERRIDE;
// Collection of histograms to send to the browser. // Collection of histograms to send to the browser.
HistogramPickledList pickled_histograms_; HistogramPickledList pickled_histograms_;
......
...@@ -22,7 +22,7 @@ class RendererTracking : public content::RenderProcessObserver { ...@@ -22,7 +22,7 @@ class RendererTracking : public content::RenderProcessObserver {
private: private:
// RenderProcessObserver implementation. // RenderProcessObserver implementation.
virtual bool OnControlMessageReceived(const IPC::Message& message); virtual bool OnControlMessageReceived(const IPC::Message& message) OVERRIDE;
void OnGetRendererTrackingData(int sequence_number); void OnGetRendererTrackingData(int sequence_number);
......
...@@ -33,7 +33,7 @@ class SearchBox : public content::RenderViewObserver, ...@@ -33,7 +33,7 @@ class SearchBox : public content::RenderViewObserver,
private: private:
// RenderViewObserver implementation. // RenderViewObserver implementation.
virtual bool OnMessageReceived(const IPC::Message& message); virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
void OnChange(const string16& value, void OnChange(const string16& value,
bool verbatim, bool verbatim,
......
...@@ -29,21 +29,21 @@ class SecurityFilterPeer : public webkit_glue::ResourceLoaderBridge::Peer { ...@@ -29,21 +29,21 @@ class SecurityFilterPeer : public webkit_glue::ResourceLoaderBridge::Peer {
int os_error); int os_error);
// ResourceLoaderBridge::Peer methods. // ResourceLoaderBridge::Peer methods.
virtual void OnUploadProgress(uint64 position, uint64 size); virtual void OnUploadProgress(uint64 position, uint64 size) OVERRIDE;
virtual bool OnReceivedRedirect( virtual bool OnReceivedRedirect(
const GURL& new_url, const GURL& new_url,
const webkit_glue::ResourceResponseInfo& info, const webkit_glue::ResourceResponseInfo& info,
bool* has_new_first_party_for_cookies, bool* has_new_first_party_for_cookies,
GURL* new_first_party_for_cookies); GURL* new_first_party_for_cookies) OVERRIDE;
virtual void OnReceivedResponse( virtual void OnReceivedResponse(
const webkit_glue::ResourceResponseInfo& info); const webkit_glue::ResourceResponseInfo& info) OVERRIDE;
virtual void OnDownloadedData(int len) {} virtual void OnDownloadedData(int len) OVERRIDE {}
virtual void OnReceivedData(const char* data, virtual void OnReceivedData(const char* data,
int data_length, int data_length,
int encoded_data_length); int encoded_data_length) OVERRIDE;
virtual void OnCompletedRequest(const net::URLRequestStatus& status, virtual void OnCompletedRequest(const net::URLRequestStatus& status,
const std::string& security_info, const std::string& security_info,
const base::Time& completion_time); const base::Time& completion_time) OVERRIDE;
protected: protected:
SecurityFilterPeer(webkit_glue::ResourceLoaderBridge* resource_loader_bridge, SecurityFilterPeer(webkit_glue::ResourceLoaderBridge* resource_loader_bridge,
...@@ -67,13 +67,13 @@ class BufferedPeer : public SecurityFilterPeer { ...@@ -67,13 +67,13 @@ class BufferedPeer : public SecurityFilterPeer {
// ResourceLoaderBridge::Peer Implementation. // ResourceLoaderBridge::Peer Implementation.
virtual void OnReceivedResponse( virtual void OnReceivedResponse(
const webkit_glue::ResourceResponseInfo& info); const webkit_glue::ResourceResponseInfo& info) OVERRIDE;
virtual void OnReceivedData(const char* data, virtual void OnReceivedData(const char* data,
int data_length, int data_length,
int encoded_data_length); int encoded_data_length) OVERRIDE;
virtual void OnCompletedRequest(const net::URLRequestStatus& status, virtual void OnCompletedRequest(const net::URLRequestStatus& status,
const std::string& security_info, const std::string& security_info,
const base::Time& completion_time); const base::Time& completion_time) OVERRIDE;
protected: protected:
// Invoked when the entire request has been processed before the data is sent // Invoked when the entire request has been processed before the data is sent
...@@ -109,13 +109,13 @@ class ReplaceContentPeer : public SecurityFilterPeer { ...@@ -109,13 +109,13 @@ class ReplaceContentPeer : public SecurityFilterPeer {
// ResourceLoaderBridge::Peer Implementation. // ResourceLoaderBridge::Peer Implementation.
virtual void OnReceivedResponse( virtual void OnReceivedResponse(
const webkit_glue::ResourceResponseInfo& info); const webkit_glue::ResourceResponseInfo& info) OVERRIDE;
virtual void OnReceivedData(const char* data, virtual void OnReceivedData(const char* data,
int data_length, int data_length,
int encoded_data_length); int encoded_data_length) OVERRIDE;
virtual void OnCompletedRequest(const net::URLRequestStatus& status, virtual void OnCompletedRequest(const net::URLRequestStatus& status,
const std::string& security_info, const std::string& security_info,
const base::Time& completion_time); const base::Time& completion_time) OVERRIDE;
private: private:
webkit_glue::ResourceResponseInfo response_info_; webkit_glue::ResourceResponseInfo response_info_;
......
...@@ -71,7 +71,7 @@ class SpellCheck : public content::RenderProcessObserver { ...@@ -71,7 +71,7 @@ class SpellCheck : public content::RenderProcessObserver {
FRIEND_TEST(SpellCheckTest, GetAutoCorrectionWord_EN_US); FRIEND_TEST(SpellCheckTest, GetAutoCorrectionWord_EN_US);
// RenderProcessObserver implementation: // RenderProcessObserver implementation:
virtual bool OnControlMessageReceived(const IPC::Message& message); virtual bool OnControlMessageReceived(const IPC::Message& message) OVERRIDE;
// Message handlers. // Message handlers.
void OnInit(IPC::PlatformFileForTransit bdict_file, void OnInit(IPC::PlatformFileForTransit bdict_file,
......
...@@ -50,8 +50,8 @@ class SpellCheckProvider : public content::RenderViewObserver, ...@@ -50,8 +50,8 @@ class SpellCheckProvider : public content::RenderViewObserver,
int document_tag() const { return document_tag_; } int document_tag() const { return document_tag_; }
// RenderViewObserver implementation. // RenderViewObserver implementation.
virtual bool OnMessageReceived(const IPC::Message& message); virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
virtual void FocusedNodeChanged(const WebKit::WebNode& node); virtual void FocusedNodeChanged(const WebKit::WebNode& node) OVERRIDE;
void SetSpellCheck(SpellCheck* spellcheck); void SetSpellCheck(SpellCheck* spellcheck);
......
...@@ -83,7 +83,7 @@ class TranslateHelper : public content::RenderViewObserver { ...@@ -83,7 +83,7 @@ class TranslateHelper : public content::RenderViewObserver {
static std::string DetermineTextLanguage(const string16& text); static std::string DetermineTextLanguage(const string16& text);
// RenderViewObserver implementation. // RenderViewObserver implementation.
virtual bool OnMessageReceived(const IPC::Message& message); virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
// Cancels any translation that is currently being performed. This does not // Cancels any translation that is currently being performed. This does not
// revert existing translations. // revert existing translations.
......
// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. // Copyright (c) 2011 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
...@@ -6,6 +6,7 @@ ...@@ -6,6 +6,7 @@
#define CHROME_RENDERER_VISITEDLINK_SLAVE_H_ #define CHROME_RENDERER_VISITEDLINK_SLAVE_H_
#pragma once #pragma once
#include "base/compiler_specific.h"
#include "base/shared_memory.h" #include "base/shared_memory.h"
#include "chrome/common/visitedlink_common.h" #include "chrome/common/visitedlink_common.h"
#include "content/public/renderer/render_process_observer.h" #include "content/public/renderer/render_process_observer.h"
...@@ -19,7 +20,7 @@ class VisitedLinkSlave : public VisitedLinkCommon, ...@@ -19,7 +20,7 @@ class VisitedLinkSlave : public VisitedLinkCommon,
virtual ~VisitedLinkSlave(); virtual ~VisitedLinkSlave();
// RenderProcessObserver implementation. // RenderProcessObserver implementation.
virtual bool OnControlMessageReceived(const IPC::Message& message); virtual bool OnControlMessageReceived(const IPC::Message& message) OVERRIDE;
// Message handlers. // Message handlers.
void OnUpdateVisitedLinks(base::SharedMemoryHandle table); void OnUpdateVisitedLinks(base::SharedMemoryHandle table);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment