Commit 535012d3 authored by Ian Barkley-Yeung's avatar Ian Barkley-Yeung Committed by Commit Bot

Fix unit test on Windows

Stop unit test FileEnumerator::GetInfoDotDot from failing on Windows.
The unit test is showing a real bug in Windows, but it's not one we can
fix, so skip the check on Windows.

Fixed: chromium:1108304

Change-Id: Ibf0efa1a18fbd6c9a8008425eb7192f6a5e665a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314816
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
Auto-Submit: Ian Barkley-Yeung <iby@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791370}
parent f92e451c
......@@ -551,6 +551,11 @@ TEST(FileEnumerator, GetInfoRecursive) {
#if defined(OS_FUCHSIA)
// FileEnumerator::GetInfo does not work correctly with INCLUDE_DOT_DOT.
// https://crbug.com/1106172
#elif defined(OS_WIN)
// Windows has a bug in their handling of ".."; they always report the file
// modification time of the current directory, not the parent directory. This is
// a bug in Windows, not us -- you can see it with the "dir" command (notice
// that the time of . and .. always match). Skip this test.
#else
// Tests that FileEnumerator::GetInfo() returns the correct info for the ..
// directory.
......@@ -603,6 +608,6 @@ TEST(FileEnumerator, GetInfoDotDot) {
<< "File " << file.path.value() << " was not returned";
}
}
#endif // !defined(OS_FUCHSIA)
#endif // !defined(OS_FUCHSIA) && !defined(OS_WIN)
} // namespace base
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment