Commit 5356fbea authored by Collin Baker's avatar Collin Baker Committed by Commit Bot

Change corner radius and dimensions for in-product help promo bubbles

Bug: 909740
Change-Id: Iffe0d9f944765f313edd50138dd07d32db653e64
Reviewed-on: https://chromium-review.googlesource.com/c/1362299
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Reviewed-by: default avatarPeter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614834}
parent d6e4e9c5
......@@ -8,11 +8,13 @@
#include "base/strings/string_number_conversions.h"
#include "chrome/browser/themes/theme_properties.h"
#include "chrome/browser/ui/views/chrome_layout_provider.h"
#include "components/variations/variations_associated_data.h"
#include "ui/base/l10n/l10n_util.h"
#include "ui/base/theme_provider.h"
#include "ui/gfx/geometry/insets.h"
#include "ui/gfx/text_utils.h"
#include "ui/views/bubble/bubble_frame_view.h"
#include "ui/views/controls/label.h"
#include "ui/views/event_monitor.h"
#include "ui/views/layout/box_layout.h"
......@@ -28,6 +30,9 @@ constexpr base::TimeDelta kDelayDefault = base::TimeDelta::FromSeconds(5);
// user stops hovering over it.
constexpr base::TimeDelta kDelayShort = base::TimeDelta::FromSeconds(1);
// The insets from the bubble border to the text inside.
constexpr gfx::Insets kBubbleContentsInsets(12, 16);
} // namespace
FeaturePromoBubbleView::FeaturePromoBubbleView(
......@@ -73,7 +78,7 @@ FeaturePromoBubbleView::FeaturePromoBubbleView(
ThemeProperties::COLOR_FEATURE_PROMO_BUBBLE_TEXT);
auto box_layout = std::make_unique<views::BoxLayout>(
views::BoxLayout::kVertical, gfx::Insets(), 0);
views::BoxLayout::kVertical, kBubbleContentsInsets, 0);
box_layout->set_main_axis_alignment(
views::BoxLayout::MAIN_AXIS_ALIGNMENT_CENTER);
box_layout->set_cross_axis_alignment(
......@@ -90,10 +95,16 @@ FeaturePromoBubbleView::FeaturePromoBubbleView(
set_shadow(views::BubbleBorder::BIG_SHADOW);
}
set_margins(gfx::Insets());
set_title_margins(gfx::Insets());
set_color(background_color);
views::Widget* widget = views::BubbleDialogDelegateView::CreateBubble(this);
GetBubbleFrameView()->bubble_border()->SetCornerRadius(
ChromeLayoutProvider::Get()->GetCornerRadiusMetric(views::EMPHASIS_HIGH));
widget->Show();
if (activation_action == ActivationAction::ACTIVATE)
StartAutoCloseTimer(kDelayDefault);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment