Commit 53948175 authored by Tatiana Buldina's avatar Tatiana Buldina Committed by Commit Bot

[ChromeDriver] Delete unimplemented commands

Bug: chromedriver:2079
Change-Id: I5395a899686cb8b5f4d2a48f8ea6d7cfa9939e51
Reviewed-on: https://chromium-review.googlesource.com/1256109Reviewed-by: default avatarJohn Chen <johnchen@chromium.org>
Commit-Queue: Tatiana Buldina <buldina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595648}
parent 06d9324b
...@@ -70,8 +70,6 @@ class Method(object): ...@@ -70,8 +70,6 @@ class Method(object):
# this data throughout chromedriver code (see e.g. http_handler.cc) # this data throughout chromedriver code (see e.g. http_handler.cc)
_COMMANDS = { _COMMANDS = {
"AcceptAlert": (Method.POST, "/session/:sessionId/alert/accept"), "AcceptAlert": (Method.POST, "/session/:sessionId/alert/accept"),
"Activate": (Method.POST, "/session/:sessionId/ime/activate"),
"Activated": (Method.GET, "/session/:sessionId/ime/activated"),
"AddCookie": (Method.POST, "/session/:sessionId/cookie"), "AddCookie": (Method.POST, "/session/:sessionId/cookie"),
"ClearElement": (Method.POST, "/session/:sessionId/element/:id/clear"), "ClearElement": (Method.POST, "/session/:sessionId/element/:id/clear"),
"ClearLocalStorage": (Method.DELETE, "/session/:sessionId/local_storage"), "ClearLocalStorage": (Method.DELETE, "/session/:sessionId/local_storage"),
...@@ -80,7 +78,6 @@ _COMMANDS = { ...@@ -80,7 +78,6 @@ _COMMANDS = {
"Click": (Method.POST, "/session/:sessionId/click"), "Click": (Method.POST, "/session/:sessionId/click"),
"ClickElement": (Method.POST, "/session/:sessionId/element/:id/click"), "ClickElement": (Method.POST, "/session/:sessionId/element/:id/click"),
"CloseWindow": (Method.DELETE, "/session/:sessionId/window"), "CloseWindow": (Method.DELETE, "/session/:sessionId/window"),
"Deactivate": (Method.POST, "/session/:sessionId/ime/deactivate"),
"DeleteActions": (Method.DELETE, "/session/:sessionId/actions"), "DeleteActions": (Method.DELETE, "/session/:sessionId/actions"),
"DeleteAllCookies": (Method.DELETE, "/session/:sessionId/cookie"), "DeleteAllCookies": (Method.DELETE, "/session/:sessionId/cookie"),
"DeleteCookie": (Method.DELETE, "/session/:sessionId/cookie/:name"), "DeleteCookie": (Method.DELETE, "/session/:sessionId/cookie/:name"),
...@@ -90,13 +87,11 @@ _COMMANDS = { ...@@ -90,13 +87,11 @@ _COMMANDS = {
(Method.DELETE, "/session/:sessionId/orientation"), (Method.DELETE, "/session/:sessionId/orientation"),
"DismissAlert": (Method.POST, "/session/:sessionId/dismiss_alert"), "DismissAlert": (Method.POST, "/session/:sessionId/dismiss_alert"),
"DoubleClick": (Method.POST, "/session/:sessionId/doubleclick"), "DoubleClick": (Method.POST, "/session/:sessionId/doubleclick"),
"Drag": (Method.POST, "/session/:sessionId/element/:id/drag"),
"ElementScreenshot": "ElementScreenshot":
(Method.GET, "/session/:sessionId/element/:id/screenshot"), (Method.GET, "/session/:sessionId/element/:id/screenshot"),
"ExecuteAsyncScript": (Method.POST, "/session/:sessionId/execute_async"), "ExecuteAsyncScript": (Method.POST, "/session/:sessionId/execute_async"),
"ExecuteCDP": (Method.POST, "/session/:sessionId/goog/cdp/execute"), "ExecuteCDP": (Method.POST, "/session/:sessionId/goog/cdp/execute"),
"ExecuteScript": (Method.POST, "/session/:sessionId/execute/sync"), "ExecuteScript": (Method.POST, "/session/:sessionId/execute/sync"),
"ExecuteSql": (Method.POST, "/session/:sessionId/execute_sql"),
"FindChildElement": "FindChildElement":
(Method.POST, "/session/:sessionId/element/:id/element"), (Method.POST, "/session/:sessionId/element/:id/element"),
"FindChildElements": "FindChildElements":
...@@ -106,12 +101,7 @@ _COMMANDS = { ...@@ -106,12 +101,7 @@ _COMMANDS = {
"Freeze": (Method.POST, "/session/:sessionId/goog/page/freeze"), "Freeze": (Method.POST, "/session/:sessionId/goog/page/freeze"),
"FullscreenWindow": (Method.POST, "/session/:sessionId/window/fullscreen"), "FullscreenWindow": (Method.POST, "/session/:sessionId/window/fullscreen"),
"GetActiveElement": (Method.POST, "/session/:sessionId/element/active"), "GetActiveElement": (Method.POST, "/session/:sessionId/element/active"),
"GetActiveEngine": (Method.GET, "/session/:sessionId/ime/active_engine"),
"GetAlertMessage": (Method.GET, "/session/:sessionId/alert_text"), "GetAlertMessage": (Method.GET, "/session/:sessionId/alert_text"),
"GetAvailableEngines":
(Method.GET, "/session/:sessionId/ime/available_engines"),
"GetBrowserConnection":
(Method.GET, "/session/:sessionId/browser_connection"),
"GetCookies": (Method.GET, "/session/:sessionId/cookie"), "GetCookies": (Method.GET, "/session/:sessionId/cookie"),
"GetElementAttribute": "GetElementAttribute":
(Method.GET, "/session/:sessionId/element/:id/attribute/:name"), (Method.GET, "/session/:sessionId/element/:id/attribute/:name"),
...@@ -180,7 +170,6 @@ _COMMANDS = { ...@@ -180,7 +170,6 @@ _COMMANDS = {
(Method.GET, "/session/:sessionId/element/:id/selected"), (Method.GET, "/session/:sessionId/element/:id/selected"),
"IsLoading": (Method.GET, "/session/:sessionId/is_loading"), "IsLoading": (Method.GET, "/session/:sessionId/is_loading"),
"LaunchApp": (Method.POST, "/session/:sessionId/chromium/launch_app"), "LaunchApp": (Method.POST, "/session/:sessionId/chromium/launch_app"),
"Logs": (Method.POST, "Logs"),
"MaximizeWindow": (Method.POST, "/session/:sessionId/window/maximize"), "MaximizeWindow": (Method.POST, "/session/:sessionId/window/maximize"),
"MinimizeWindow": (Method.POST, "/session/:sessionId/window/minimize"), "MinimizeWindow": (Method.POST, "/session/:sessionId/window/minimize"),
"MouseDown": (Method.POST, "/session/:sessionId/buttondown"), "MouseDown": (Method.POST, "/session/:sessionId/buttondown"),
...@@ -201,8 +190,6 @@ _COMMANDS = { ...@@ -201,8 +190,6 @@ _COMMANDS = {
(Method.POST, "/session/:sessionId/chromium/send_command_and_get_result"), (Method.POST, "/session/:sessionId/chromium/send_command_and_get_result"),
"SetAlertPrompt": (Method.POST, "/session/:sessionId/alert_text"), "SetAlertPrompt": (Method.POST, "/session/:sessionId/alert_text"),
"SetAutoReporting": (Method.POST, "/session/:sessionId/autoreport"), "SetAutoReporting": (Method.POST, "/session/:sessionId/autoreport"),
"SetBrowserConnection":
(Method.POST, "/session/:sessionId/browser_connection"),
"SetGeolocation": (Method.POST, "/session/:sessionId/location"), "SetGeolocation": (Method.POST, "/session/:sessionId/location"),
"SetImplicitWait": "SetImplicitWait":
(Method.POST, "/session/:sessionId/timeouts/implicit_wait"), (Method.POST, "/session/:sessionId/timeouts/implicit_wait"),
...@@ -237,8 +224,7 @@ _COMMANDS = { ...@@ -237,8 +224,7 @@ _COMMANDS = {
"TouchUp": (Method.POST, "/session/:sessionId/touch/up"), "TouchUp": (Method.POST, "/session/:sessionId/touch/up"),
"Type": (Method.POST, "/session/:sessionId/keys"), "Type": (Method.POST, "/session/:sessionId/keys"),
"TypeElement": (Method.POST, "/session/:sessionId/element/:id/value"), "TypeElement": (Method.POST, "/session/:sessionId/element/:id/value"),
"UploadFile": (Method.POST, "/session/:sessionId/file"), "UploadFile": (Method.POST, "/session/:sessionId/file")
"Visible": (Method.POST, "/session/:sessionId/visible")
} }
MULTI_SESSION_COMMANDS = ["GetSessions"] MULTI_SESSION_COMMANDS = ["GetSessions"]
......
...@@ -449,21 +449,6 @@ HttpHandler::HttpHandler( ...@@ -449,21 +449,6 @@ HttpHandler::HttpHandler(
CommandMapping( CommandMapping(
kPost, "session/:sessionId/keys", kPost, "session/:sessionId/keys",
WrapToCommand("Type", base::Bind(&ExecuteSendKeysToActiveElement))), WrapToCommand("Type", base::Bind(&ExecuteSendKeysToActiveElement))),
CommandMapping(kGet, "session/:sessionId/ime/available_engines",
WrapToCommand("GetAvailableEngines",
base::Bind(&ExecuteUnimplementedCommand))),
CommandMapping(kGet, "session/:sessionId/ime/active_engine",
WrapToCommand("GetActiveEngine",
base::Bind(&ExecuteUnimplementedCommand))),
CommandMapping(
kGet, "session/:sessionId/ime/activated",
WrapToCommand("Activated", base::Bind(&ExecuteUnimplementedCommand))),
CommandMapping(kPost, "session/:sessionId/ime/deactivate",
WrapToCommand("Deactivate",
base::Bind(&ExecuteUnimplementedCommand))),
CommandMapping(
kPost, "session/:sessionId/ime/activate",
WrapToCommand("Activate", base::Bind(&ExecuteUnimplementedCommand))),
CommandMapping(kPost, "session/:sessionId/touch/click", CommandMapping(kPost, "session/:sessionId/touch/click",
WrapToCommand("Tap", base::Bind(&ExecuteTouchSingleTap))), WrapToCommand("Tap", base::Bind(&ExecuteTouchSingleTap))),
CommandMapping(kPost, "session/:sessionId/touch/down", CommandMapping(kPost, "session/:sessionId/touch/down",
...@@ -504,12 +489,6 @@ HttpHandler::HttpHandler( ...@@ -504,12 +489,6 @@ HttpHandler::HttpHandler(
CommandMapping( CommandMapping(
kGet, "session/:sessionId/chromium/heap_snapshot", kGet, "session/:sessionId/chromium/heap_snapshot",
WrapToCommand("HeapSnapshot", base::Bind(&ExecuteTakeHeapSnapshot))), WrapToCommand("HeapSnapshot", base::Bind(&ExecuteTakeHeapSnapshot))),
CommandMapping(
kPost, "session/:sessionId/visible",
WrapToCommand("Visible", base::Bind(&ExecuteUnimplementedCommand))),
CommandMapping(
kGet, "session/:sessionId/visible",
WrapToCommand("Visible", base::Bind(&ExecuteUnimplementedCommand))),
CommandMapping( CommandMapping(
kPost, "session/:sessionId/file", kPost, "session/:sessionId/file",
WrapToCommand("UploadFile", base::Bind(&ExecuteUploadFile))), WrapToCommand("UploadFile", base::Bind(&ExecuteUploadFile))),
...@@ -519,14 +498,6 @@ HttpHandler::HttpHandler( ...@@ -519,14 +498,6 @@ HttpHandler::HttpHandler(
CommandMapping( CommandMapping(
kPost, "session/:sessionId/element/:id/hover", kPost, "session/:sessionId/element/:id/hover",
WrapToCommand("HoverElement", base::Bind(&ExecuteHoverOverElement))), WrapToCommand("HoverElement", base::Bind(&ExecuteHoverOverElement))),
CommandMapping(
kPost, "session/:sessionId/element/:id/drag",
WrapToCommand("Drag", base::Bind(&ExecuteUnimplementedCommand))),
CommandMapping(kPost, "session/:sessionId/execute_sql",
WrapToCommand("ExecuteSql",
base::Bind(&ExecuteUnimplementedCommand))),
CommandMapping(kGet, "session/:sessionId/network_connection", CommandMapping(kGet, "session/:sessionId/network_connection",
WrapToCommand("GetNetworkConnection", WrapToCommand("GetNetworkConnection",
base::Bind(&ExecuteGetNetworkConnection))), base::Bind(&ExecuteGetNetworkConnection))),
...@@ -540,20 +511,10 @@ HttpHandler::HttpHandler( ...@@ -540,20 +511,10 @@ HttpHandler::HttpHandler(
kDelete, "session/:sessionId/chromium/network_conditions", kDelete, "session/:sessionId/chromium/network_conditions",
WrapToCommand("DeleteNetworkConditions", WrapToCommand("DeleteNetworkConditions",
base::Bind(&ExecuteDeleteNetworkConditions))), base::Bind(&ExecuteDeleteNetworkConditions))),
CommandMapping(kGet, "session/:sessionId/browser_connection",
WrapToCommand("GetBrowserConnection",
base::Bind(&ExecuteUnimplementedCommand))),
CommandMapping(kPost, "session/:sessionId/browser_connection",
WrapToCommand("SetBrowserConnection",
base::Bind(&ExecuteUnimplementedCommand))),
CommandMapping( CommandMapping(
kDelete, "session/:sessionId/orientation", kDelete, "session/:sessionId/orientation",
WrapToCommand("DeleteScreenOrientation", WrapToCommand("DeleteScreenOrientation",
base::Bind(&ExecuteDeleteScreenOrientation))), base::Bind(&ExecuteDeleteScreenOrientation))),
CommandMapping(
kPost, "Logs",
WrapToCommand("Logs", base::Bind(&ExecuteUnimplementedCommand))),
CommandMapping( CommandMapping(
kGet, kShutdownPath, kGet, kShutdownPath,
base::Bind(&ExecuteQuitAll, base::Bind(&ExecuteQuitAll,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment