Commit 53a28d00 authored by gcasto's avatar gcasto Committed by Commit bot

[Password Generation] Fix bug where the same form may not compare as equal

This is because currently the forms we are comparing are saved at slightly
different times and so may be modified in between. This change brings
PasswordGenerationAgent in line with AutofillAgent.

BUG=452741

Review URL: https://codereview.chromium.org/877193004

Cr-Commit-Position: refs/heads/master@{#314048}
parent 1aa788c1
......@@ -155,13 +155,11 @@ void PasswordGenerationAgent::DidFinishDocumentLoad() {
password_generation::EDITING_POPUP_SHOWN);
}
editing_popup_shown_ = false;
}
void PasswordGenerationAgent::OnDynamicFormsSeen() {
FindPossibleGenerationForm();
}
void PasswordGenerationAgent::DidFinishLoad() {
void PasswordGenerationAgent::OnDynamicFormsSeen() {
FindPossibleGenerationForm();
}
......
......@@ -71,7 +71,6 @@ class PasswordGenerationAgent : public content::RenderFrameObserver {
// RenderFrameObserver:
void DidFinishDocumentLoad() override;
void DidFinishLoad() override;
// Message handlers.
void OnFormNotBlacklisted(const PasswordForm& form);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment