Commit 53c297fe authored by Jimmy Gong's avatar Jimmy Gong Committed by Commit Bot

Fix bug where legacy no search found message was showing

- This bug occurs when there are saved printers and the users inputs
  a search term. This resulted in an unintended "no search found"
  message.
- A future CL will update the no search found message accordingly to
  saved printers and nearby printers.

Bug: 997116
Test: end to end manual
Change-Id: Ic008af47aeac0f401c81f8a6cd1ea99834e49e85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769217
Commit-Queue: jimmy gong <jimmyxgong@chromium.org>
Reviewed-by: default avatarKyle Horimoto <khorimoto@chromium.org>
Reviewed-by: default avatarBailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693903}
parent cae50f69
...@@ -108,6 +108,11 @@ ...@@ -108,6 +108,11 @@
active-printer="{{activePrinter}}" active-printer="{{activePrinter}}"
search-term="[[searchTerm]]"> search-term="[[searchTerm]]">
</settings-cups-printers-list> </settings-cups-printers-list>
<div id="noSearchResultsMessage"
hidden="[[!showNoSearchResultsMessage_(searchTerm)]]">
$i18n{noSearchResults}
</div>
</template> </template>
<template is="dom-if" if="[[enableUpdatedUi_]]"> <template is="dom-if" if="[[enableUpdatedUi_]]">
...@@ -187,11 +192,6 @@ ...@@ -187,11 +192,6 @@
</settings-cups-edit-printer-dialog> </settings-cups-edit-printer-dialog>
</template> </template>
<div id="noSearchResultsMessage"
hidden="[[!showNoSearchResultsMessage_(searchTerm)]]">
$i18n{noSearchResults}
</div>
<cr-toast id="errorToast" duration="3000"> <cr-toast id="errorToast" duration="3000">
<div class="error-message" id="addPrinterDoneMessage"> <div class="error-message" id="addPrinterDoneMessage">
[[addPrinterResultText_]] [[addPrinterResultText_]]
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment