Don't build DevTools frontend on Android

Android does not use it, so we shouldn't build it.

When looking at a ninja trace on the android-binary-size trybot, this target
showed up on the critical path and taking ~2 minutes to build.

TBR=agrieve  # Mechanical BUILD target renames.

Bug: 1078460.
Change-Id: I645277778762cd5e30cd81ce84a5776d38c3fdcb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258469
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782113}

content/browser/BUILD.gn

@@ -2103,9 +2103,7 @@ jumbo_source_set("browser") {
     ]
   }
 
-  if (!is_fuchsia) {
-    # Fuchsia does not support DevTools front-end, so only only build DevTools
-    # resources on other platforms.
+  if (!is_fuchsia && !is_android) {
     deps += [ "//content/browser/devtools:devtools_resources" ]
   }
 

content/browser/devtools/BUILD.gn

@@ -6,42 +6,39 @@ import("//third_party/inspector_protocol/inspector_protocol.gni")
 import("//third_party/protobuf/proto_library.gni")
 import("//tools/grit/grit_rule.gni")
 
-group("resources") {
-  if (!is_android) {
-    public_deps = [ ":devtools_resources" ]
-  }
-}
+# Android and Fuchsia do not support DevTools front-end.
+if (!is_android && !is_fuchsia) {
+  grit("devtools_resources") {
+    source = "$root_gen_dir/devtools/devtools_resources.grd"
 
-grit("devtools_resources") {
-  source = "$root_gen_dir/devtools/devtools_resources.grd"
+    # Required because the .grd is generated.
+    enable_input_discovery_for_gn_analyze = false
+    use_brotli = true
 
-  # Required because the .grd is generated.
-  enable_input_discovery_for_gn_analyze = false
-  use_brotli = true
-
-  outputs = [
-    "grit/devtools_resources.h",
-    "devtools_resources.pak",
-    "grit/devtools_resources_map.cc",
-    "grit/devtools_resources_map.h",
-  ]
+    outputs = [
+      "grit/devtools_resources.h",
+      "devtools_resources.pak",
+      "grit/devtools_resources_map.cc",
+      "grit/devtools_resources_map.h",
+    ]
 
-  grit_flags = [
-    "-E",
-    "protocol_file=" + rebase_path(
-            "$root_gen_dir/third_party/blink/public/devtools_protocol/protocol.json",
-            root_build_dir),
-  ]
+    grit_flags = [
+      "-E",
+      "protocol_file=" + rebase_path(
+              "$root_gen_dir/third_party/blink/public/devtools_protocol/protocol.json",
+              root_build_dir),
+    ]
 
-  defines =
-      [ "SHARED_INTERMEDIATE_DIR=" + rebase_path(root_gen_dir, root_build_dir) ]
+    defines = [ "SHARED_INTERMEDIATE_DIR=" +
+                rebase_path(root_gen_dir, root_build_dir) ]
 
-  deps = [
-    "//third_party/blink/public/devtools_protocol:protocol_version",
+    deps = [
+      "//third_party/blink/public/devtools_protocol:protocol_version",
 
-    # This is the action that generates out .grd input file.
-    "//third_party/blink/public:blink_generate_devtools_grd",
-  ]
+      # This is the action that generates out .grd input file.
+      "//third_party/blink/public:blink_generate_devtools_grd",
+    ]
+  }
 }
 
 inspector_protocol_generate("protocol_sources") {

content/browser/devtools/devtools_http_handler.cc

@@ -54,7 +54,7 @@
 #include "base/android/build_info.h"
 #endif
 
-#if !defined(OS_FUCHSIA)
+#if !defined(OS_ANDROID) && !defined(OS_FUCHSIA)
 #include "content/browser/devtools/grit/devtools_resources.h"  // nogncheck
 #endif
 
@@ -654,7 +654,7 @@ void DevToolsHttpHandler::OnJsonRequest(
 }
 
 void DevToolsHttpHandler::DecompressAndSendJsonProtocol(int connection_id) {
-#if defined(OS_FUCHSIA)
+#if defined(OS_ANDROID) || defined(OS_FUCHSIA)
   NOTREACHED();
 #else
   scoped_refptr<base::RefCountedMemory> bytes =
@@ -669,7 +669,7 @@ void DevToolsHttpHandler::DecompressAndSendJsonProtocol(int connection_id) {
       FROM_HERE, base::BindOnce(&ServerWrapper::SendResponse,
                                 base::Unretained(server_wrapper_.get()),
                                 connection_id, response));
-#endif  // defined(OS_FUCHSIA)
+#endif  // defined(OS_ANDROID) || defined(OS_FUCHSIA)
 }
 
 void DevToolsHttpHandler::RespondToJsonList(

content/shell/BUILD.gn

@@ -700,10 +700,10 @@ repack("pak") {
     sources +=
         [ "$root_gen_dir/ui/views/resources/views_resources_100_percent.pak" ]
   }
-  if (!is_android) {
+  if (!is_android && !is_fuchsia) {
     sources +=
         [ "$root_gen_dir/content/browser/devtools/devtools_resources.pak" ]
-    deps += [ "//content/browser/devtools:resources" ]
+    deps += [ "//content/browser/devtools:devtools_resources" ]
   }
   output = "$root_out_dir/content_shell.pak"
 }

headless/BUILD.gn

@@ -30,7 +30,6 @@ repack("pak") {
     "$root_gen_dir/components/components_resources.pak",
     "$root_gen_dir/components/strings/components_strings_en-US.pak",
     "$root_gen_dir/content/app/resources/content_resources_100_percent.pak",
-    "$root_gen_dir/content/browser/devtools/devtools_resources.pak",
     "$root_gen_dir/content/browser/tracing/tracing_resources.pak",
     "$root_gen_dir/content/content_resources.pak",
     "$root_gen_dir/content/dev_ui_content_resources.pak",
@@ -59,7 +58,6 @@ repack("pak") {
     "//content:content_resources",
     "//content:dev_ui_content_resources",
     "//content/app/resources",
-    "//content/browser/devtools:resources",
     "//content/browser/tracing:resources",
     "//mojo/public/js:resources",
     "//net:net_resources",
@@ -70,6 +68,12 @@ repack("pak") {
     "//ui/strings",
   ]
 
+  if (!is_fuchsia) {
+    sources +=
+        [ "$root_gen_dir/content/browser/devtools/devtools_resources.pak" ]
+    deps += [ "//content/browser/devtools:devtools_resources" ]
+  }
+
   output = "$root_out_dir/headless_lib.pak"
 }