Roll third_party/closure_compiler to v20190929.

chrome_extensions.js: 8c8758d268411a685b187a9942077c604a8e11c3 -> 5a25bfc4e006f1a965d362e27938611242908acd

 - Delete third_party/closure_compiler/externs/web_animations.js and
   all references to it. No longer needed since a better version of these
   externs is distributed within compiler.jar itself.
 - Fix newly found JSC_HIDDEN_INTERFACE_PROPERTY_MISMATCH, as a result of the
   interface checking overhaul at [1]
 - Fix/suppress newly found JSC_CONSTANT_PROPERTY_REASSIGNED_VALUE errors.

The latest version of chrome_extensions.js contains a fix needed by PDF Viewer.

[1] https://github.com/google/closure-compiler/commit/86acbd5e3ec78f08a1804df5f1efbea129d29c0e

Bug: 1011585
Change-Id: Ic7682834da9cfb75990d82fd8d34d3325d0a6bc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842626Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708089}

chrome/browser/resources/discards/graph_doc.js

@@ -28,13 +28,20 @@ class GraphNode {
     /** @type {string} */
     this.iconUrl = '';
 
-    // Implementation of the d3.ForceNode interface.
-    // See https://github.com/d3/d3-force#simulation_nodes.
-    this.index = null;
-    this.x = null;
-    this.y = null;
-    this.vx = null;
-    this.vy = null;
+    /**
+     * Implementation of the d3.ForceNode interface.
+     * See https://github.com/d3/d3-force#simulation_nodes.
+     * @type {number|undefined}
+     */
+    this.index;
+    /** @type {number|undefined} */
+    this.x;
+    /** @type {number|undefined} */
+    this.y;
+    /** @type {number|undefined} */
+    this.vx;
+    /** @type {number|undefined} */
+    this.vy;
     this.fx = null;
     this.fy = null;
   }

chrome/browser/resources/settings/about_page/BUILD.gn

@@ -30,7 +30,6 @@ js_library("about_page") {
     "//ui/webui/resources/js:parse_html_subset",
     "//ui/webui/resources/js:web_ui_listener_behavior",
   ]
-  externs_list = [ "$externs_path/web_animations.js" ]
 }
 
 js_library("about_page_browser_proxy") {

chrome/browser/resources/settings/chromeos/os_about_page/BUILD.gn

@@ -22,5 +22,4 @@ js_library("os_about_page") {
     "//ui/webui/resources/js:parse_html_subset",
     "//ui/webui/resources/js:web_ui_listener_behavior",
   ]
-  externs_list = [ "$externs_path/web_animations.js" ]
 }

chrome/browser/resources/settings/chromeos/os_toolbar/BUILD.gn

@@ -14,5 +14,4 @@ js_library("os_toolbar") {
   deps = [
     "//ui/webui/resources/cr_elements/cr_toolbar:cr_toolbar_search_field",
   ]
-  externs_list = [ "$externs_path/web_animations.js" ]
 }

chrome/browser/resources/settings/people_page/BUILD.gn

@@ -101,7 +101,6 @@ js_library("fingerprint_list") {
     "//ui/webui/resources/js:web_ui_listener_behavior",
     "//ui/webui/resources/js/cr/ui:focus_without_ink",
   ]
-  externs_list = [ "$externs_path/web_animations.js" ]
 }
 
 js_library("import_data_browser_proxy") {

third_party/closure_compiler/README.chromium

 Name: Closure compiler
 Short Name: closure-compiler
 URL: http://github.com/google/closure-compiler
-Version: v20190709
-Date: 2019/07/24 01:19
+Version: v20190929
+Date: 2019/10/07 21:43
 License: Apache 2.0
 License File: LICENSE
 Security Critical: no

third_party/closure_compiler/externs/chrome_extensions.js

@@ -7595,7 +7595,7 @@ ContentSetting.prototype.clear = function(details, opt_callback) {};
 /**
  * @param {!Object<string,(string|boolean|ResourceIdentifier)>} details
  *     Settings details.
- * @param {function(): void} callback Callback function.
+ * @param {function({setting: *}): void} callback Callback function.
  * @return {undefined}
  */
 ContentSetting.prototype.get = function(details, callback) {};

third_party/closure_compiler/externs/web_animations.js

-// Copyright 2016 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-/**
- * @fileoverview Minimal Closure externs for Web Animations.
- * "Minimal" because the web-animations spec is in flux, Chromium's support is
- * changing, and the intended consumer (MD Settings) is actually using the
- * web-animations-js polyfill for the time being.
- * @see https://w3c.github.io/web-animations/#programming-interface
- */
-
-/**
- * @enum {number}
- * @see https://w3c.github.io/web-animations/#enumdef-fillmode
- */
-var FillMode = {
-  'none': 0,
-  'forwards': 1,
-  'backwards': 2,
-  'both': 3,
-  'auto': 4
-};
-
-/**
- * @enum {number}
- * @see https://w3c.github.io/web-animations/#enumdef-playbackdirection
- */
-var PlaybackDirection = {
-  'normal': 0,
-  'reverse': 1,
-  'alternate': 2,
-  'alternate-reverse': 3
-};
-
-/**
- * @enum {number}
- * @see https://w3c.github.io/web-animations/#enumdef-iterationcompositeoperation
- */
-var IterationCompositeOperation = {
-  'replace': 0,
-  'accumulate': 1
-};
-
-/**
- * @enum {number}
- * @see https://w3c.github.io/web-animations/#enumdef-compositeoperation
- */
-var CompositeOperation = {
-  'replace': 0,
-  'add': 1,
-  'accumulate': 2
-};
-
-/**
- * @constructor
- * @param {!Event} event
- */
-var EventHandlerNonNull = function(event) {};
-
-/** @typedef {?EventHandlerNonNull} */
-var EventHandler;
-
-/**
- * @constructor
- * @see https://w3c.github.io/web-animations/#dictdef-keyframeanimationoptions
- */
-var KeyframeAnimationOptions = function() {};
-
-/**
- * @constructor
- * @see https://w3c.github.io/web-animations/#dictdef-keyframeeffectoptions
- */
-var KeyframeEffectOptions = function() {};
-
-/** @type {number} */
-KeyframeEffectOptions.prototype.delay;
-
-/** @type {number} */
-KeyframeEffectOptions.prototype.endDelay;
-
-/** @type {!FillMode} */
-KeyframeEffectOptions.prototype.fill;
-
-/** @type {number} */
-KeyframeEffectOptions.prototype.iterationStart;
-
-/** @type {number} */
-KeyframeEffectOptions.prototype.iterations;
-
-/** @type {number|string} */
-KeyframeEffectOptions.prototype.duration;
-
-/** @type {number} */
-KeyframeEffectOptions.prototype.playbackRate;
-
-/** @type {!PlaybackDirection} */
-KeyframeEffectOptions.prototype.direction;
-
-/** @type {string} */
-KeyframeEffectOptions.prototype.easing;
-
-/** @type {string} */
-KeyframeEffectOptions.prototype.id;
-
-/**
- * @interface
- * @see https://w3c.github.io/web-animations/#animatable
- */
-var Animatable = function() {};
-
-Animatable.prototype = /** @lends {Element.prototype} */({
-  /**
-   * @param {?Array<Object>|Object} effect
-   * @param {number|!KeyframeEffectOptions=} opt_timing
-   * @return {!Animation}
-   */
-  animate: function(effect, opt_timing) {},
-});

tools/polymer/generate_gn.py

@@ -12,9 +12,6 @@ import sys
 
 _COMPILE_JS = '//third_party/closure_compiler/compile_js.gni'
 _POLYMERS = ['polymer.html', 'polymer-mini.html', 'polymer-micro.html']
-_WEB_ANIMATIONS_BASE = 'web-animations.html'
-_WEB_ANIMATIONS_EXTERNS = \
-    '//third_party/closure_compiler/externs/web_animations.js'
 _COMPILED_RESOURCES_TEMPLATE = '''
 # Copyright %d The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
@@ -61,11 +58,6 @@ def main(created_by, html_files):
             if import_base in _POLYMERS:
                 continue
 
-            if import_base == _WEB_ANIMATIONS_BASE:
-                externs += '\n  externs_list = [ "%s" ]' % \
-                    _WEB_ANIMATIONS_EXTERNS
-                continue
-
             # Only exclude these after appending web animations externs.
             if not _has_extracted_js(path.join(html_dir, html_import)):
                 continue

tools/polymer/generate_gn_v3.py

@@ -11,9 +11,6 @@ import os.path as path
 import sys
 
 _COMPILE_JS = '//third_party/closure_compiler/compile_js.gni'
-_WEB_ANIMATIONS_BASE = 'web-animations.html'
-_WEB_ANIMATIONS_EXTERNS = \
-    '//third_party/closure_compiler/externs/web_animations.js'
 _COMPILED_RESOURCES_TEMPLATE = '''
 # Copyright %d The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
@@ -55,10 +52,6 @@ def main(created_by, input_files):
       for i in sorted(imports):
         import_dir, import_base = path.split(i.encode('ascii'))
 
-        if import_base == _WEB_ANIMATIONS_BASE:
-          externs += '\n  externs_list = [ "%s" ]' % _WEB_ANIMATIONS_EXTERNS
-          continue
-
         # Redirect dependencies to minified Polymer to the non-minified version.
         if import_base == 'polymer_bundled.min.js':
           import_base = 'polymer_bundled.js'

ui/file_manager/file_manager/foreground/elements/BUILD.gn

@@ -102,7 +102,6 @@ js_library("files_safe_media_webview_content") {
 # TODO(tapted): Move this to //ui/file_manager/base.
 js_library("files_toast") {
   visibility += [ "//ui/file_manager/gallery/*" ]
-  externs_list = [ "$externs_path/web_animations.js" ]
 }
 
 # TODO(tapted): Move this to //ui/file_manager/base.

ui/file_manager/file_manager/foreground/js/BUILD.gn

@@ -83,7 +83,6 @@ js_library("closure_compile_externs") {
   externs_list = [
     "$externs_path/command_line_private.js",
     "$externs_path/metrics_private.js",
-    "$externs_path/web_animations.js",
     "//ui/file_manager/externs/background/crostini.js",
     "//ui/file_manager/externs/background/drive_sync_handler.js",
     "//ui/file_manager/externs/background/file_browser_background.js",

ui/file_manager/file_manager/foreground/js/ui/BUILD.gn

@@ -64,7 +64,6 @@ js_library("closure_compile_externs") {
   sources = []
   externs_list = [
     "$externs_path/metrics_private.js",
-    "$externs_path/web_animations.js",
     "//ui/file_manager/externs/background/crostini.js",
     "//ui/file_manager/externs/background/drive_sync_handler.js",
     "//ui/file_manager/externs/background/file_browser_background.js",

ui/file_manager/file_manager/foreground/js/ui/file_manager_dialog_base_unittest.js

@@ -4,7 +4,7 @@
 
 async function testShowDialogAfterHide(done) {
   // Polyfill chrome.app.window.current().
-  /** @suppress {duplicate|checkTypes} */
+  /** @suppress {duplicate,checkTypes,const} */
   chrome.app = {window: {current: () => null}};
 
   const container =

ui/webui/resources/cr_elements/cr_dialog/BUILD.gn

@@ -16,7 +16,6 @@ js_library("cr_dialog") {
     "..:cr_container_shadow_behavior",
     "//ui/webui/resources/js:assert",
   ]
-  externs_list = [ "$externs_path/web_animations.js" ]
 }
 
 polymer_modulizer("cr_dialog") {
@@ -46,5 +45,4 @@ js_library("cr_dialog.m") {
     "//ui/webui/resources/js:assert.m",
   ]
   extra_deps = [ ":cr_dialog_module" ]
-  externs_list = [ "$externs_path/web_animations.js" ]
 }

ui/webui/resources/cr_elements/cr_toolbar/BUILD.gn

@@ -26,7 +26,6 @@ js_library("cr_toolbar") {
   deps = [
     ":cr_toolbar_search_field",
   ]
-  externs_list = [ "$externs_path/web_animations.js" ]
 }
 
 polymer_modulizer("cr_toolbar") {

ui/webui/resources/cr_elements/cr_view_manager/BUILD.gn

@@ -15,7 +15,6 @@ js_library("cr_view_manager") {
   deps = [
     "//ui/webui/resources/js:assert",
   ]
-  externs_list = [ "$externs_path/web_animations.js" ]
 }
 
 polymer_modulizer("cr_view_manager") {