Commit 5407ae12 authored by dfalcantara's avatar dfalcantara Committed by Commit bot

Get rid of "Open in Chrome" from EmbedContentViewActivity

Discussion resulted in zero-ish cases where this would be useful.

BUG=644848

Review-Url: https://codereview.chromium.org/2328703002
Cr-Commit-Position: refs/heads/master@{#417370}
parent 8569349a
...@@ -8,11 +8,9 @@ import android.app.ActionBar; ...@@ -8,11 +8,9 @@ import android.app.ActionBar;
import android.app.Activity; import android.app.Activity;
import android.content.Context; import android.content.Context;
import android.content.Intent; import android.content.Intent;
import android.net.Uri;
import android.view.Menu; import android.view.Menu;
import android.view.MenuItem; import android.view.MenuItem;
import org.chromium.chrome.R;
import org.chromium.chrome.browser.firstrun.FirstRunStatus; import org.chromium.chrome.browser.firstrun.FirstRunStatus;
import org.chromium.chrome.browser.fullscreen.ChromeFullscreenManager; import org.chromium.chrome.browser.fullscreen.ChromeFullscreenManager;
import org.chromium.chrome.browser.tab.Tab; import org.chromium.chrome.browser.tab.Tab;
...@@ -91,7 +89,6 @@ public class EmbedContentViewActivity extends FullScreenActivity { ...@@ -91,7 +89,6 @@ public class EmbedContentViewActivity extends FullScreenActivity {
public boolean onCreateOptionsMenu(Menu menu) { public boolean onCreateOptionsMenu(Menu menu) {
boolean retVal = super.onCreateOptionsMenu(menu); boolean retVal = super.onCreateOptionsMenu(menu);
if (!FirstRunStatus.getFirstRunFlowComplete(this)) return retVal; if (!FirstRunStatus.getFirstRunFlowComplete(this)) return retVal;
menu.add(Menu.NONE, R.id.menu_id_open_in_chrome, Menu.NONE, R.string.menu_open_in_chrome);
return true; return true;
} }
...@@ -102,13 +99,6 @@ public class EmbedContentViewActivity extends FullScreenActivity { ...@@ -102,13 +99,6 @@ public class EmbedContentViewActivity extends FullScreenActivity {
// Handles up navigation // Handles up navigation
finish(); finish();
return true; return true;
} else if (itemId == R.id.menu_id_open_in_chrome && getActivityTab() != null) {
Intent chromeIntent = new Intent(
Intent.ACTION_VIEW, Uri.parse(getActivityTab().getUrl()));
chromeIntent.setFlags(Intent.FLAG_ACTIVITY_NEW_TASK);
IntentHandler.startChromeLauncherActivityForTrustedIntent(
chromeIntent, getApplicationContext());
return true;
} }
return super.onOptionsItemSelected(item); return super.onOptionsItemSelected(item);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment