[Code Health] Enable gn check for //chrome/test/data/nacl

The nacl_test_data targets don't like deps on //base, so had to remove
the #include from //base in pm_exit_status_test.cc.

Bug: 949535
Change-Id: I9cbdd63dca2eb1147013d6747c265f3f3fe9916a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538042
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Erik Staab <estaab@chromium.org>
Reviewed-by: Mark Seaborn <mseaborn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827531}

.gn

@@ -78,7 +78,6 @@ no_check_targets = [
   "//chrome/services/ipp_parser:*",  # 1 error
   "//chrome/services/removable_storage_writer:*",  # 1 error
   "//chrome/services/util_win:*",  # 1 error
-  "//chrome/test/data/nacl:*",  # 350 errors
   "//chrome/test/media_router:*",  # 5 errors
   "//chrome/test:*",  # 2682 errors
 

chrome/test/data/nacl/BUILD.gn

@@ -129,7 +129,7 @@ if (is_nacl) {
     outputs = [ "${root_build_dir}/nacl_test_data/${nacl_toolchain_variant}/{{source_file_part}}" ]
   }
 
-  source_set("ppapi_test_lib") {
+  static_library("ppapi_test_lib") {
     sources = [
       "ppapi_test_lib/get_browser_interface.cc",
       "ppapi_test_lib/get_browser_interface.h",
@@ -144,6 +144,7 @@ if (is_nacl) {
     deps = [
       "//native_client/src/shared/gio",
       "//native_client/src/shared/platform",
+      "//ppapi/c",
       "//ppapi/native_client:ppapi_lib",
     ]
   }
@@ -234,6 +235,7 @@ if (is_nacl && !is_nacl_nonsfi) {
 
   nacl_test_data("ppapi_bad_ppp_initialize_crash") {
     sources = [ "bad/ppapi_bad_ppp_initialize_crash.cc" ]
+    deps = [ ":ppapi_test_lib" ]
     destination_dir = "nacl_test_data"
   }
 
@@ -245,6 +247,7 @@ if (is_nacl && !is_nacl_nonsfi) {
 
   nacl_test_data("ppapi_bad_get_ppp_instance_crash") {
     sources = [ "bad/ppapi_bad_get_ppp_instance_crash.cc" ]
+    deps = [ ":ppapi_test_lib" ]
     destination_dir = "nacl_test_data"
   }
 
@@ -255,6 +258,7 @@ if (is_nacl && !is_nacl_nonsfi) {
 
   nacl_test_data("ppapi_bad_ppp_instance_didcreate_crash") {
     sources = [ "bad/ppapi_bad_ppp_instance_didcreate_crash.cc" ]
+    deps = [ ":ppapi_test_lib" ]
     destination_dir = "nacl_test_data"
   }
 
@@ -477,6 +481,7 @@ if ((is_linux || is_chromeos) && is_clang) {
     output_name = "libc_free_$arch"
     output_extension = "nexe"
     sources = [ "nonsfi/libc_free.c" ]
+    deps = [ "//ppapi/c" ]
 
     no_default_deps = true
 

chrome/test/data/nacl/exit_status/pm_exit_status_test.cc

@@ -18,7 +18,6 @@
 #include <sys/fcntl.h>
 #include <unistd.h>
 
-#include "base/format_macros.h"
 #include "ppapi/cpp/instance.h"
 #include "ppapi/cpp/module.h"
 #include "ppapi/cpp/var.h"
@@ -94,14 +93,14 @@ void MyInstance::HandleMessage(const pp::Var& message_data) {
 
     for (size_t ix = 0; kMsgHandlers[ix].request != NULL; ++ix) {
       if (op_name == kMsgHandlers[ix].request) {
-        fprintf(stderr, "found at index %" PRIuS "\n", ix);
+        fprintf(stderr, "found at index %zu\n", ix);
         kMsgHandlers[ix].handler(message_data, &sb);
         break;
       }
     }
 
     len = strlen(sb.c_str());
-    fprintf(stderr, "posting reply len %" PRIuS "\n", len);
+    fprintf(stderr, "posting reply len %zu\n", len);
     fprintf(stderr, "posting reply \"%s\".\n", sb.c_str());
     fflush(stderr);
 

ppapi/native_client/nacl_test_data.gni

@@ -171,6 +171,7 @@ template("nacl_test_data") {
                            ])
     deps = [
       "//build/config/nacl:nacl_base",
+      "//ppapi/c",
       "//ppapi/native_client:ppapi_lib",
     ]
     ldflags = [ "-pthread" ]