Commit 547516aa authored by Jared Saul's avatar Jared Saul Committed by Commit Bot

[AF] Enable Chrome OS for certain save card browsertests

Tests relating to the [No thanks] button or the StrikeDatabase should
now be enableable on Chrome OS.

Change-Id: Iba760339f852b9faa7db787614fcd806782caea3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891853Reviewed-by: default avatarEvan Stade <estade@chromium.org>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#711415}
parent 5a8a58fa
...@@ -898,8 +898,6 @@ IN_PROC_BROWSER_TEST_F(SaveCardBubbleViewsFullFormBrowserTest, ...@@ -898,8 +898,6 @@ IN_PROC_BROWSER_TEST_F(SaveCardBubbleViewsFullFormBrowserTest,
EXPECT_TRUE(GetSaveCardIconView()->GetVisible()); EXPECT_TRUE(GetSaveCardIconView()->GetVisible());
} }
#if defined(OS_WIN) || defined(OS_MACOSX) || \
(defined(OS_LINUX) && !defined(OS_CHROMEOS))
// Tests the local save bubble. Ensures that clicking the [No thanks] button // Tests the local save bubble. Ensures that clicking the [No thanks] button
// successfully causes the bubble to go away. // successfully causes the bubble to go away.
IN_PROC_BROWSER_TEST_F(SaveCardBubbleViewsFullFormBrowserTest, IN_PROC_BROWSER_TEST_F(SaveCardBubbleViewsFullFormBrowserTest,
...@@ -916,7 +914,6 @@ IN_PROC_BROWSER_TEST_F(SaveCardBubbleViewsFullFormBrowserTest, ...@@ -916,7 +914,6 @@ IN_PROC_BROWSER_TEST_F(SaveCardBubbleViewsFullFormBrowserTest,
"Autofill.SaveCreditCardPrompt.Local.FirstShow", "Autofill.SaveCreditCardPrompt.Local.FirstShow",
AutofillMetrics::SAVE_CARD_PROMPT_END_DENIED, 1); AutofillMetrics::SAVE_CARD_PROMPT_END_DENIED, 1);
} }
#endif
// Tests the sign in promo bubble. Ensures that clicking the [Save] button // Tests the sign in promo bubble. Ensures that clicking the [Save] button
// on the local save bubble successfully causes the sign in promo to show. // on the local save bubble successfully causes the sign in promo to show.
...@@ -1526,8 +1523,6 @@ IN_PROC_BROWSER_TEST_F( ...@@ -1526,8 +1523,6 @@ IN_PROC_BROWSER_TEST_F(
EXPECT_FALSE(FindViewInBubbleById(DialogViewId::UPLOAD_EXPLANATION_TOOLTIP)); EXPECT_FALSE(FindViewInBubbleById(DialogViewId::UPLOAD_EXPLANATION_TOOLTIP));
} }
#if defined(OS_WIN) || defined(OS_MACOSX) || \
(defined(OS_LINUX) && !defined(OS_CHROMEOS))
// Tests the upload save bubble. Ensures that clicking the [No thanks] button // Tests the upload save bubble. Ensures that clicking the [No thanks] button
// successfully causes the bubble to go away. // successfully causes the bubble to go away.
IN_PROC_BROWSER_TEST_F( IN_PROC_BROWSER_TEST_F(
...@@ -1548,7 +1543,6 @@ IN_PROC_BROWSER_TEST_F( ...@@ -1548,7 +1543,6 @@ IN_PROC_BROWSER_TEST_F(
"Autofill.SaveCreditCardPrompt.Upload.FirstShow", "Autofill.SaveCreditCardPrompt.Upload.FirstShow",
AutofillMetrics::SAVE_CARD_PROMPT_END_DENIED, 1); AutofillMetrics::SAVE_CARD_PROMPT_END_DENIED, 1);
} }
#endif
// Tests the upload save bubble. Ensures that clicking the top-right [X] close // Tests the upload save bubble. Ensures that clicking the top-right [X] close
// button successfully causes the bubble to go away. // button successfully causes the bubble to go away.
...@@ -2430,8 +2424,6 @@ IN_PROC_BROWSER_TEST_F( ...@@ -2430,8 +2424,6 @@ IN_PROC_BROWSER_TEST_F(
/*sample=*/1, /*count=*/1); /*sample=*/1, /*count=*/1);
} }
#if defined(OS_WIN) || defined(OS_MACOSX) || \
(defined(OS_LINUX) && !defined(OS_CHROMEOS))
// Tests the local save bubble. Ensures that clicking the [No thanks] button // Tests the local save bubble. Ensures that clicking the [No thanks] button
// successfully causes a strike to be added. // successfully causes a strike to be added.
IN_PROC_BROWSER_TEST_F(SaveCardBubbleViewsFullFormBrowserTest, IN_PROC_BROWSER_TEST_F(SaveCardBubbleViewsFullFormBrowserTest,
...@@ -2448,10 +2440,7 @@ IN_PROC_BROWSER_TEST_F(SaveCardBubbleViewsFullFormBrowserTest, ...@@ -2448,10 +2440,7 @@ IN_PROC_BROWSER_TEST_F(SaveCardBubbleViewsFullFormBrowserTest,
"Autofill.StrikeDatabase.NthStrikeAdded.CreditCardSave", "Autofill.StrikeDatabase.NthStrikeAdded.CreditCardSave",
/*sample=*/(1), /*count=*/1); /*sample=*/(1), /*count=*/1);
} }
#endif
#if defined(OS_WIN) || defined(OS_MACOSX) || \
(defined(OS_LINUX) && !defined(OS_CHROMEOS))
// Tests the upload save bubble. Ensures that clicking the [No thanks] button // Tests the upload save bubble. Ensures that clicking the [No thanks] button
// successfully causes a strike to be added. // successfully causes a strike to be added.
IN_PROC_BROWSER_TEST_F( IN_PROC_BROWSER_TEST_F(
...@@ -2472,10 +2461,7 @@ IN_PROC_BROWSER_TEST_F( ...@@ -2472,10 +2461,7 @@ IN_PROC_BROWSER_TEST_F(
"Autofill.StrikeDatabase.NthStrikeAdded.CreditCardSave", "Autofill.StrikeDatabase.NthStrikeAdded.CreditCardSave",
/*sample=*/(1), /*count=*/1); /*sample=*/(1), /*count=*/1);
} }
#endif
#if defined(OS_WIN) || defined(OS_MACOSX) || \
(defined(OS_LINUX) && !defined(OS_CHROMEOS))
// Tests overall StrikeDatabase interaction with the local save bubble. Runs an // Tests overall StrikeDatabase interaction with the local save bubble. Runs an
// example of declining the prompt three times and ensuring that the // example of declining the prompt three times and ensuring that the
// offer-to-save bubble does not appear on the fourth try. Then, ensures that no // offer-to-save bubble does not appear on the fourth try. Then, ensures that no
...@@ -2545,10 +2531,7 @@ IN_PROC_BROWSER_TEST_F(SaveCardBubbleViewsFullFormBrowserTest, ...@@ -2545,10 +2531,7 @@ IN_PROC_BROWSER_TEST_F(SaveCardBubbleViewsFullFormBrowserTest,
"Autofill.SaveCreditCardPrompt.Local.FirstShow", "Autofill.SaveCreditCardPrompt.Local.FirstShow",
AutofillMetrics::SAVE_CARD_ICON_SHOWN_WITHOUT_PROMPT, 1); AutofillMetrics::SAVE_CARD_ICON_SHOWN_WITHOUT_PROMPT, 1);
} }
#endif
#if defined(OS_WIN) || defined(OS_MACOSX) || \
(defined(OS_LINUX) && !defined(OS_CHROMEOS))
// Tests overall StrikeDatabase interaction with the upload save bubble. Runs an // Tests overall StrikeDatabase interaction with the upload save bubble. Runs an
// example of declining the prompt three times and ensuring that the // example of declining the prompt three times and ensuring that the
// offer-to-save bubble does not appear on the fourth try. Then, ensures that no // offer-to-save bubble does not appear on the fourth try. Then, ensures that no
...@@ -2626,7 +2609,6 @@ IN_PROC_BROWSER_TEST_F( ...@@ -2626,7 +2609,6 @@ IN_PROC_BROWSER_TEST_F(
"Autofill.SaveCreditCardPrompt.Upload.FirstShow", "Autofill.SaveCreditCardPrompt.Upload.FirstShow",
AutofillMetrics::SAVE_CARD_ICON_SHOWN_WITHOUT_PROMPT, 1); AutofillMetrics::SAVE_CARD_ICON_SHOWN_WITHOUT_PROMPT, 1);
} }
#endif
// TODO(crbug.com/932818): Remove the condition once the experiment is enabled // TODO(crbug.com/932818): Remove the condition once the experiment is enabled
// on ChromeOS. // on ChromeOS.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment