Commit 5480a312 authored by Brandon Wylie's avatar Brandon Wylie Committed by Commit Bot

Prevent tab reparenting from reordering tabs

Non-foreground tabs were being reattached in the reverse order, but this
is unnecessary since the default add behavior adds the tabs to the end.

Bug: 1053388
Change-Id: Id768184cf3d02b679568eb3d0f72a262dacc522d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062686Reviewed-by: default avatarYusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742337}
parent 67bd04d2
...@@ -52,7 +52,7 @@ public class NightModeReparentingController implements NightModeStateProvider.Ob ...@@ -52,7 +52,7 @@ public class NightModeReparentingController implements NightModeStateProvider.Ob
// to be reparented last. // to be reparented last.
TabReparentingParams foregroundTabParams = null; TabReparentingParams foregroundTabParams = null;
SparseArray<AsyncTabParams> paramsArray = AsyncTabParamsManager.getAsyncTabParams().clone(); SparseArray<AsyncTabParams> paramsArray = AsyncTabParamsManager.getAsyncTabParams().clone();
for (int i = paramsArray.size() - 1; i >= 0; i--) { for (int i = 0; i < paramsArray.size(); i++) {
int tabId = paramsArray.keyAt(i); int tabId = paramsArray.keyAt(i);
AsyncTabParams params = paramsArray.get(tabId); AsyncTabParams params = paramsArray.get(tabId);
if (!(params instanceof TabReparentingParams)) continue; if (!(params instanceof TabReparentingParams)) continue;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment