Commit 5491583f authored by Greg Thompson's avatar Greg Thompson Committed by Commit Bot

Pass --log-file along to child processes.

mini_installer_tests captures chrome logs via --log-file=foo. While
other logging switches (e.g., --v, --enable-logging) are being properly
passed to child procs, --log-file was not. This resulted in child procs
writing to the default log file rather than the browser's log file, so
their log messages were not included in the test output upon failure.

BUG=907979

Change-Id: I83eab118d2b196a28db1af0c8abaea3b54f0a783
Reviewed-on: https://chromium-review.googlesource.com/c/1386205
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: default avatarAvi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618548}
parent 210401ca
...@@ -317,6 +317,7 @@ void BrowserChildProcessHostImpl::LaunchWithoutExtraCommandLineSwitches( ...@@ -317,6 +317,7 @@ void BrowserChildProcessHostImpl::LaunchWithoutExtraCommandLineSwitches(
switches::kDisableLogging, switches::kDisableLogging,
switches::kEnableLogging, switches::kEnableLogging,
switches::kIPCConnectionTimeout, switches::kIPCConnectionTimeout,
switches::kLogFile,
switches::kLoggingLevel, switches::kLoggingLevel,
switches::kTraceToConsole, switches::kTraceToConsole,
switches::kV, switches::kV,
......
...@@ -3044,6 +3044,7 @@ void RenderProcessHostImpl::PropagateBrowserCommandLineToRenderer( ...@@ -3044,6 +3044,7 @@ void RenderProcessHostImpl::PropagateBrowserCommandLineToRenderer(
switches::kFullMemoryCrashReport, switches::kFullMemoryCrashReport,
switches::kIPCConnectionTimeout, switches::kIPCConnectionTimeout,
switches::kJavaScriptFlags, switches::kJavaScriptFlags,
switches::kLogFile,
switches::kLoggingLevel, switches::kLoggingLevel,
switches::kMaxUntiledLayerWidth, switches::kMaxUntiledLayerWidth,
switches::kMaxUntiledLayerHeight, switches::kMaxUntiledLayerHeight,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment