Make Edit>Speech>Speak Selection work for PDFs on Mac

This makes Speak Selection from the menu work for PDFs on Mac. It also
simplifies the code slightly by creating a function which gets the "full page"
guest if there is one.

BUG=476787

Review URL: https://codereview.chromium.org/1042743002

Cr-Commit-Position: refs/heads/master@{#325584}

content/browser/browser_plugin/browser_plugin_embedder.cc

@@ -180,21 +180,12 @@ bool BrowserPluginEmbedder::HandleKeyboardEvent(
   return event_consumed;
 }
 
-bool BrowserPluginEmbedder::Find(int request_id,
-                                 const base::string16& search_text,
-                                 const blink::WebFindOptions& options) {
-  return GetBrowserPluginGuestManager()->ForEachGuest(
-      web_contents(),
-      base::Bind(&BrowserPluginEmbedder::FindInGuest,
-                 request_id,
-                 search_text,
-                 options));
-}
-
-bool BrowserPluginEmbedder::StopFinding(StopFindAction action) {
-  return GetBrowserPluginGuestManager()->ForEachGuest(
-      web_contents(),
-      base::Bind(&BrowserPluginEmbedder::StopFindingInGuest, action));
+BrowserPluginGuest* BrowserPluginEmbedder::GetFullPageGuest() {
+  WebContentsImpl* guest_contents = static_cast<WebContentsImpl*>(
+      GetBrowserPluginGuestManager()->GetFullPageGuest(web_contents()));
+  if (!guest_contents)
+    return nullptr;
+  return guest_contents->GetBrowserPluginGuest();
 }
 
 // static
@@ -209,29 +200,4 @@ bool BrowserPluginEmbedder::UnlockMouseIfNecessaryCallback(bool* mouse_unlocked,
   return false;
 }
 
-// static
-bool BrowserPluginEmbedder::FindInGuest(int request_id,
-                                        const base::string16& search_text,
-                                        const blink::WebFindOptions& options,
-                                        WebContents* guest) {
-  if (static_cast<WebContentsImpl*>(guest)->GetBrowserPluginGuest()->Find(
-          request_id, search_text, options)) {
-    // There can only ever currently be one browser plugin that handles find so
-    // we can break the iteration at this point.
-    return true;
-  }
-  return false;
-}
-
-bool BrowserPluginEmbedder::StopFindingInGuest(StopFindAction action,
-                                               WebContents* guest) {
-  if (static_cast<WebContentsImpl*>(guest)->GetBrowserPluginGuest()
-          ->StopFinding(action)) {
-    // There can only ever currently be one browser plugin that handles find so
-    // we can break the iteration at this point.
-    return true;
-  }
-  return false;
-}
-
 }  // namespace content

content/browser/browser_plugin/browser_plugin_embedder.h

@@ -67,12 +67,10 @@ class CONTENT_EXPORT BrowserPluginEmbedder : public WebContentsObserver {
   // Used to handle special keyboard events.
   bool HandleKeyboardEvent(const NativeWebKeyboardEvent& event);
 
-  // Find the given |search_text| in the page. Returns true if the find request
-  // is handled by this browser plugin embedder.
-  bool Find(int request_id,
-            const base::string16& search_text,
-            const blink::WebFindOptions& options);
-  bool StopFinding(StopFindAction action);
+  // Returns the "full page" guest if there is one. That is, if there is a
+  // single BrowserPlugin in the embedder which takes up the full page, then it
+  // is returned.
+  BrowserPluginGuest* GetFullPageGuest();
 
  private:
   explicit BrowserPluginEmbedder(WebContentsImpl* web_contents);
@@ -89,12 +87,6 @@ class CONTENT_EXPORT BrowserPluginEmbedder : public WebContentsObserver {
   static bool UnlockMouseIfNecessaryCallback(bool* mouse_unlocked,
                                              WebContents* guest);
 
-  static bool FindInGuest(int request_id,
-                          const base::string16& search_text,
-                          const blink::WebFindOptions& options,
-                          WebContents* guest);
-  static bool StopFindingInGuest(StopFindAction action, WebContents* guest);
-
   // Message handlers.
 
   void OnAttach(RenderFrameHost* render_frame_host,

content/browser/renderer_host/render_widget_host_view_mac.mm

@@ -47,6 +47,8 @@
 #include "content/common/input_messages.h"
 #include "content/common/view_messages.h"
 #include "content/common/webplugin_geometry.h"
+#include "content/public/browser/browser_context.h"
+#include "content/public/browser/browser_plugin_guest_manager.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/native_web_keyboard_event.h"
 #include "content/public/browser/notification_service.h"
@@ -107,6 +109,23 @@ BOOL EventIsReservedBySystem(NSEvent* event) {
   return helper->map()->IsEventReserved(event);
 }
 
+RenderWidgetHostViewMac* GetRenderWidgetHostViewToUse(
+    RenderWidgetHostViewMac* render_widget_host_view) {
+  WebContents* web_contents = render_widget_host_view->GetWebContents();
+  if (!web_contents)
+    return render_widget_host_view;
+  content::BrowserPluginGuestManager* guest_manager =
+      web_contents->GetBrowserContext()->GetGuestManager();
+  if (!guest_manager)
+    return render_widget_host_view;
+  content::WebContents* guest =
+      guest_manager->GetFullPageGuest(web_contents);
+  if (!guest)
+    return render_widget_host_view;
+  return static_cast<RenderWidgetHostViewMac*>(
+      guest->GetRenderWidgetHostView());
+}
+
 }  // namespace
 
 // These are not documented, so use only after checking -respondsToSelector:.
@@ -3274,11 +3293,11 @@ extern NSString *NSTextInputReplacementRangeAttributeName;
 }
 
 - (void)startSpeaking:(id)sender {
-  renderWidgetHostView_->SpeakSelection();
+  GetRenderWidgetHostViewToUse(renderWidgetHostView_.get())->SpeakSelection();
 }
 
 - (void)stopSpeaking:(id)sender {
-  renderWidgetHostView_->StopSpeaking();
+  GetRenderWidgetHostViewToUse(renderWidgetHostView_.get())->StopSpeaking();
 }
 
 - (void)cancelComposition {

content/browser/web_contents/web_contents_impl.cc

@@ -2503,18 +2503,20 @@ void WebContentsImpl::Find(int request_id,
                            const base::string16& search_text,
                            const blink::WebFindOptions& options) {
   // See if a top level browser plugin handles the find request first.
-  if (browser_plugin_embedder_ &&
-      browser_plugin_embedder_->Find(request_id, search_text, options)) {
-    return;
+  if (browser_plugin_embedder_) {
+    BrowserPluginGuest* guest = browser_plugin_embedder_->GetFullPageGuest();
+    if (guest && guest->Find(request_id, search_text, options))
+      return;
   }
   Send(new ViewMsg_Find(GetRoutingID(), request_id, search_text, options));
 }
 
 void WebContentsImpl::StopFinding(StopFindAction action) {
   // See if a top level browser plugin handles the stop finding request first.
-  if (browser_plugin_embedder_ &&
-      browser_plugin_embedder_->StopFinding(action)) {
-    return;
+  if (browser_plugin_embedder_) {
+    BrowserPluginGuest* guest = browser_plugin_embedder_->GetFullPageGuest();
+    if (guest && guest->StopFinding(action))
+      return;
   }
   Send(new ViewMsg_StopFinding(GetRoutingID(), action));
 }

content/public/browser/browser_plugin_guest_manager.cc

@@ -18,5 +18,10 @@ bool BrowserPluginGuestManager::ForEachGuest(
   return false;
 }
 
+WebContents* BrowserPluginGuestManager::GetFullPageGuest(
+    WebContents* embedder_web_contents) {
+  return nullptr;
+}
+
 }  // content
 

content/public/browser/browser_plugin_guest_manager.h

@@ -29,6 +29,11 @@ class CONTENT_EXPORT BrowserPluginGuestManager {
   typedef base::Callback<bool(WebContents*)> GuestCallback;
   virtual bool ForEachGuest(WebContents* embedder_web_contents,
                             const GuestCallback& callback);
+
+  // Returns the "full page" guest if there is one. That is, if there is a
+  // single BrowserPlugin in the given embedder which takes up the full page,
+  // then it is returned.
+  virtual WebContents* GetFullPageGuest(WebContents* embedder_web_contents);
 };
 
 }  // namespace content

extensions/browser/guest_view/guest_view_manager.cc

@@ -188,6 +188,14 @@ bool GuestViewManager::ForEachGuest(WebContents* owner_web_contents,
   return false;
 }
 
+WebContents* GuestViewManager::GetFullPageGuest(
+    WebContents* embedder_web_contents) {
+  WebContents* result = nullptr;
+  ForEachGuest(embedder_web_contents,
+               base::Bind(&GuestViewManager::GetFullPageGuestHelper, &result));
+  return result;
+}
+
 void GuestViewManager::AddGuest(int guest_instance_id,
                                 WebContents* guest_web_contents) {
   CHECK(!ContainsKey(guest_web_contents_by_instance_id_, guest_instance_id));
@@ -285,6 +293,18 @@ bool GuestViewManager::CanUseGuestInstanceID(int guest_instance_id) {
   return !ContainsKey(removed_instance_ids_, guest_instance_id);
 }
 
+// static
+bool GuestViewManager::GetFullPageGuestHelper(
+    content::WebContents** result,
+    content::WebContents* guest_web_contents) {
+  auto guest_view = GuestViewBase::FromWebContents(guest_web_contents);
+  if (guest_view && guest_view->is_full_page_plugin()) {
+    *result = guest_web_contents;
+    return true;
+  }
+  return false;
+}
+
 bool GuestViewManager::CanEmbedderAccessInstanceID(
     int embedder_render_process_id,
     int guest_instance_id) {

extensions/browser/guest_view/guest_view_manager.h

@@ -92,6 +92,8 @@ class GuestViewManager : public content::BrowserPluginGuestManager,
       int element_instance_id) override;
   bool ForEachGuest(content::WebContents* owner_web_contents,
                     const GuestCallback& callback) override;
+  content::WebContents* GetFullPageGuest(
+      content::WebContents* embedder_web_contents) override;
 
  protected:
   friend class GuestViewBase;
@@ -124,6 +126,9 @@ class GuestViewManager : public content::BrowserPluginGuestManager,
   // from this manager using RemoveGuest.
   bool CanUseGuestInstanceID(int guest_instance_id);
 
+  static bool GetFullPageGuestHelper(content::WebContents** result,
+                                     content::WebContents* guest_web_contents);
+
   // Static factory instance (always NULL for non-test).
   static GuestViewManagerFactory* factory_;