Add 'Add Payment Method' button to the Settings menu.

Add flag for add new payment method feature.

The button will navigate the user to a screen where the user can input credit card details, either manually or by using the camera. This callback function has not yet been implemented and will be implemented in a follow up CL.

Bug: 983987
Change-Id: I53b612cd03618eb787ec03fe56ca6e4e197c7a6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699806
Commit-Queue: Tanisha Mandre <tanishamandre@google.com>
Reviewed-by: Eric Noyau <noyau@chromium.org>
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#678227}

ios/chrome/app/strings/ios_strings.grd

@@ -891,6 +891,9 @@ locale.  The strings in this file are specific to iOS.
       <message name="IDS_IOS_MANAGED_SWITCH_TITLE" desc="The title of the Switch from a managed account dialog. [40em]">
         Sign out of managed account
       </message>
+      <message name="IDS_IOS_MANUAL_FALLBACK_ADD_PAYMENT_METHOD" desc="The title for the button in the manual fallback UI that takes the user to the add new credit card screen through settings. In this screen, the user can input their card details and save them.">
+        Add Payment Method...
+      </message>
       <message name="IDS_IOS_MANUAL_FALLBACK_MANAGE_PASSWORDS" desc="The title for the button in the manual fallback UI that takes the user to the passwords settings. In this screen they see all the passwords and can erase them. Note it is different from IDS_IOS_MANUAL_FALLBACK_USE_OTHER_PASSWORD_WITH_DOTS [30em]">
         Manage Passwords...
       </message>

ios/chrome/browser/flags/BUILD.gn

@@ -50,6 +50,7 @@ source_set("flags") {
     "//ios/chrome/browser/ui/dialogs:feature_flags",
     "//ios/chrome/browser/ui/fullscreen:feature_flags",
     "//ios/chrome/browser/ui/infobars:feature_flags",
+    "//ios/chrome/browser/ui/settings/autofill:feature_flags",
     "//ios/chrome/browser/ui/toolbar/public:feature_flags",
     "//ios/chrome/browser/ui/toolbar_container:feature_flags",
     "//ios/chrome/browser/web:feature_flags",

ios/chrome/browser/flags/about_flags.mm

@@ -61,6 +61,7 @@
 #import "ios/chrome/browser/ui/dialogs/dialog_features.h"
 #import "ios/chrome/browser/ui/fullscreen/fullscreen_features.h"
 #import "ios/chrome/browser/ui/infobars/infobar_feature.h"
+#include "ios/chrome/browser/ui/settings/autofill/features.h"
 #import "ios/chrome/browser/ui/toolbar/public/features.h"
 #import "ios/chrome/browser/ui/toolbar_container/toolbar_container_features.h"
 #include "ios/chrome/browser/ui/ui_feature_flags.h"
@@ -577,6 +578,10 @@ const flags_ui::FeatureEntry kFeatureEntries[] = {
      flag_descriptions::kEnableAutofillSaveCardShowNoThanksDescription,
      flags_ui::kOsIos,
      FEATURE_VALUE_TYPE(autofill::features::kAutofillSaveCardShowNoThanks)},
+    {"settings-add-payment-method",
+     flag_descriptions::kSettingsAddPaymentMethodName,
+     flag_descriptions::kSettingsAddPaymentMethodDescription, flags_ui::kOsIos,
+     FEATURE_VALUE_TYPE(kSettingsAddPaymentMethod)},
 };
 
 // Add all switches from experimental flags to |command_line|.

ios/chrome/browser/flags/ios_chrome_flag_descriptions.cc

@@ -371,6 +371,12 @@ const char kSendUmaOverAnyNetwork[] =
 const char kSendUmaOverAnyNetworkDescription[] =
     "When enabled, will send UMA data over either WiFi or cellular by default.";
 
+const char kSettingsAddPaymentMethodName[] =
+    "Enable the add payment method button";
+const char kSettingsAddPaymentMethodDescription[] =
+    "Allow a user to add a new credit card to payment methods from the "
+    "settings menu.";
+
 const char kSettingsRefreshName[] = "Enable the UI Refresh for Settings";
 const char kSettingsRefreshDescription[] =
     "Change the UI appearance of the settings to have something in phase with "

ios/chrome/browser/flags/ios_chrome_flag_descriptions.h

@@ -313,6 +313,10 @@ extern const char kSendTabToSelfShowSendingUIDescription[];
 extern const char kSendUmaOverAnyNetwork[];
 extern const char kSendUmaOverAnyNetworkDescription[];
 
+// Title and description for the flag to add a new credit card.
+extern const char kSettingsAddPaymentMethodName[];
+extern const char kSettingsAddPaymentMethodDescription[];
+
 // Title and description for the flag to toggle the flag for the settings UI
 // Refresh.
 extern const char kSettingsRefreshName[];

ios/chrome/browser/ui/settings/autofill/BUILD.gn

@@ -18,6 +18,7 @@ source_set("autofill") {
     "autofill_profile_table_view_controller.mm",
   ]
   deps = [
+    ":feature_flags",
     "//components/autofill/core/browser",
     "//components/autofill/core/common",
     "//components/autofill/ios/browser",
@@ -38,10 +39,22 @@ source_set("autofill") {
     "//ios/chrome/browser/ui/table_view",
     "//ios/chrome/browser/ui/table_view/cells",
     "//ios/chrome/browser/ui/util",
+    "//ios/chrome/common/colors",
     "//ui/base",
   ]
 }
 
+source_set("feature_flags") {
+  configs += [ "//build/config/compiler:enable_arc" ]
+  sources = [
+    "features.h",
+    "features.mm",
+  ]
+  deps = [
+    "//base",
+  ]
+}
+
 source_set("unit_tests") {
   configs += [ "//build/config/compiler:enable_arc" ]
   testonly = true

ios/chrome/browser/ui/settings/autofill/autofill_credit_card_table_view_controller.mm

@@ -19,6 +19,7 @@
 #include "ios/chrome/browser/browser_state/chrome_browser_state.h"
 #import "ios/chrome/browser/ui/settings/autofill/autofill_credit_card_edit_table_view_controller.h"
 #import "ios/chrome/browser/ui/settings/autofill/cells/autofill_data_item.h"
+#import "ios/chrome/browser/ui/settings/autofill/features.h"
 #import "ios/chrome/browser/ui/settings/cells/settings_switch_cell.h"
 #import "ios/chrome/browser/ui/settings/cells/settings_switch_item.h"
 #include "ios/chrome/browser/ui/table_view/cells/table_view_cells_constants.h"
@@ -26,6 +27,7 @@
 #import "ios/chrome/browser/ui/table_view/cells/table_view_text_header_footer_item.h"
 #include "ios/chrome/browser/ui/ui_feature_flags.h"
 #import "ios/chrome/browser/ui/util/uikit_ui_util.h"
+#import "ios/chrome/common/colors/semantic_color_names.h"
 #include "ios/chrome/grit/ios_strings.h"
 #include "ui/base/l10n/l10n_util.h"
 
@@ -72,10 +74,15 @@ typedef NS_ENUM(NSInteger, ItemType) {
 // stop the observer callback from acting on user-initiated changes.
 @property(nonatomic, readwrite, assign) BOOL deletionInProgress;
 
+// Button to add a new credit card.
+@property(nonatomic, strong) UIBarButtonItem* addPaymentMethodButton;
+
 @end
 
 @implementation AutofillCreditCardTableViewController
 
+#pragma mark - ViewController Life Cycle.
+
 - (instancetype)initWithBrowserState:(ios::ChromeBrowserState*)browserState {
   DCHECK(browserState);
   UITableViewStyle style = base::FeatureList::IsEnabled(kSettingsRefresh)
@@ -101,12 +108,28 @@ typedef NS_ENUM(NSInteger, ItemType) {
 
 #pragma mark - UIViewController
 
+- (NSArray<UIBarButtonItem*>*)toolbarItems {
+  if (base::FeatureList::IsEnabled(kSettingsAddPaymentMethod)) {
+    UIBarButtonItem* flexibleSpace = [[UIBarButtonItem alloc]
+        initWithBarButtonSystemItem:UIBarButtonSystemItemFlexibleSpace
+                             target:nil
+                             action:nil];
+    return @[
+      self.deleteButton,
+      flexibleSpace,
+      self.addPaymentMethodButton,
+    ];
+  }
+  return [super toolbarItems];
+}
+
 - (void)viewDidLoad {
   [super viewDidLoad];
   self.tableView.allowsMultipleSelectionDuringEditing = YES;
   self.tableView.accessibilityIdentifier = kAutofillCreditCardTableViewId;
 
   base::RecordAction(base::UserMetricsAction("AutofillCreditCardsViewed"));
+  [self.deleteButton setEnabled:NO];
   [self updateUIForEditState];
   [self loadModel];
 }
@@ -116,10 +139,25 @@ typedef NS_ENUM(NSInteger, ItemType) {
   if (editing) {
     [self setSwitchItemEnabled:NO itemType:ItemTypeAutofillCardSwitch];
   } else {
+    [self.deleteButton setEnabled:NO];
     [self setSwitchItemEnabled:YES itemType:ItemTypeAutofillCardSwitch];
   }
 }
 
+- (void)viewWillAppear:(BOOL)animated {
+  [super viewWillAppear:animated];
+  if (base::FeatureList::IsEnabled(kSettingsAddPaymentMethod)) {
+    self.navigationController.toolbarHidden = NO;
+  }
+}
+
+- (BOOL)shouldHideToolbar {
+  if (base::FeatureList::IsEnabled(kSettingsAddPaymentMethod)) {
+    return NO;
+  }
+  return [super shouldHideToolbar];
+}
+
 #pragma mark - ChromeTableViewController
 
 - (void)loadModel {
@@ -289,6 +327,7 @@ typedef NS_ENUM(NSInteger, ItemType) {
   // edit mode, selection is handled by the superclass. When not in edit mode
   // selection presents the editing controller for the selected entry.
   if (self.editing) {
+    [self.deleteButton setEnabled:YES];
     return;
   }
 
@@ -308,6 +347,16 @@ typedef NS_ENUM(NSInteger, ItemType) {
   [self.navigationController pushViewController:controller animated:YES];
 }
 
+- (void)tableView:(UITableView*)tableView
+    didDeselectRowAtIndexPath:(NSIndexPath*)indexPath {
+  [super tableView:tableView didDeselectRowAtIndexPath:indexPath];
+  if (!self.tableView.editing)
+    return;
+
+  if (self.tableView.indexPathsForSelectedRows.count == 0)
+    [self.deleteButton setEnabled:NO];
+}
+
 #pragma mark - UITableViewDataSource
 
 - (BOOL)tableView:(UITableView*)tableView
@@ -409,4 +458,16 @@ typedef NS_ENUM(NSInteger, ItemType) {
       _browserState->GetPrefs(), isEnabled);
 }
 
+- (UIBarButtonItem*)addPaymentMethodButton {
+  if (!_addPaymentMethodButton) {
+    _addPaymentMethodButton = [[UIBarButtonItem alloc]
+        initWithTitle:l10n_util::GetNSString(
+                          IDS_IOS_MANUAL_FALLBACK_ADD_PAYMENT_METHOD)
+                style:UIBarButtonItemStylePlain
+               target:self
+               action:nil];
+  }
+  return _addPaymentMethodButton;
+}
+
 @end

ios/chrome/browser/ui/settings/autofill/features.h

+// Copyright 2019 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef IOS_CHROME_BROWSER_UI_SETTINGS_AUTOFILL_FEATURES_H_
+#define IOS_CHROME_BROWSER_UI_SETTINGS_AUTOFILL_FEATURES_H_
+
+#import <Foundation/Foundation.h>
+
+#include "base/feature_list.h"
+
+// Add new credit card feature.
+extern const base::Feature kSettingsAddPaymentMethod;
+
+#endif  // IOS_CHROME_BROWSER_UI_SETTINGS_AUTOFILL_FEATURES_H_

ios/chrome/browser/ui/settings/autofill/features.mm

+// Copyright 2019 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#import "ios/chrome/browser/ui/settings/autofill/features.h"
+
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
+const base::Feature kSettingsAddPaymentMethod{
+    "SettingsAddPaymentMethod", base::FEATURE_DISABLED_BY_DEFAULT};

ios/chrome/browser/ui/settings/settings_root_table_view_controller.h

@@ -21,6 +21,9 @@ extern NSString* const kSettingsToolbarDeleteButtonId;
     : ChromeTableViewController <SettingsRootViewControlling,
                                  TableViewLinkHeaderFooterItemDelegate>
 
+// Delete button for the toolbar.
+@property(nonatomic, strong, readonly) UIBarButtonItem* deleteButton;
+
 // Whether this table view controller should hide the "Done" button (the right
 // navigation bar button). Default is NO.
 @property(nonatomic, assign) BOOL shouldHideDoneButton;
@@ -42,6 +45,9 @@ extern NSString* const kSettingsToolbarDeleteButtonId;
 // following methods to customize the behavior.
 @interface SettingsRootTableViewController (Subclassing)
 
+// Returns YES. Subclasses should overload this if a toolbar is required.
+- (BOOL)shouldHideToolbar;
+
 // Returns NO.  Subclasses should overload this if an edit button is required.
 - (BOOL)shouldShowEditButton;
 

ios/chrome/browser/ui/settings/settings_root_table_view_controller.mm

@@ -73,7 +73,8 @@ NSString* const kSettingsToolbarDeleteButtonId =
     return;
   }
 
-  [self.navigationController setToolbarHidden:YES animated:YES];
+  [self.navigationController setToolbarHidden:self.shouldHideToolbar
+                                     animated:YES];
   if (self.shouldShowEditButton) {
     self.navigationItem.rightBarButtonItem = [self createEditButton];
   } else {
@@ -151,7 +152,8 @@ NSString* const kSettingsToolbarDeleteButtonId =
 - (void)setEditing:(BOOL)editing animated:(BOOL)animated {
   [super setEditing:editing animated:animated];
   if (!editing)
-    [self.navigationController setToolbarHidden:YES animated:YES];
+    [self.navigationController setToolbarHidden:self.shouldHideToolbar
+                                       animated:YES];
 }
 
 - (void)viewDidLayoutSubviews {
@@ -181,7 +183,8 @@ NSString* const kSettingsToolbarDeleteButtonId =
     return;
 
   if (self.tableView.indexPathsForSelectedRows.count == 0)
-    [self.navigationController setToolbarHidden:YES animated:YES];
+    [self.navigationController setToolbarHidden:self.shouldHideToolbar
+                                       animated:YES];
 }
 
 - (CGFloat)tableView:(UITableView*)tableView
@@ -247,6 +250,10 @@ NSString* const kSettingsToolbarDeleteButtonId =
 
 #pragma mark - Subclassing
 
+- (BOOL)shouldHideToolbar {
+  return YES;
+}
+
 - (BOOL)shouldShowEditButton {
   return NO;
 }