Commit 549bcac9 authored by Justin DeWitt's avatar Justin DeWitt Committed by Commit Bot

[EoS] Add a fieldtrial config before launching to beta/stable.

Bug: 904986, 906151
Change-Id: I5aef21b730446234742c2420435aeba8fb81f76e
Reviewed-on: https://chromium-review.googlesource.com/c/1334274
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: default avatarTheresa <twellington@chromium.org>
Reviewed-by: default avatarIlya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609016}
parent bc3f8f6f
...@@ -102,10 +102,13 @@ import java.util.concurrent.TimeUnit; ...@@ -102,10 +102,13 @@ import java.util.concurrent.TimeUnit;
/** /**
* Tests for the native android New Tab Page. * Tests for the native android New Tab Page.
*
* TODO(https://crbug.com/906151): Add new goldens and enable ExploreSites.
*/ */
@RunWith(ParameterizedRunner.class) @RunWith(ParameterizedRunner.class)
@ParameterAnnotations.UseRunnerDelegate(ChromeJUnit4RunnerDelegate.class) @ParameterAnnotations.UseRunnerDelegate(ChromeJUnit4RunnerDelegate.class)
@CommandLineFlags.Add(ChromeSwitches.DISABLE_FIRST_RUN_EXPERIENCE) @CommandLineFlags.Add(ChromeSwitches.DISABLE_FIRST_RUN_EXPERIENCE)
@Features.DisableFeatures(ChromeFeatureList.EXPLORE_SITES)
@RetryOnFailure @RetryOnFailure
public class NewTabPageTest { public class NewTabPageTest {
@Rule @Rule
......
...@@ -35,6 +35,7 @@ import org.chromium.base.test.util.Feature; ...@@ -35,6 +35,7 @@ import org.chromium.base.test.util.Feature;
import org.chromium.base.test.util.RetryOnFailure; import org.chromium.base.test.util.RetryOnFailure;
import org.chromium.chrome.R; import org.chromium.chrome.R;
import org.chromium.chrome.browser.ChromeActivity; import org.chromium.chrome.browser.ChromeActivity;
import org.chromium.chrome.browser.ChromeFeatureList;
import org.chromium.chrome.browser.ChromeSwitches; import org.chromium.chrome.browser.ChromeSwitches;
import org.chromium.chrome.browser.UrlConstants; import org.chromium.chrome.browser.UrlConstants;
import org.chromium.chrome.browser.modelutil.ListObservable; import org.chromium.chrome.browser.modelutil.ListObservable;
...@@ -49,6 +50,7 @@ import org.chromium.chrome.test.ChromeJUnit4ClassRunner; ...@@ -49,6 +50,7 @@ import org.chromium.chrome.test.ChromeJUnit4ClassRunner;
import org.chromium.chrome.test.ChromeTabbedActivityTestRule; import org.chromium.chrome.test.ChromeTabbedActivityTestRule;
import org.chromium.chrome.test.util.NewTabPageTestUtils; import org.chromium.chrome.test.util.NewTabPageTestUtils;
import org.chromium.chrome.test.util.RenderTestRule; import org.chromium.chrome.test.util.RenderTestRule;
import org.chromium.chrome.test.util.browser.Features.DisableFeatures;
import org.chromium.chrome.test.util.browser.offlinepages.FakeOfflinePageBridge; import org.chromium.chrome.test.util.browser.offlinepages.FakeOfflinePageBridge;
import org.chromium.chrome.test.util.browser.suggestions.FakeMostVisitedSites; import org.chromium.chrome.test.util.browser.suggestions.FakeMostVisitedSites;
import org.chromium.chrome.test.util.browser.suggestions.FakeSuggestionsSource; import org.chromium.chrome.test.util.browser.suggestions.FakeSuggestionsSource;
...@@ -101,6 +103,8 @@ public class TileGridLayoutTest { ...@@ -101,6 +103,8 @@ public class TileGridLayoutTest {
@Test @Test
@MediumTest @MediumTest
@Feature({"NewTabPage", "RenderTest"}) @Feature({"NewTabPage", "RenderTest"})
// TODO(https://crbug.com/906151): Add new goldens and enable ExploreSites.
@DisableFeatures(ChromeFeatureList.EXPLORE_SITES)
public void testTileGridAppearance() throws Exception { public void testTileGridAppearance() throws Exception {
NewTabPage ntp = setUpFakeDataToShowOnNtp(FAKE_MOST_VISITED_URLS.length); NewTabPage ntp = setUpFakeDataToShowOnNtp(FAKE_MOST_VISITED_URLS.length);
mRenderTestRule.render(getTileGridLayout(ntp), "ntp_tile_grid_layout"); mRenderTestRule.render(getTileGridLayout(ntp), "ntp_tile_grid_layout");
...@@ -145,6 +149,8 @@ public class TileGridLayoutTest { ...@@ -145,6 +149,8 @@ public class TileGridLayoutTest {
@Test @Test
@MediumTest @MediumTest
@Feature({"NewTabPage", "RenderTest"}) @Feature({"NewTabPage", "RenderTest"})
// TODO(https://crbug.com/906151): Add new goldens and enable ExploreSites.
@DisableFeatures(ChromeFeatureList.EXPLORE_SITES)
public void testTileAppearanceModern() public void testTileAppearanceModern()
throws IOException, InterruptedException, TimeoutException { throws IOException, InterruptedException, TimeoutException {
List<SiteSuggestion> suggestions = makeSuggestions(2); List<SiteSuggestion> suggestions = makeSuggestions(2);
......
...@@ -1922,6 +1922,21 @@ ...@@ -1922,6 +1922,21 @@
] ]
} }
], ],
"ExploreSites InitialCountries": [
{
"platforms": [
"android"
],
"experiments": [
{
"name": "Enabled",
"enable_features": [
"ExploreSites"
]
}
]
}
],
"ExtendedShellExtensionsEnumeration": [ "ExtendedShellExtensionsEnumeration": [
{ {
"platforms": [ "platforms": [
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment