Commit 54ba8573 authored by Brandon Wylie's avatar Brandon Wylie Committed by Commit Bot

Fix the omnibox text overlapping with the icon when searching from NTP

The text is animating over the status icon because there's no check to
prevent it from happening. Adding that explicit check here fixes the
problem.

Bug: 1011403
Change-Id: I2d46b3a12eeced9108c8b0e5b2382f48e6523dc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845936Reviewed-by: default avatarTheresa  <twellington@chromium.org>
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704041}
parent 349d0b41
...@@ -166,8 +166,9 @@ public class LocationBarPhone extends LocationBarLayout { ...@@ -166,8 +166,9 @@ public class LocationBarPhone extends LocationBarLayout {
* (mStatusView.getEndPaddingPixelSizeForState(true) * (mStatusView.getEndPaddingPixelSizeForState(true)
- mStatusView.getEndPaddingPixelSizeForState(false)); - mStatusView.getEndPaddingPixelSizeForState(false));
if (!hasFocus && mToolbarDataProvider.getNewTabPageForCurrentTab() != null if (!hasFocus && mIconView.getVisibility() == VISIBLE
&& mIconView.getVisibility() == VISIBLE) { && mToolbarDataProvider.getNewTabPageForCurrentTab() != null
&& !mToolbarDataProvider.getTab().isLoading()) {
// When: // When:
// 1. unfocusing the LocationBar on the NTP. // 1. unfocusing the LocationBar on the NTP.
// 2. scrolling the fakebox to the LocationBar on the NTP. // 2. scrolling the fakebox to the LocationBar on the NTP.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment