Commit 54cfcfc3 authored by David Bertoni's avatar David Bertoni Committed by Commit Bot

[Extensions] Re-enable some AppViewTest tests.

These tests were disabled for flakiness, but they exhibited no
flakes in 3000 iterations on the bots.

Bug: 658050, 660366, 875908
Change-Id: Id07368376216fdbe01a9b43351f5ec94925eccc5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503311Reviewed-by: default avatarKelvin Jiang <kelvinjiang@chromium.org>
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826167}
parent 68d2ccb6
...@@ -150,14 +150,8 @@ class AppViewTest : public AppShellTest { ...@@ -150,14 +150,8 @@ class AppViewTest : public AppShellTest {
TestGuestViewManagerFactory factory_; TestGuestViewManagerFactory factory_;
}; };
#if defined(OS_WIN)
#define MAYBE_TestAppViewGoodDataShouldSucceed \
DISABLED_TestAppViewGoodDataShouldSucceed
#else
#define MAYBE_TestAppViewGoodDataShouldSucceed TestAppViewGoodDataShouldSucceed
#endif
// Tests that <appview> correctly processes parameters passed on connect. // Tests that <appview> correctly processes parameters passed on connect.
IN_PROC_BROWSER_TEST_F(AppViewTest, MAYBE_TestAppViewGoodDataShouldSucceed) { IN_PROC_BROWSER_TEST_F(AppViewTest, TestAppViewGoodDataShouldSucceed) {
RunTest("testAppViewGoodDataShouldSucceed", RunTest("testAppViewGoodDataShouldSucceed",
"app_view/apitest", "app_view/apitest",
"app_view/apitest/skeleton"); "app_view/apitest/skeleton");
...@@ -179,23 +173,14 @@ IN_PROC_BROWSER_TEST_F(AppViewTest, TestAppViewMediaRequest) { ...@@ -179,23 +173,14 @@ IN_PROC_BROWSER_TEST_F(AppViewTest, TestAppViewMediaRequest) {
// Tests that <appview> correctly processes parameters passed on connect. // Tests that <appview> correctly processes parameters passed on connect.
// This test should fail to connect because the embedded app (skeleton) will // This test should fail to connect because the embedded app (skeleton) will
// refuse the data passed by the embedder app and deny the request. // refuse the data passed by the embedder app and deny the request.
// Disabled for flakiness on multiple platforms. See https://crbug.com/875908. IN_PROC_BROWSER_TEST_F(AppViewTest, TestAppViewRefusedDataShouldFail) {
IN_PROC_BROWSER_TEST_F(AppViewTest, DISABLED_TestAppViewRefusedDataShouldFail) {
RunTest("testAppViewRefusedDataShouldFail", RunTest("testAppViewRefusedDataShouldFail",
"app_view/apitest", "app_view/apitest",
"app_view/apitest/skeleton"); "app_view/apitest/skeleton");
} }
#if defined(OS_WIN) || defined(OS_CHROMEOS)
#define MAYBE_TestAppViewWithUndefinedDataShouldSucceed \
DISABLED_TestAppViewWithUndefinedDataShouldSucceed
#else
#define MAYBE_TestAppViewWithUndefinedDataShouldSucceed \
TestAppViewWithUndefinedDataShouldSucceed
#endif
// Tests that <appview> is able to navigate to another installed app. // Tests that <appview> is able to navigate to another installed app.
IN_PROC_BROWSER_TEST_F(AppViewTest, IN_PROC_BROWSER_TEST_F(AppViewTest, TestAppViewWithUndefinedDataShouldSucceed) {
MAYBE_TestAppViewWithUndefinedDataShouldSucceed) {
RunTest("testAppViewWithUndefinedDataShouldSucceed", RunTest("testAppViewWithUndefinedDataShouldSucceed",
"app_view/apitest", "app_view/apitest",
"app_view/apitest/skeleton"); "app_view/apitest/skeleton");
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment