Move SVGResources::SupportsMarkers to layout_svg_path.cc

LayoutSVGPath is now the only user of this function. Currently the set
of elements that should have markers applied equals the set of elements
that create/use LayoutSVGPath, so just DCHECK() this in the constructor
(as future-proofing) and drop the actual check.

Change-Id: Icb3b8aab1dd1b569e16bb14dfade43232d442ca0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595378Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#837983}

third_party/blink/renderer/core/layout/svg/layout_svg_path.cc

@@ -33,9 +33,22 @@
 
 namespace blink {
 
+namespace {
+
+bool SupportsMarkers(const SVGGeometryElement& element) {
+  return element.HasTagName(svg_names::kLineTag) ||
+         element.HasTagName(svg_names::kPathTag) ||
+         element.HasTagName(svg_names::kPolygonTag) ||
+         element.HasTagName(svg_names::kPolylineTag);
+}
+
+}  // namespace
+
 LayoutSVGPath::LayoutSVGPath(SVGGeometryElement* node)
     // <line> elements have no joins and thus needn't care about miters.
-    : LayoutSVGShape(node, IsA<SVGLineElement>(node) ? kNoMiters : kComplex) {}
+    : LayoutSVGShape(node, IsA<SVGLineElement>(node) ? kNoMiters : kComplex) {
+  DCHECK(SupportsMarkers(*node));
+}
 
 LayoutSVGPath::~LayoutSVGPath() = default;
 
@@ -70,8 +83,7 @@ void LayoutSVGPath::UpdateMarkers() {
   marker_positions_.clear();
 
   const SVGComputedStyle& svg_style = StyleRef().SvgStyle();
-  if (!svg_style.HasMarkers() ||
-      !SVGResources::SupportsMarkers(*To<SVGGraphicsElement>(GetElement())))
+  if (!svg_style.HasMarkers())
     return;
   SVGElementResourceClient* client = SVGResources::GetClient(*this);
   if (!client)

third_party/blink/renderer/core/layout/svg/svg_resources.cc

@@ -30,7 +30,6 @@
 #include "third_party/blink/renderer/core/svg/graphics/filters/svg_filter_builder.h"
 #include "third_party/blink/renderer/core/svg/svg_filter_primitive_standard_attributes.h"
 #include "third_party/blink/renderer/core/svg/svg_resource.h"
-#include "third_party/blink/renderer/core/svg_names.h"
 #include "third_party/blink/renderer/platform/graphics/filters/filter.h"
 #include "third_party/blink/renderer/platform/graphics/filters/filter_effect.h"
 #include "third_party/blink/renderer/platform/graphics/filters/paint_filter_builder.h"
@@ -63,17 +62,6 @@ FloatRect SVGResources::ReferenceBoxForEffects(
   return obb_layout_object->ObjectBoundingBox();
 }
 
-bool SVGResources::SupportsMarkers(const SVGElement& element) {
-  DEFINE_STATIC_LOCAL(HashSet<AtomicString>, tag_list,
-                      ({
-                          svg_names::kLineTag.LocalName(),
-                          svg_names::kPathTag.LocalName(),
-                          svg_names::kPolygonTag.LocalName(),
-                          svg_names::kPolylineTag.LocalName(),
-                      }));
-  return tag_list.Contains(element.localName());
-}
-
 void SVGResources::UpdateClipPathFilterMask(SVGElement& element,
                                             const ComputedStyle* old_style,
                                             const ComputedStyle& style) {

third_party/blink/renderer/core/layout/svg/svg_resources.h

@@ -54,8 +54,6 @@ class SVGResources {
                             const ComputedStyle* old_style,
                             const ComputedStyle&);
   static void ClearMarkers(SVGElement&, const ComputedStyle*);
-
-  static bool SupportsMarkers(const SVGElement&);
 };
 
 class SVGElementResourceClient final