Commit 54fc48d4 authored by Ioana Pandele's avatar Ioana Pandele Committed by Commit Bot

Change the title of the Save Passwords Settings page to Passwords

Since the Settings > Save Passwords view will contain a button for password export as well,
it should be renamed to the more general "Passwords".

Bug:789122

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I2ea88a88a7bfa989384cb302681bc37649d5aa72
Reviewed-on: https://chromium-review.googlesource.com/911798Reviewed-by: default avatarSylvain Defresne <sdefresne@chromium.org>
Reviewed-by: default avatarMenglu Huang <huangml@chromium.org>
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539932}
parent 0a4dae2a
...@@ -1096,9 +1096,12 @@ Handoff must also be enabled in the General section of Settings, and your device ...@@ -1096,9 +1096,12 @@ Handoff must also be enabled in the General section of Settings, and your device
<message name="IDS_IOS_SAVE_IMAGE_RESTRICTED_PRIVACY_ALERT_MESSAGE" desc="Message to inform user that Save Image failed due to insufficient privilege in Privacy Settings and that the user cannot grant such privilege. This message is displayed as the message body in an alert box with a single OK button. [Length: 120em]"> <message name="IDS_IOS_SAVE_IMAGE_RESTRICTED_PRIVACY_ALERT_MESSAGE" desc="Message to inform user that Save Image failed due to insufficient privilege in Privacy Settings and that the user cannot grant such privilege. This message is displayed as the message body in an alert box with a single OK button. [Length: 120em]">
A device policy blocked access to your photos A device policy blocked access to your photos
</message> </message>
<message name="IDS_IOS_SAVE_PASSWORDS" desc="Title for the view in Settings for managing saved passwords. [Length: 15em] [iOS only]"> <message name="IDS_IOS_SAVE_PASSWORDS" desc="Title for the switch item in Settings that can be toggled to enable or disable saving passwords. [Length: 15em] [iOS only]">
Save Passwords Save Passwords
</message> </message>
<message name="IDS_IOS_PASSWORDS" desc="Title for the view in Settings for managing saved passwords. [Length: 15em] [iOS only]">
Passwords
</message>
<message name="IDS_IOS_EXPORT_PASSWORDS" desc="Button that the user can press to export passwords. [Length: 22em] [iOS only]"> <message name="IDS_IOS_EXPORT_PASSWORDS" desc="Button that the user can press to export passwords. [Length: 22em] [iOS only]">
Export Passwords... Export Passwords...
</message> </message>
......
...@@ -205,7 +205,7 @@ void SavePasswordsConsumer::OnGetPasswordStoreResults( ...@@ -205,7 +205,7 @@ void SavePasswordsConsumer::OnGetPasswordStoreResults(
initWithReauthenticationModule:reauthenticationModule_ initWithReauthenticationModule:reauthenticationModule_
delegate:self]; delegate:self];
} }
self.title = l10n_util::GetNSString(IDS_IOS_SAVE_PASSWORDS); self.title = l10n_util::GetNSString(IDS_IOS_PASSWORDS);
self.collectionViewAccessibilityIdentifier = self.collectionViewAccessibilityIdentifier =
@"SavePasswordsCollectionViewController"; @"SavePasswordsCollectionViewController";
self.shouldHideDoneButton = YES; self.shouldHideDoneButton = YES;
......
...@@ -495,7 +495,7 @@ void SigninObserverBridge::GoogleSignedOut(const std::string& account_id, ...@@ -495,7 +495,7 @@ void SigninObserverBridge::GoogleSignedOut(const std::string& account_id,
_savePasswordsDetailItem = _savePasswordsDetailItem =
[self detailItemWithType:ItemTypeSavedPasswords [self detailItemWithType:ItemTypeSavedPasswords
text:l10n_util::GetNSString(IDS_IOS_SAVE_PASSWORDS) text:l10n_util::GetNSString(IDS_IOS_PASSWORDS)
detailText:passwordsDetail]; detailText:passwordsDetail];
return _savePasswordsDetailItem; return _savePasswordsDetailItem;
......
...@@ -295,7 +295,7 @@ id<GREYMatcher> SettingsMenuPrivacyButton() { ...@@ -295,7 +295,7 @@ id<GREYMatcher> SettingsMenuPrivacyButton() {
} }
id<GREYMatcher> SettingsMenuPasswordsButton() { id<GREYMatcher> SettingsMenuPasswordsButton() {
return ButtonWithAccessibilityLabelId(IDS_IOS_SAVE_PASSWORDS); return ButtonWithAccessibilityLabelId(IDS_IOS_PASSWORDS);
} }
id<GREYMatcher> PaymentRequestView() { id<GREYMatcher> PaymentRequestView() {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment