Change the title of the Save Passwords Settings page to Passwords

Since the Settings > Save Passwords view will contain a button for password export as well,
it should be renamed to the more general "Passwords".

Bug:789122

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I2ea88a88a7bfa989384cb302681bc37649d5aa72
Reviewed-on: https://chromium-review.googlesource.com/911798Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Menglu Huang <huangml@chromium.org>
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539932}

ios/chrome/app/strings/ios_strings.grd

@@ -1096,9 +1096,12 @@ Handoff must also be enabled in the General section of Settings, and your device
       <message name="IDS_IOS_SAVE_IMAGE_RESTRICTED_PRIVACY_ALERT_MESSAGE" desc="Message to inform user that Save Image failed due to insufficient privilege in Privacy Settings and that the user cannot grant such privilege. This message is displayed as the message body in an alert box with a single OK button. [Length: 120em]">
         A device policy blocked access to your photos
       </message>
-      <message name="IDS_IOS_SAVE_PASSWORDS" desc="Title for the view in Settings for managing saved passwords. [Length: 15em] [iOS only]">
+      <message name="IDS_IOS_SAVE_PASSWORDS" desc="Title for the switch item in Settings that can be toggled to enable or disable saving passwords. [Length: 15em] [iOS only]">
         Save Passwords
       </message>
+      <message name="IDS_IOS_PASSWORDS" desc="Title for the view in Settings for managing saved passwords. [Length: 15em] [iOS only]">
+        Passwords
+      </message>
       <message name="IDS_IOS_EXPORT_PASSWORDS" desc="Button that the user can press to export passwords. [Length: 22em] [iOS only]">
         Export Passwords...
       </message>

ios/chrome/browser/ui/settings/save_passwords_collection_view_controller.mm

@@ -205,7 +205,7 @@ void SavePasswordsConsumer::OnGetPasswordStoreResults(
           initWithReauthenticationModule:reauthenticationModule_
                                 delegate:self];
     }
-    self.title = l10n_util::GetNSString(IDS_IOS_SAVE_PASSWORDS);
+    self.title = l10n_util::GetNSString(IDS_IOS_PASSWORDS);
     self.collectionViewAccessibilityIdentifier =
         @"SavePasswordsCollectionViewController";
     self.shouldHideDoneButton = YES;

ios/chrome/browser/ui/settings/settings_collection_view_controller.mm

@@ -495,7 +495,7 @@ void SigninObserverBridge::GoogleSignedOut(const std::string& account_id,
 
   _savePasswordsDetailItem =
       [self detailItemWithType:ItemTypeSavedPasswords
-                          text:l10n_util::GetNSString(IDS_IOS_SAVE_PASSWORDS)
+                          text:l10n_util::GetNSString(IDS_IOS_PASSWORDS)
                     detailText:passwordsDetail];
 
   return _savePasswordsDetailItem;

ios/chrome/test/earl_grey/chrome_matchers.mm

@@ -295,7 +295,7 @@ id<GREYMatcher> SettingsMenuPrivacyButton() {
 }
 
 id<GREYMatcher> SettingsMenuPasswordsButton() {
-  return ButtonWithAccessibilityLabelId(IDS_IOS_SAVE_PASSWORDS);
+  return ButtonWithAccessibilityLabelId(IDS_IOS_PASSWORDS);
 }
 
 id<GREYMatcher> PaymentRequestView() {