Add missing dependencies to several domains
This ports https://github.com/ChromeDevTools/debugger-protocol-viewer/pull/115 to Chromium. Note that the DOM domain depends on Page (as getNodeForLocation has a reference to Page), but if you would add this to the .pdl there would be a circular dependency between Page and DOM. Thus, the generated code does not compile if you add this dependency. This probably requires follow-up work to either remove the circular dependency or update the code generator to handle a circular dependency. Change-Id: I11b444c4af5498c83ca8471e507f93f5dd6485e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148744 Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#760534}
Showing
Please register or sign in to comment