Commit 550a724f authored by Tim van der Lippe's avatar Tim van der Lippe Committed by Commit Bot

Add missing dependencies to several domains

This ports
https://github.com/ChromeDevTools/debugger-protocol-viewer/pull/115 to
Chromium.

Note that the DOM domain depends on Page (as getNodeForLocation has a
reference to Page), but if you would add this to the .pdl there would be
a circular dependency between Page and DOM. Thus, the generated code
does not compile if you add this dependency. This probably requires
follow-up work to either remove the circular dependency or update the
code generator to handle a circular dependency.

Change-Id: I11b444c4af5498c83ca8471e507f93f5dd6485e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148744
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: default avatarDmitry Gozman <dgozman@chromium.org>
Reviewed-by: default avatarAndrey Kosyakov <caseq@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760534}
parent 5d95f6c7
......@@ -366,6 +366,7 @@ experimental domain Animation
Animation animation
experimental domain ApplicationCache
depends on Page
# Detailed application cache resource information.
type ApplicationCacheResource extends object
......@@ -864,6 +865,7 @@ domain Browser
# subsequently load the required stylesheet contents using the `getStyleSheet[Text]()` methods.
experimental domain CSS
depends on DOM
depends on Page
type StyleSheetId extends string
......@@ -6439,6 +6441,8 @@ domain Security
optional string summary
experimental domain ServiceWorker
depends on Target
type RegistrationID extends string
# ServiceWorker registration.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment