Commit 550c901a authored by Ali Juma's avatar Ali Juma Committed by Commit Bot

[iOS] Disable flaky UKM EG test

testIncognitoPlusRegular fails flakily depending on
the order in which it is run relative to other test
cases. It also fails when it is the first test run
after app launch, which means that if it fails once
in a given run, it won't even pass on retry.

Here's an example run where this happens on a change
that is a no-op other than adding a new empty test:
https://chromium-swarm.appspot.com/task?id=4c998d1e469f0110

This CL disables this flaky test.

BUG=1033726

Change-Id: I77949094e448c26a5db176f4b18c60a783aefc8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231447
Commit-Queue: Ali Juma <ajuma@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Auto-Submit: Ali Juma <ajuma@chromium.org>
Reviewed-by: default avatarRohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775286}
parent 593f72ca
...@@ -226,13 +226,8 @@ using chrome_test_util::TurnSyncSwitchOn; ...@@ -226,13 +226,8 @@ using chrome_test_util::TurnSyncSwitchOn;
// //
// Corresponds to IncognitoPlusRegularCheck in //chrome/browser/metrics/ // Corresponds to IncognitoPlusRegularCheck in //chrome/browser/metrics/
// ukm_browsertest.cc. // ukm_browsertest.cc.
#if defined(CHROME_EARL_GREY_1) // TODO(crbug.com/1033726): This test is flaky on iOS 12 and 13.
// TODO(crbug.com/1033726): EG1 Test fails on iOS 12. - (void)DISABLED_testIncognitoPlusRegular {
#define MAYBE_testIncognitoPlusRegular DISABLED_testIncognitoPlusRegular
#else
#define MAYBE_testIncognitoPlusRegular testIncognitoPlusRegular
#endif
- (void)MAYBE_testIncognitoPlusRegular {
const uint64_t originalClientID = [MetricsAppInterface UKMClientID]; const uint64_t originalClientID = [MetricsAppInterface UKMClientID];
[ChromeEarlGrey closeAllTabs]; [ChromeEarlGrey closeAllTabs];
[ChromeEarlGrey waitForMainTabCount:0]; [ChromeEarlGrey waitForMainTabCount:0];
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment