Rename https_invalid.icon to be more general

Renames https_invalid.icon since the triangle icon will be used
for HTTP pages as well as part of crbug.com/997972.

Bug: 1008218
Change-Id: I031ab884361c5085f7ef0f7b93935e235540005a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846567Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Livvie Lin <livvielin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705185}

chrome/browser/ui/autofill/autofill_popup_layout_model.cc

@@ -223,7 +223,7 @@ gfx::ImageSkia AutofillPopupLayoutModel::GetIconImage(size_t index) const {
                                  gfx::kChromeIconGrey);
   }
   if (icon_str == "httpsInvalid") {
-    return gfx::CreateVectorIcon(omnibox::kHttpsInvalidIcon, kIconSize,
+    return gfx::CreateVectorIcon(omnibox::kNotSecureWarningIcon, kIconSize,
                                  gfx::kGoogleRed700);
   }
   if (icon_str == "keyIcon") {

chrome/browser/vr/testapp/vr_test_context.cc

@@ -720,8 +720,8 @@ void VrTestContext::CycleOrigin() {
        security_state::SecurityLevel::SECURE, &omnibox::kHttpsValidIcon, true,
        false},
       {GURL("https://www.domain.com/path/segment/directory/file.html"),
-       security_state::SecurityLevel::DANGEROUS, &omnibox::kHttpsInvalidIcon,
-       true, false},
+       security_state::SecurityLevel::DANGEROUS,
+       &omnibox::kNotSecureWarningIcon, true, false},
       // Do not show URL
       {GURL(), security_state::SecurityLevel::WARNING, &omnibox::kHttpIcon,
        false, false},

components/omnibox/browser/BUILD.gn

@@ -46,10 +46,10 @@ aggregate_vector_icons("omnibox_vector_icons") {
     "extension_app.icon",
     "find_in_page.icon",
     "http.icon",
-    "https_invalid.icon",
     "https_valid.icon",
     "https_valid_in_chip.icon",
     "keyword_search.icon",
+    "not_secure_warning.icon",
     "offline_pin.icon",
     "page.icon",
     "pedal.icon",

components/omnibox/browser/location_bar_model_impl.cc

@@ -195,7 +195,7 @@ const gfx::VectorIcon& LocationBarModelImpl::GetVectorIcon() const {
     case security_state::SECURE_WITH_POLICY_INSTALLED_CERT:
       return vector_icons::kBusinessIcon;
     case security_state::DANGEROUS:
-      return omnibox::kHttpsInvalidIcon;
+      return omnibox::kNotSecureWarningIcon;
     case security_state::SECURITY_LEVEL_COUNT:
       NOTREACHED();
       return omnibox::kHttpIcon;