Commit 5523ed05 authored by Caleb Raitto's avatar Caleb Raitto Committed by Commit Bot

Disable leaking storage_unittests on LSAN.

See crrev.com/c/1590404 and the linked bug for context -- the goal is to
fix the broken memory-leak checking in Chromium's ASAN
(AddressSanitizer) trybots, which are supposed to also run LSAN
(LeakSanitizer).

Currently-leaking tests must be fixed or disabled before leak checking
can be enabled in the ASAN trybot.

WARNING: This will result in a loss of ASAN coverage for the affected
tests given that LSAN runs as part of the ASAN trybot.

If that's not acceptable, we can wait until the leaks are fixed before
fixing leak detection in trybots, but keep in mind that newly-introduced
leaks Chromium-wide won't be caught until then.

Bug: 961068
Change-Id: Idf3c932175ebf7d17187648fd508e471f06c40ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640781Reviewed-by: default avatarMarijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Caleb Raitto <caraitto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666322}
parent ea72d5d9
......@@ -49,6 +49,13 @@
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/leveldatabase/leveldb_chrome.h"
// TODO(crbug.com/961068): Fix memory leaks in tests and re-enable on LSAN.
#ifdef LEAK_SANITIZER
#define MAYBE_TestQuotaOnTruncation DISABLED_TestQuotaOnTruncation
#else
#define MAYBE_TestQuotaOnTruncation TestQuotaOnTruncation
#endif
using content::AsyncFileTestHelper;
using storage::FileSystemContext;
using storage::FileSystemOperation;
......@@ -978,7 +985,7 @@ TEST_P(ObfuscatedFileUtilTest, TestTruncate) {
EXPECT_TRUE(change_observer()->HasNoChange());
}
TEST_P(ObfuscatedFileUtilTest, TestQuotaOnTruncation) {
TEST_P(ObfuscatedFileUtilTest, MAYBE_TestQuotaOnTruncation) {
bool created = false;
FileSystemURL url = CreateURLFromUTF8("file");
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment