Skip to content

GitLab

T
tangled
Commit 5553b9f8 authored by elawrence's avatar elawrence Committed by Commit bot
Browse files
Options

DevTools: Convert Security Panel to Sentence case 

Replace use of Title Case in the Developer Tools' Security Panel to use sentence case, matching Chrome text standards.

BUG=721176

Review-Url: https://codereview.chromium.org/2881513003
Cr-Commit-Position: refs/heads/master@{#473435}
parent 507bbc4d
Hide whitespace changes
Inline Side-by-side
Showing with 93 additions and 86 deletions
components/security_state/content/content_utils.cc
View file @ 5553b9f8
......@@ -306,8 +306,9 @@ blink::WebSecurityStyle GetSecurityStyle(
if (security_info.pkp_bypassed) {
security_style_explanations->info_explanations.push_back(
content::SecurityStyleExplanation(
"Public-Key Pinning Bypassed",
"Public-key pinning was bypassed by a local root certificate."));
l10n_util::GetStringUTF8(IDS_PRIVATE_KEY_PINNING_BYPASSED),
l10n_util::GetStringUTF8(
IDS_PRIVATE_KEY_PINNING_BYPASSED_DESCRIPTION)));
}
return security_style;
......
components/security_state/content/content_utils_unittest.cc
View file @ 5553b9f8
......@@ -181,7 +181,7 @@ TEST(SecurityStateContentUtilsTest, ConnectionExplanation) {
GetSecurityStyle(security_info, &explanations);
content::SecurityStyleExplanation explanation;
ASSERT_TRUE(FindSecurityStyleExplanation(
explanations.secure_explanations, "Secure Connection", &explanation));
explanations.secure_explanations, "Secure connection", &explanation));
EXPECT_EQ(
"The connection to this site is encrypted and authenticated using a "
"strong protocol (TLS 1.2), a strong key exchange (ECDHE_RSA with "
......@@ -197,7 +197,7 @@ TEST(SecurityStateContentUtilsTest, ConnectionExplanation) {
GetSecurityStyle(security_info, &explanations);
content::SecurityStyleExplanation explanation;
ASSERT_TRUE(FindSecurityStyleExplanation(
explanations.secure_explanations, "Secure Connection", &explanation));
explanations.secure_explanations, "Secure connection", &explanation));
EXPECT_EQ(
"The connection to this site is encrypted and authenticated using a "
"strong protocol (TLS 1.2), a strong key exchange (ECDHE_RSA), and a "
......@@ -216,7 +216,7 @@ TEST(SecurityStateContentUtilsTest, ConnectionExplanation) {
GetSecurityStyle(security_info, &explanations);
content::SecurityStyleExplanation explanation;
ASSERT_TRUE(FindSecurityStyleExplanation(
explanations.secure_explanations, "Secure Connection", &explanation));
explanations.secure_explanations, "Secure connection", &explanation));
EXPECT_EQ(
"The connection to this site is encrypted and authenticated using a "
"strong protocol (TLS 1.3), a strong key exchange (X25519), and a "
......
components/security_state_strings.grdp
View file @ 5553b9f8
......@@ -2,7 +2,7 @@
<grit-part>
<!-- Strings describing Chrome security policy for DevTools security panel -->
<message name="IDS_PRIVATE_USER_DATA_INPUT" desc="Summary phrase for a security problem where the site collects private user data on an insecure page." translateable="false">
Private User Data Input
Private user data input
</message>
<message name="IDS_PRIVATE_USER_DATA_INPUT_DESCRIPTION" desc="Description of a security problem where the site collects private user data on an insecure page, which results in an omnibox warning." translateable="false">
This page includes a password or credit card input over HTTP. A warning has been added to the URL bar.
......@@ -11,37 +11,43 @@
This page is dangerous (flagged by Google Safe Browsing).
</message>
<message name="IDS_SHA1" desc="Summary phrase for a security problem where the site's certificate chain contains a SHA1 signature." translateable="false">
SHA-1 Certificate
SHA-1 certificate
</message>
<message name="IDS_SHA1_DESCRIPTION" desc="Description of a security problem where the site's certificate chain contains a SHA1 signature." translateable="false">
The certificate chain for this site contains a certificate signed using SHA-1.
</message>
<message name="IDS_SUBJECT_ALT_NAME_MISSING" desc="Summary phrase for a security problem where the site's certificate is missing a subjectAltName extension." translateable="false">
Subject Alternative Name Missing
Subject Alternative Name missing
</message>
<message name="IDS_SUBJECT_ALT_NAME_MISSING_DESCRIPTION" desc="Description of a security problem where the site's certificate is missing a subjectAltName extension." translateable="false">
The certificate for this site does not contain a Subject Alternative Name extension containing a domain name or IP address.
</message>
<message name="IDS_CERTIFICATE_CHAIN_ERROR" desc="Summary phrase for a security problem with the site's certificate." translateable="false">
Certificate Error
Certificate error
</message>
<message name="IDS_CERTIFICATE_CHAIN_ERROR_DESCRIPTION_FORMAT" desc="Description of a security problem with the site's certificate." translateable="false">
There are issues with the site's certificate chain (<ph name="CERT_ERROR_DESCRIPTION">$1<ex>net::ERR_CERT_AUTHORITY_INVALID</ex></ph>).
</message>
<message name="IDS_VALID_SERVER_CERTIFICATE" desc="Summary phrase for a site that has a valid server certificate." translateable="false">
Valid Certificate
Valid certificate
</message>
<message name="IDS_VALID_SERVER_CERTIFICATE_DESCRIPTION" desc="Description of a site that has a valid server certificate." translateable="false">
The connection to this site is using a valid, trusted server certificate.
</message>
<message name="IDS_STRONG_SSL_SUMMARY" desc="Summary phrase for a site that uses a modern, secure TLS protocol and cipher." translateable="false">
Secure Connection
Secure connection
</message>
<message name="IDS_PRIVATE_KEY_PINNING_BYPASSED" desc="Summary phrase for a security state where Private Key Pinning is ignored because the certificate chains to a locally-trusted root." translateable="false">
Public-Key-Pinning bypassed
</message>
<message name="IDS_PRIVATE_KEY_PINNING_BYPASSED_DESCRIPTION" desc="Description of a security state where Private Key Pinning is ignored because the certificate chains to a locally-trusted root." translateable="false">
Public-Key-Pinning was bypassed by a local root certificate.
</message>
<message name="IDS_STRONG_SSL_DESCRIPTION" desc="Description of a site that uses a modern, secure TLS protocol and cipher." translateable="false">
The connection to this site is encrypted and authenticated using a strong protocol (<ph name="PROTOCOL_VERSION">$1<ex>TLS 1.2</ex></ph>), a strong key exchange (<ph name="KEY_EXCHANGE">$2<ex>ECDHE_RSA</ex></ph>), and a strong cipher (<ph name="CIPHER_SUTE">$3<ex>AES_128_GCM</ex></ph>).
</message>
<message name="IDS_OBSOLETE_SSL_SUMMARY" desc="Summary phrase for a site that uses an outdated SSL settings (protocol, key exchange, or cipher)." translateable="false">
Obsolete Connection Settings
Obsolete connection settings
</message>
<message name="IDS_OBSOLETE_SSL_DESCRIPTION" desc="Description of a site that uses an outdated TLS protocol or cipher." translateable="false">
The connection to this site uses <ph name="A_PROTOCOL">$1<ex>an obsolete protocol</ex></ph> (<ph name="PROTOCOL">$2<ex>TLS 1.0</ex></ph>), <ph name="A_KEY_EXCHANGE">$3<ex>an obsolete key exchange</ex></ph> (<ph name="KEY_EXCHANGE">$4<ex>ECDHE_RSA</ex></ph>), and <ph name="A_CIPHER">$5<ex>an obsolete cipher</ex></ph> (<ph name="CIPHER">$6<ex>AES_256_CBC with HMAC-SHA1</ex></ph>).
......
third_party/WebKit/LayoutTests/http/tests/inspector/security/blank-origins-not-shown-expected.txt
View file @ 5553b9f8
Tests that blank origins aren't shown in the security panel origins list.
Group: Main Origin
Group: Unknown / Canceled
Group: Main origin
Group: Unknown / canceled
<SPAN class=title >
https://foo.test
</SPAN>
......
third_party/WebKit/LayoutTests/http/tests/inspector/security/failed-request-expected.txt
View file @ 5553b9f8
Tests that origins with failed requests are shown correctly in the security panel origins list.
Group: Main Origin
Group: Secure Origins
Group: Main origin
Group: Secure origins
<SPAN class=title >
https://foo.test
</SPAN>
Group: Unknown / Canceled
Group: Unknown / canceled
<SPAN class=title >
https://does-not-resolve.test
</SPAN>
......
third_party/WebKit/LayoutTests/http/tests/inspector/security/interstitial-sidebar-expected.txt
View file @ 5553b9f8
......@@ -28,7 +28,7 @@ Overview
<DIV class=selection fill >
</DIV>
<SPAN class=tree-element-title >
Main Origin
Main origin
</SPAN>
</LI>
<OL class=children expanded role=group >
......@@ -46,7 +46,7 @@ Reload to view details
<DIV class=selection fill >
</DIV>
<SPAN class=tree-element-title >
Non-Secure Origins
Non-secure origins
</SPAN>
</LI>
<OL class=children expanded hidden role=group >
......@@ -55,7 +55,7 @@ Non-Secure Origins
<DIV class=selection fill >
</DIV>
<SPAN class=tree-element-title >
Secure Origins
Secure origins
</SPAN>
</LI>
<OL class=children expanded role=group >
......@@ -90,7 +90,7 @@ https://bar.test
<DIV class=selection fill >
</DIV>
<SPAN class=tree-element-title >
Unknown / Canceled
Unknown / canceled
</SPAN>
</LI>
<OL class=children expanded hidden role=group >
......@@ -131,7 +131,7 @@ Overview
<DIV class=selection fill >
</DIV>
<SPAN class=tree-element-title >
Main Origin
Main origin
</SPAN>
</LI>
<OL class=children expanded hidden role=group >
......@@ -149,7 +149,7 @@ Reload to view details
<DIV class=selection fill >
</DIV>
<SPAN class=tree-element-title >
Non-Secure Origins
Non-secure origins
</SPAN>
</LI>
<OL class=children expanded hidden role=group >
......@@ -158,7 +158,7 @@ Non-Secure Origins
<DIV class=selection fill >
</DIV>
<SPAN class=tree-element-title >
Secure Origins
Secure origins
</SPAN>
</LI>
<OL class=children expanded hidden role=group >
......@@ -193,7 +193,7 @@ https://bar.test
<DIV class=selection fill >
</DIV>
<SPAN class=tree-element-title >
Unknown / Canceled
Unknown / canceled
</SPAN>
</LI>
<OL class=children expanded hidden role=group >
......@@ -234,7 +234,7 @@ Overview
<DIV class=selection fill >
</DIV>
<SPAN class=tree-element-title >
Main Origin
Main origin
</SPAN>
</LI>
<OL class=children expanded role=group >
......@@ -252,7 +252,7 @@ Reload to view details
<DIV class=selection fill >
</DIV>
<SPAN class=tree-element-title >
Non-Secure Origins
Non-secure origins
</SPAN>
</LI>
<OL class=children expanded role=group >
......@@ -261,7 +261,7 @@ Non-Secure Origins
<DIV class=selection fill >
</DIV>
<SPAN class=tree-element-title >
Secure Origins
Secure origins
</SPAN>
</LI>
<OL class=children expanded role=group >
......@@ -296,7 +296,7 @@ https://bar.test
<DIV class=selection fill >
</DIV>
<SPAN class=tree-element-title >
Unknown / Canceled
Unknown / canceled
</SPAN>
</LI>
<OL class=children expanded role=group >
......
third_party/WebKit/LayoutTests/http/tests/inspector/security/main-origin-assigned-despite-request-missing-expected.txt
View file @ 5553b9f8
......@@ -2,11 +2,11 @@ Tests that the Main Origin is assigned even if there is no matching Request.
Page origin: http://127.0.0.1:8000
Detected main origin: http://127.0.0.1:8000
Group: Main Origin
Group: Main origin
<SPAN class=title >
http://127.0.0.1:8000
</SPAN>
Group: Unknown / Canceled
Group: Unknown / canceled
<SPAN class=title >
https://foo.test
</SPAN>
......
third_party/WebKit/LayoutTests/http/tests/inspector/security/mixed-content-active-and-passive-reload-expected.txt
View file @ 5553b9f8
......@@ -5,7 +5,7 @@ Tests that the active and pasive mixed content explanations prompt the user to r
</DIV>
<DIV class=security-explanation-text >
<DIV class=security-explanation-title >
Active Mixed Content
Active mixed content
</DIV>
<DIV >
You have recently allowed non-secure content (such as scripts or iframes) to run on this site.
......@@ -20,7 +20,7 @@ Reload the page to record requests for HTTP resources.
</DIV>
<DIV class=security-explanation-text >
<DIV class=security-explanation-title >
Mixed Content
Mixed content
</DIV>
<DIV >
The site includes HTTP resources.
......@@ -35,7 +35,7 @@ Reload the page to record requests for HTTP resources.
</DIV>
<DIV class=security-explanation-text >
<DIV class=security-explanation-title >
Active Mixed Content
Active mixed content
</DIV>
<DIV >
You have recently allowed non-secure content (such as scripts or iframes) to run on this site.
......@@ -50,7 +50,7 @@ View 1 request in Network Panel
</DIV>
<DIV class=security-explanation-text >
<DIV class=security-explanation-title >
Mixed Content
Mixed content
</DIV>
<DIV >
The site includes HTTP resources.
......
third_party/WebKit/LayoutTests/http/tests/inspector/security/mixed-content-and-subresources-with-cert-errors-expected.txt
View file @ 5553b9f8
......@@ -5,7 +5,7 @@ Tests addition of explanation when there was both mixed content and subresources
</DIV>
<DIV class=security-explanation-text >
<DIV class=security-explanation-title >
Active Mixed Content
Active mixed content
</DIV>
<DIV >
You have recently allowed non-secure content (such as scripts or iframes) to run on this site.
......@@ -20,7 +20,7 @@ Reload the page to record requests for HTTP resources.
</DIV>
<DIV class=security-explanation-text >
<DIV class=security-explanation-title >
Mixed Content
Mixed content
</DIV>
<DIV >
The site includes HTTP resources.
......
third_party/WebKit/LayoutTests/http/tests/inspector/security/mixed-content-reload-expected.txt
View file @ 5553b9f8
......@@ -5,7 +5,7 @@ Tests that the mixed content explanation prompts the user to refresh when there
</DIV>
<DIV class=security-explanation-text >
<DIV class=security-explanation-title >
Mixed Content
Mixed content
</DIV>
<DIV >
The site includes HTTP resources.
......@@ -20,7 +20,7 @@ Reload the page to record requests for HTTP resources.
</DIV>
<DIV class=security-explanation-text >
<DIV class=security-explanation-title >
Mixed Content
Mixed content
</DIV>
<DIV >
The site includes HTTP resources.
......
third_party/WebKit/LayoutTests/http/tests/inspector/security/mixed-form-expected.txt
View file @ 5553b9f8
......@@ -7,7 +7,7 @@ Security Explanations (Mixed Form Only) --------------
</DIV>
<DIV class=security-explanation-text >
<DIV class=security-explanation-title >
Non-secure Form
Non-secure form
</DIV>
<DIV >
The page includes a form with a non-secure "action" attribute.
......@@ -19,7 +19,7 @@ The page includes a form with a non-secure "action" attribute.
</DIV>
<DIV class=security-explanation-text >
<DIV class=security-explanation-title >
Secure Resources
Secure resources
</DIV>
<DIV >
All resources on this page are served securely.
......@@ -33,7 +33,7 @@ Security Explanations (Mixed Form + Mixed Passive) --------------
</DIV>
<DIV class=security-explanation-text >
<DIV class=security-explanation-title >
Non-secure Form
Non-secure form
</DIV>
<DIV >
The page includes a form with a non-secure "action" attribute.
......@@ -45,7 +45,7 @@ The page includes a form with a non-secure "action" attribute.
</DIV>
<DIV class=security-explanation-text >
<DIV class=security-explanation-title >
Mixed Content
Mixed content
</DIV>
<DIV >
The site includes HTTP resources.
......
third_party/WebKit/LayoutTests/http/tests/inspector/security/origin-view-then-interstitial-expected.txt
View file @ 5553b9f8
......@@ -4,7 +4,7 @@ Before selecting origin view:
<DIV class=widget vbox security-main-view >
<DIV class=security-summary >
<DIV class=security-summary-section-title >
Security Overview
Security overview
</DIV>
<DIV class=lock-spectrum >
<DIV class=lock-icon lock-icon-secure >
......@@ -48,7 +48,7 @@ View requests in Network Panel
</DIV>
<DIV class=origin-view-section >
<DIV class=origin-view-section-title >
Not Secure
Not secure
</DIV>
<DIV >
Your connection to this origin is not secure.
......@@ -59,7 +59,7 @@ After interstitial is shown:
<DIV class=widget vbox security-main-view >
<DIV class=security-summary >
<DIV class=security-summary-section-title >
Security Overview
Security overview
</DIV>
<DIV class=lock-spectrum >
<DIV class=lock-icon lock-icon-secure >
......
third_party/WebKit/LayoutTests/http/tests/inspector/security/security-all-resources-secure-expected.txt
View file @ 5553b9f8
......@@ -5,7 +5,7 @@ Tests addition of explanation when all page resources are transferred securely (
</DIV>
<DIV class=security-explanation-text >
<DIV class=security-explanation-title >
Secure Resources
Secure resources
</DIV>
<DIV >
All resources on this page are served securely.
......
third_party/WebKit/LayoutTests/http/tests/inspector/security/security-blocked-mixed-content-and-malicious-expected.txt
View file @ 5553b9f8
......@@ -8,7 +8,7 @@ Test: Summary Override Text
</DIV>
<DIV class=security-explanation-text >
<DIV class=security-explanation-title >
Secure Resources
Secure resources
</DIV>
<DIV >
All resources on this page are served securely.
......
third_party/WebKit/LayoutTests/http/tests/inspector/security/security-blocked-mixed-content-expected.txt
View file @ 5553b9f8
......@@ -5,7 +5,7 @@ Tests active mixed content blocking in the security panel.
</DIV>
<DIV class=security-explanation-text >
<DIV class=security-explanation-title >
Secure Resources
Secure resources
</DIV>
<DIV >
All resources on this page are served securely.
......@@ -32,7 +32,7 @@ View 1 request in Network Panel
</DIV>
<DIV class=security-explanation-text >
<DIV class=security-explanation-title >
Secure Resources
Secure resources
</DIV>
<DIV >
All resources on this page are served securely.
......
third_party/WebKit/LayoutTests/http/tests/inspector/security/security-details-updated-with-security-state-expected.txt
View file @ 5553b9f8
Tests that the security details for an origin are updated if its security state changes.
Sidebar Origins --------------------------------
Group: Main Origin
Group: Secure Origins
Group: Main origin
Group: Secure origins
<SPAN class=title >
https://foo.test
</SPAN>
Group: Unknown / Canceled
Group: Unknown / canceled
<SPAN class=title >
https://bar.test
</SPAN>
......@@ -43,7 +43,7 @@ TLS 1.2
</DIV>
<DIV class=details-table-row >
<DIV >
Key Exchange
Key exchange
</DIV>
<DIV >
Key_Exchange
......@@ -89,7 +89,7 @@ foo.test
</DIV>
<DIV class=details-table-row >
<DIV >
Valid From
Valid from
</DIV>
<DIV >
Mon, 20 Mar 2017 08:53:20 GMT
......@@ -97,7 +97,7 @@ Mon, 20 Mar 2017 08:53:20 GMT
</DIV>
<DIV class=details-table-row >
<DIV >
Valid Until
Valid until
</DIV>
<DIV >
Wed, 18 May 2033 03:33:20 GMT
......
third_party/WebKit/LayoutTests/http/tests/inspector/security/security-explanation-ordering-expected.txt
View file @ 5553b9f8
......@@ -42,7 +42,7 @@ The connection to this site uses a strong protocol (TLS 1.2), a strong key excha
</DIV>
<DIV class=security-explanation-text >
<DIV class=security-explanation-title >
Secure Resources
Secure resources
</DIV>
<DIV >
All resources on this page are served securely.
......
third_party/WebKit/LayoutTests/http/tests/inspector/security/security-secure-but-malicious-expected.txt
View file @ 5553b9f8
......@@ -8,7 +8,7 @@ Test: Summary Override Text
</DIV>
<DIV class=security-explanation-text >
<DIV class=security-explanation-title >
Secure Resources
Secure resources
</DIV>
<DIV >
All resources on this page are served securely.
......
third_party/WebKit/LayoutTests/http/tests/inspector/security/security-unknown-resource-expected.txt
View file @ 5553b9f8
Tests that requests to unresolved origins result in unknown security state and show up in the sidebar origin list.
Group: Main Origin
Group: Unknown / Canceled
Group: Main origin
Group: Unknown / canceled
<SPAN class=title >
http://unknown
</SPAN>
......
third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js
View file @ 5553b9f8
......@@ -498,10 +498,10 @@ Security.SecurityPanelSidebarTree = class extends UI.TreeOutlineInShadow {
* @enum {string}
*/
Security.SecurityPanelSidebarTree.OriginGroupName = {
MainOrigin: Common.UIString('Main Origin'),
NonSecure: Common.UIString('Non-Secure Origins'),
Secure: Common.UIString('Secure Origins'),
Unknown: Common.UIString('Unknown / Canceled')
MainOrigin: Common.UIString('Main origin'),
NonSecure: Common.UIString('Non-secure origins'),
Secure: Common.UIString('Secure origins'),
Unknown: Common.UIString('Unknown / canceled')
};
/**
......@@ -589,12 +589,12 @@ Security.SecurityMainView = class extends UI.VBox {
// Fill the security summary section.
this._summarySection.createChild('div', 'security-summary-section-title').textContent =
Common.UIString('Security Overview');
Common.UIString('Security overview');
var lockSpectrum = this._summarySection.createChild('div', 'lock-spectrum');
lockSpectrum.createChild('div', 'lock-icon lock-icon-secure').title = Common.UIString('Secure');
lockSpectrum.createChild('div', 'lock-icon lock-icon-neutral').title = Common.UIString('Not Secure');
lockSpectrum.createChild('div', 'lock-icon lock-icon-insecure').title = Common.UIString('Not Secure (Broken)');
lockSpectrum.createChild('div', 'lock-icon lock-icon-neutral').title = Common.UIString('Not secure');
lockSpectrum.createChild('div', 'lock-icon lock-icon-insecure').title = Common.UIString('Not secure (broken)');
this._summarySection.createChild('div', 'triangle-pointer-container')
.createChild('div', 'triangle-pointer-wrapper')
......@@ -680,7 +680,7 @@ Security.SecurityMainView = class extends UI.VBox {
!this._insecureContentStatus.ranContentWithCertErrors)) {
this._addExplanation(this._securityExplanationsMain, /** @type {!Protocol.Security.SecurityStateExplanation} */ ({
'securityState': Protocol.Security.SecurityState.Secure,
'summary': Common.UIString('Secure Resources'),
'summary': Common.UIString('Secure resources'),
'description': Common.UIString('All resources on this page are served securely.')
}));
}
......@@ -696,7 +696,7 @@ Security.SecurityMainView = class extends UI.VBox {
if (this._insecureContentStatus.ranMixedContent) {
this._addMixedContentExplanation(
this._securityExplanationsMain, this._insecureContentStatus.ranInsecureContentStyle,
Common.UIString('Active Mixed Content'),
Common.UIString('Active mixed content'),
Common.UIString(
'You have recently allowed non-secure content (such as scripts or iframes) to run on this site.'),
Network.NetworkLogView.MixedContentFilterValues.BlockOverridden,
......@@ -706,13 +706,13 @@ Security.SecurityMainView = class extends UI.VBox {
this._addMixedFormExplanation(
// TODO(elawrence): Replace |displayedInsecureContentStyle| with |containedMixedFormStyle|. https://crbug.com/705003
this._securityExplanationsMain, this._insecureContentStatus.displayedInsecureContentStyle,
Common.UIString('Non-secure Form'),
Common.UIString('Non-secure form'),
Common.UIString('The page includes a form with a non-secure "action" attribute.'));
}
if (this._insecureContentStatus.displayedMixedContent) {
this._addMixedContentExplanation(
this._securityExplanationsMain, this._insecureContentStatus.displayedInsecureContentStyle,
Common.UIString('Mixed Content'), Common.UIString('The site includes HTTP resources.'),
Common.UIString('Mixed content'), Common.UIString('The site includes HTTP resources.'),
Network.NetworkLogView.MixedContentFilterValues.Displayed, showDisplayedMixedContentInNetworkPanel);
}
}
......@@ -877,13 +877,13 @@ Security.SecurityOriginView = class extends UI.VBox {
var table = new Security.SecurityDetailsTable();
connectionSection.appendChild(table.element());
table.addRow('Protocol', originState.securityDetails.protocol);
table.addRow(Common.UIString('Protocol'), originState.securityDetails.protocol);
if (originState.securityDetails.keyExchange)
table.addRow('Key Exchange', originState.securityDetails.keyExchange);
table.addRow(Common.UIString('Key exchange'), originState.securityDetails.keyExchange);
if (originState.securityDetails.keyExchangeGroup)
table.addRow('Key Exchange Group', originState.securityDetails.keyExchangeGroup);
table.addRow(Common.UIString('Key exchange group'), originState.securityDetails.keyExchangeGroup);
table.addRow(
'Cipher', originState.securityDetails.cipher +
Common.UIString('Cipher'), originState.securityDetails.cipher +
(originState.securityDetails.mac ? ' with ' + originState.securityDetails.mac : ''));
// Create the certificate section outside the callback, so that it appears in the right place.
......@@ -905,8 +905,8 @@ Security.SecurityOriginView = class extends UI.VBox {
certificateSection.appendChild(table.element());
table.addRow(Common.UIString('Subject'), originState.securityDetails.subjectName);
table.addRow(Common.UIString('SAN'), sanDiv);
table.addRow(Common.UIString('Valid From'), validFromString);
table.addRow(Common.UIString('Valid Until'), validUntilString);
table.addRow(Common.UIString('Valid from'), validFromString);
table.addRow(Common.UIString('Valid until'), validUntilString);
table.addRow(Common.UIString('Issuer'), originState.securityDetails.issuer);
table.addRow(
'', Security.SecurityPanel.createCertificateViewerButton2(
......@@ -932,14 +932,14 @@ Security.SecurityOriginView = class extends UI.VBox {
var sctTable = new Security.SecurityDetailsTable();
sctTableWrapper.appendChild(sctTable.element());
var sct = originState.securityDetails.signedCertificateTimestampList[i];
sctTable.addRow(Common.UIString('Log Name'), sct.logDescription);
sctTable.addRow(Common.UIString('Log name'), sct.logDescription);
sctTable.addRow(Common.UIString('Log ID'), sct.logId.replace(/(.{2})/g, '$1 '));
sctTable.addRow(Common.UIString('Validation Status'), sct.status);
sctTable.addRow(Common.UIString('Validation status'), sct.status);
sctTable.addRow(Common.UIString('Source'), sct.origin);
sctTable.addRow(Common.UIString('Issued At'), new Date(sct.timestamp).toUTCString());
sctTable.addRow(Common.UIString('Hash Algorithm'), sct.hashAlgorithm);
sctTable.addRow(Common.UIString('Signature Algorithm'), sct.signatureAlgorithm);
sctTable.addRow(Common.UIString('Signature Data'), sct.signatureData.replace(/(.{2})/g, '$1 '));
sctTable.addRow(Common.UIString('Issued at'), new Date(sct.timestamp).toUTCString());
sctTable.addRow(Common.UIString('Hash algorithm'), sct.hashAlgorithm);
sctTable.addRow(Common.UIString('Signature algorithm'), sct.signatureAlgorithm);
sctTable.addRow(Common.UIString('Signature data'), sct.signatureData.replace(/(.{2})/g, '$1 '));
}
// Add link to toggle between displaying of the summary of the SCT(s) and the detailed SCT(s).
......@@ -963,13 +963,13 @@ Security.SecurityOriginView = class extends UI.VBox {
Common.UIString('The security details above are from the first inspected response.');
} else if (originState.securityState !== Protocol.Security.SecurityState.Unknown) {
var notSecureSection = this.element.createChild('div', 'origin-view-section');
notSecureSection.createChild('div', 'origin-view-section-title').textContent = Common.UIString('Not Secure');
notSecureSection.createChild('div', 'origin-view-section-title').textContent = Common.UIString('Not secure');
notSecureSection.createChild('div').textContent =
Common.UIString('Your connection to this origin is not secure.');
} else {
var noInfoSection = this.element.createChild('div', 'origin-view-section');
noInfoSection.createChild('div', 'origin-view-section-title').textContent =
Common.UIString('No Security Information');
Common.UIString('No security information');
noInfoSection.createChild('div').textContent =
Common.UIString('No security details are available for this origin.');
}
......@@ -982,7 +982,7 @@ Security.SecurityOriginView = class extends UI.VBox {
_createSanDiv(sanList) {
var sanDiv = createElement('div');
if (sanList.length === 0) {
sanDiv.textContent = Common.UIString('(N/A)');
sanDiv.textContent = Common.UIString('(n/a)');
sanDiv.classList.add('empty-san');
} else {
var truncatedNumToShow = 2;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment