Commit 55561f30 authored by qfel@google.com's avatar qfel@google.com

Fixed segmentation fault in ExtensionErrorUIDefault::ExtensionGlobalError::OnBubbleViewDidClose


BUG=142336


Review URL: https://chromiumcodereview.appspot.com/10832273

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151451 0039d316-1c4b-4281-b951-d872f2087c98
parent 5a96ecfc
...@@ -86,6 +86,7 @@ string16 ExtensionErrorUI::GetBubbleViewCancelButtonLabel() { ...@@ -86,6 +86,7 @@ string16 ExtensionErrorUI::GetBubbleViewCancelButtonLabel() {
} }
void ExtensionErrorUI::BubbleViewDidClose() { void ExtensionErrorUI::BubbleViewDidClose() {
// This call deletes ExtensionErrorUI object referenced by this.
extension_service_->HandleExtensionAlertClosed(); extension_service_->HandleExtensionAlertClosed();
} }
......
...@@ -89,8 +89,9 @@ string16 ExtensionErrorUIDefault::ExtensionGlobalError:: ...@@ -89,8 +89,9 @@ string16 ExtensionErrorUIDefault::ExtensionGlobalError::
void ExtensionErrorUIDefault::ExtensionGlobalError:: void ExtensionErrorUIDefault::ExtensionGlobalError::
OnBubbleViewDidClose(Browser* browser) { OnBubbleViewDidClose(Browser* browser) {
// This call deletes error_ui_ (and as a result of error_ui_ destruction,
// object pointed by this also gets deleted).
error_ui_->BubbleViewDidClose(); error_ui_->BubbleViewDidClose();
error_ui_->browser_ = NULL;
} }
void ExtensionErrorUIDefault::ExtensionGlobalError:: void ExtensionErrorUIDefault::ExtensionGlobalError::
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment