Commit 555a52b7 authored by Yuki Yamada's avatar Yuki Yamada Committed by Commit Bot

Renamed V8 private properties

This CL renames V8 private property names regarding to
V8EventListenerOrEventHandler.
This property is used in not only blink::V8EventListenerOrEventHandler
but also other classes (blink::V8EventListenerImpl,
blink::V8LazyEventListener, blink::V8EventListenerHelper).
These classes that is related to event listener is under redesigning
as described crbug.com/872138 and it is confusing to use
"V8EventListenerOrEventHandler" for the InterfaceName of private
properties.

Bug: 872138
Change-Id: I2509f60e7b527260b5f51a1e69305a53c3836302
Reviewed-on: https://chromium-review.googlesource.com/1206752Reviewed-by: default avatarYuki Shiino <yukishiino@chromium.org>
Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
Reviewed-by: default avatarHitoshi Yoshida <peria@chromium.org>
Commit-Queue: Yuki Yamada <yukiy@google.com>
Cr-Commit-Position: refs/heads/master@{#589092}
parent 47d2905a
......@@ -74,10 +74,8 @@ EventListener* V8EventListenerHelper::GetEventListener(
v8::Isolate* isolate = script_state->GetIsolate();
V8PrivateProperty::Symbol listener_property =
is_attribute
? V8PrivateProperty::
GetV8EventListenerOrEventHandlerAttributeListener(isolate)
: V8PrivateProperty::GetV8EventListenerOrEventHandlerListener(
isolate);
? V8PrivateProperty::GetCustomWrappableEventHandler(isolate)
: V8PrivateProperty::GetCustomWrappableEventListener(isolate);
return GetEventListenerInternal<EventListener>(
script_state, object, listener_property, lookup,
......
......@@ -204,9 +204,9 @@ void V8LazyEventListener::CompileScript(ScriptState* script_state,
wrapped_function->SetName(V8String(GetIsolate(), function_name_));
SetListenerObject(script_state, wrapped_function,
V8PrivateProperty::GetV8EventListenerOrEventHandlerListener(
GetIsolate()));
SetListenerObject(
script_state, wrapped_function,
V8PrivateProperty::GetCustomWrappableEventListener(GetIsolate()));
}
void V8LazyEventListener::FireErrorEvent(v8::Local<v8::Context> v8_context,
......
......@@ -51,8 +51,8 @@ class ScriptWrappable;
X(SameObject, PerformanceLongTaskTimingAttribution) \
X(SameObject, PushManagerSupportedContentEncodings) \
X(V8ErrorHandler, ErrorHandler) \
X(V8EventListenerOrEventHandler, AttributeListener) \
X(V8EventListenerOrEventHandler, Listener) \
X(CustomWrappable, EventHandler) \
X(CustomWrappable, EventListener) \
SCRIPT_PROMISE_PROPERTIES(X, Promise) \
SCRIPT_PROMISE_PROPERTIES(X, Resolver)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment