Commit 555b6835 authored by Jeffrey Kardatzke's avatar Jeffrey Kardatzke Committed by Commit Bot

Fixed bug where Crostini icons didn't always load

This is an obvious coding error, the wrong variable was used for
checking if an iterator was empty. Depending upon if a specific bit was
set in that random memory location, then we'd get the right/wrong
behavior.

Bug: 842196
Test: Icons load (although they usually did before)
Change-Id: Ie52747f0b03e82ba2915df3f8ce9198a9a22452f
Reviewed-on: https://chromium-review.googlesource.com/1062199Reviewed-by: default avatarTimothy Loh <timloh@chromium.org>
Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com>
Cr-Commit-Position: refs/heads/master@{#559396}
parent 2c807895
......@@ -448,7 +448,7 @@ void CrostiniRegistryService::MaybeRequestIcon(const std::string& app_id,
}
}
const auto retry_iter = retry_icon_requests_.find(app_id);
if (retry_iter != active_icon_requests_.end()) {
if (retry_iter != retry_icon_requests_.end()) {
if (retry_iter->second & (1 << scale_factor)) {
// Icon request already setup to be retried when we are active.
return;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment