Do not check sourceApplication when opening URL.

Starting with iOS 13, sourceApplication is only set when openURL is
called from an application with the same team identifier.
Oddly, it is also nil when calling from extension.

Bug: 1020228
Change-Id: I9876647c30350e2242d20da2ab045805a9864932
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903349Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715221}

ios/chrome/app/application_delegate/url_opener.mm

@@ -118,12 +118,16 @@ const char* const kUMAMobileSessionStartFromAppsHistogram =
          startupInformation:(id<StartupInformation>)startupInformation
                    appState:(AppState*)appState {
   NSURL* url = launchOptions[UIApplicationLaunchOptionsURLKey];
-  NSString* sourceApplication =
-      launchOptions[UIApplicationLaunchOptionsSourceApplicationKey];
 
-  if (url && sourceApplication) {
-    NSDictionary<NSString*, id>* options =
-        @{UIApplicationOpenURLOptionsSourceApplicationKey : sourceApplication};
+  if (url) {
+    NSMutableDictionary<NSString*, id>* options =
+        [[NSMutableDictionary alloc] init];
+    NSString* sourceApplication =
+        launchOptions[UIApplicationLaunchOptionsSourceApplicationKey];
+    if (sourceApplication) {
+      options[UIApplicationOpenURLOptionsSourceApplicationKey] =
+          sourceApplication;
+    }
 
     BOOL openURLResult = [URLOpener openURL:url
                           applicationActive:applicationActive

ios/chrome/app/application_delegate/url_opener_unittest.mm

@@ -16,8 +16,8 @@
 #import "ios/chrome/browser/ui/main/test/stub_browser_interface_provider.h"
 #import "ios/chrome/browser/url_loading/url_loading_params.h"
 #import "ios/chrome/browser/web_state_list/web_state_list.h"
-#import "ios/testing/scoped_block_swizzler.h"
 #include "ios/web/public/test/web_task_environment.h"
+#include "net/base/mac/url_conversions.h"
 #include "testing/gtest_mac.h"
 #include "testing/platform_test.h"
 #import "third_party/ocmock/OCMock/OCMock.h"
@@ -207,30 +207,21 @@ TEST_F(URLOpenerTest, VerifyLaunchOptions) {
 
   id startupInformationMock =
       [OCMockObject mockForProtocol:@protocol(StartupInformation)];
+  [[[startupInformationMock expect] andReturnValue:@NO] isPresentingFirstRunUI];
+  [[startupInformationMock expect] resetFirstUserActionRecorder];
+  __block ChromeAppStartupParameters* params = nil;
+  [[startupInformationMock expect]
+      setStartupParameters:[OCMArg checkWithBlock:^(
+                                       ChromeAppStartupParameters* p) {
+        params = p;
+        EXPECT_NSEQ(net::NSURLWithGURL(p.completeURL), url);
+        EXPECT_EQ(p.callerApp, CALLER_APP_APPLE_MOBILESAFARI);
+        return YES;
+      }]];
+  [[[startupInformationMock expect] andReturn:params] startupParameters];
 
   id appStateMock = [OCMockObject mockForClass:[AppState class]];
-  [[appStateMock expect] launchFromURLHandled:YES];
-
-  __block BOOL hasBeenCalled = NO;
-
-  id implementation_block = ^BOOL(
-      id self, NSURL* urlArg, BOOL applicationActive, NSDictionary* options,
-      id<TabOpening> tabOpener, id<StartupInformation> startupInformation) {
-    hasBeenCalled = YES;
-    EXPECT_NSEQ([url absoluteString], [urlArg absoluteString]);
-    EXPECT_NSEQ(@"com.apple.mobilesafari",
-                options[UIApplicationOpenURLOptionsSourceApplicationKey]);
-    EXPECT_EQ(startupInformationMock, startupInformation);
-    EXPECT_EQ(tabOpenerMock, tabOpener);
-    return YES;
-  };
-  ScopedBlockSwizzler URL_opening_openURL_swizzler([URLOpener class],
-                                                   @selector(openURL:
-                                                        applicationActive:
-                                                                  options:
-                                                                tabOpener:
-                                                       startupInformation:),
-                                                   implementation_block);
+  [[appStateMock expect] launchFromURLHandled:NO];
 
   // Action.
   [URLOpener handleLaunchOptions:launchOptions
@@ -240,7 +231,6 @@ TEST_F(URLOpenerTest, VerifyLaunchOptions) {
                         appState:appStateMock];
 
   // Test.
-  EXPECT_TRUE(hasBeenCalled);
   EXPECT_OCMOCK_VERIFY(startupInformationMock);
 }
 
@@ -270,18 +260,34 @@ TEST_F(URLOpenerTest, VerifyLaunchOptionsWithNoSourceApplication) {
     UIApplicationLaunchOptionsURLKey : url,
   };
 
-  // Creates a mock with no stub. This test will pass only if we don't use these
-  // objects.
+  MockTabOpener* tabOpenerMock = [[MockTabOpener alloc] init];
+
   id startupInformationMock =
       [OCMockObject mockForProtocol:@protocol(StartupInformation)];
+  [[[startupInformationMock expect] andReturnValue:@NO] isPresentingFirstRunUI];
+  __block ChromeAppStartupParameters* params = nil;
+  [[startupInformationMock expect]
+      setStartupParameters:[OCMArg checkWithBlock:^(
+                                       ChromeAppStartupParameters* p) {
+        params = p;
+        EXPECT_NSEQ(net::NSURLWithGURL(p.completeURL), url);
+        EXPECT_EQ(p.callerApp, CALLER_APP_NOT_AVAILABLE);
+        return YES;
+      }]];
+  [[[startupInformationMock expect] andReturn:params] startupParameters];
+
   id appStateMock = [OCMockObject mockForClass:[AppState class]];
+  [[appStateMock expect] launchFromURLHandled:YES];
 
   // Action.
   [URLOpener handleLaunchOptions:launchOptions
                applicationActive:YES
-                       tabOpener:nil
+                       tabOpener:tabOpenerMock
               startupInformation:startupInformationMock
                         appState:appStateMock];
+
+  // Test.
+  EXPECT_OCMOCK_VERIFY(startupInformationMock);
 }
 
 // Tests that -handleApplication set startup parameters as expected with no url.
@@ -319,30 +325,13 @@ TEST_F(URLOpenerTest, VerifyLaunchOptionsWithBadURL) {
 
   id startupInformationMock =
       [OCMockObject mockForProtocol:@protocol(StartupInformation)];
+  [[startupInformationMock expect] resetFirstUserActionRecorder];
+  [[[startupInformationMock expect] andReturnValue:@NO] isPresentingFirstRunUI];
+  [[startupInformationMock expect] setStartupParameters:[OCMArg isNil]];
+  [[[startupInformationMock expect] andReturn:nil] startupParameters];
 
   id appStateMock = [OCMockObject mockForClass:[AppState class]];
-  [[appStateMock expect] launchFromURLHandled:YES];
-
-  __block BOOL hasBeenCalled = NO;
-
-  id implementation_block = ^BOOL(
-      id self, NSURL* urlArg, BOOL applicationActive, NSDictionary* options,
-      id<TabOpening> tabOpener, id<StartupInformation> startupInformation) {
-    hasBeenCalled = YES;
-    EXPECT_NSEQ([url absoluteString], [urlArg absoluteString]);
-    EXPECT_NSEQ(@"com.apple.mobilesafari",
-                options[UIApplicationOpenURLOptionsSourceApplicationKey]);
-    EXPECT_EQ(startupInformationMock, startupInformation);
-    EXPECT_EQ(tabOpenerMock, tabOpener);
-    return YES;
-  };
-  ScopedBlockSwizzler URL_opening_openURL_swizzler([URLOpener class],
-                                                   @selector(openURL:
-                                                        applicationActive:
-                                                                  options:
-                                                                tabOpener:
-                                                       startupInformation:),
-                                                   implementation_block);
+  [[appStateMock expect] launchFromURLHandled:NO];
 
   // Action.
   [URLOpener handleLaunchOptions:launchOptions
@@ -352,6 +341,5 @@ TEST_F(URLOpenerTest, VerifyLaunchOptionsWithBadURL) {
                         appState:appStateMock];
 
   // Test.
-  EXPECT_TRUE(hasBeenCalled);
   EXPECT_OCMOCK_VERIFY(startupInformationMock);
 }