Commit 5582ccbc authored by Jonathan Mengedoht's avatar Jonathan Mengedoht Committed by Commit Bot

[Passwords] Add 32-bit checksum field to AutofillRandomizedValue for...

[Passwords] Add 32-bit checksum field to AutofillRandomizedValue for crowdsourcing change password urls.

Bug: 1095605
Change-Id: I3b7b40b7a9612e9c199697d9359e70fa857a7af3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246594
Commit-Queue: Jonathan Mengedoht <mengedoht@google.com>
Reviewed-by: default avatarMaxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779363}
parent 9d51f685
...@@ -2007,6 +2007,8 @@ TEST_P(AutofillUploadTest, RichMetadata) { ...@@ -2007,6 +2007,8 @@ TEST_P(AutofillUploadTest, RichMetadata) {
EXPECT_TRUE(upload.randomized_form_metadata().has_id()); EXPECT_TRUE(upload.randomized_form_metadata().has_id());
EXPECT_TRUE(upload.randomized_form_metadata().has_name()); EXPECT_TRUE(upload.randomized_form_metadata().has_name());
EXPECT_TRUE(upload.randomized_form_metadata().has_url()); EXPECT_TRUE(upload.randomized_form_metadata().has_url());
ASSERT_TRUE(upload.randomized_form_metadata().has_checksum_for_url());
EXPECT_EQ(upload.randomized_form_metadata().checksum_for_url(), 3608731642);
EXPECT_EQ(3, upload.field_size()); EXPECT_EQ(3, upload.field_size());
for (const auto& f : upload.field()) { for (const auto& f : upload.field()) {
ASSERT_TRUE(f.has_randomized_field_metadata()); ASSERT_TRUE(f.has_randomized_field_metadata());
......
...@@ -470,6 +470,7 @@ void PopulateRandomizedFormMetadata(const RandomizedEncoder& encoder, ...@@ -470,6 +470,7 @@ void PopulateRandomizedFormMetadata(const RandomizedEncoder& encoder,
EncodeRandomizedValue(encoder, form_signature, kNullFieldSignature, EncodeRandomizedValue(encoder, form_signature, kNullFieldSignature,
RandomizedEncoder::FORM_URL, full_source_url, RandomizedEncoder::FORM_URL, full_source_url,
metadata->mutable_url()); metadata->mutable_url());
metadata->set_checksum_for_url(StrToHash32Bit(full_source_url));
} }
} }
......
...@@ -156,6 +156,9 @@ message AutofillRandomizedFormMetadata { ...@@ -156,6 +156,9 @@ message AutofillRandomizedFormMetadata {
} }
// Titles of form's buttons. Example: <input type="submit" value="XXXXX"> // Titles of form's buttons. Example: <input type="submit" value="XXXXX">
repeated ButtonTitle button_title = 5; repeated ButtonTitle button_title = 5;
// Hash of the clear form URL, not randomized.
optional fixed32 checksum_for_url = 6;
} }
// The collection of autofill field metadata to be sent using randomization. // The collection of autofill field metadata to be sent using randomization.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment