ozone/x11: Make PlatformWindow activatable by default

Ozone/X11 window "mobility" has been broken by crrev.com/c/1698263. Which
has been observed in apps such as content_shell, ozone_demo. The issue
is caused |ui::XWindow::activatable_| being set to false in those builds.

This fixes it, defaulting PlatformWindowInitProperties::activatable to
true and just forwarding it to ui::XWindow::Configuration at
X11WindowOzone initialization code.

Bug: 988913
Change-Id: I65cd8ab8a5763ae0f0cbfb748f146662f80846d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726597
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683224}

ui/ozone/platform/x11/x11_window_ozone.cc

@@ -60,13 +60,6 @@ ui::XWindow::Configuration ConvertInitPropertiesToXWindowConfig(
   }
 
   config.bounds = properties.bounds;
-
-#if defined(OS_CHROMEOS)
-  config.activatable = !UseTestConfigForPlatformWindows();
-#else
-  config.activatable = properties.activatable;
-#endif
-
   config.force_show_in_taskbar = properties.force_show_in_taskbar;
   config.keep_on_top = properties.keep_on_top;
   config.visible_on_all_workspaces = properties.visible_on_all_workspaces;
@@ -76,6 +69,12 @@ ui::XWindow::Configuration ConvertInitPropertiesToXWindowConfig(
   config.wm_class_class = properties.wm_class_class;
   config.wm_role_name = properties.wm_role_name;
 
+  // TODO(nickdiego): {Use,Enable}TestConfigForPlatformWindows are used by test
+  // infra to disable platform windows activation. Figure out another way to do
+  // this in case Widget::InitParams::activation is needed in the future.
+  config.activatable =
+      properties.activatable && !UseTestConfigForPlatformWindows();
+
   return config;
 }
 

ui/platform_window/platform_window_init_properties.h

@@ -57,7 +57,7 @@ struct PlatformWindowInitProperties {
   fuchsia::ui::views::ViewToken view_token;
 #endif
 
-  bool activatable = false;
+  bool activatable = true;
   bool force_show_in_taskbar;
   bool keep_on_top = false;
   bool visible_on_all_workspaces = false;