Use-after-poison in blink::RTCPeerConnectionHandler::OnaddICECandidateResult
This CL fixes the clusterfuzz issues reported (see "Fixed" below) by using WTF::Bind and WrapPersistent in RTCPeerConnectionHandler::AddICECandidate. This is a regression from crrev.com/c/1899786, where code used to have a WebRTCVoidRequest wrapping RTCVoidRequest instances (garbage collected). Now that RTCVoidRequest is used directly, we need to properly wrap-persist its instances with WTF::WrapPersistent when passing it to callbacks. Reason: With Oilpan and WTF::Bind, raw pointers of garbage collected objects are not allowed. Fixed:1021919 R=haraken@chromium.org Change-Id: If9128d73f288bf0e39495effd8e33779a81cc0a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901726 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#713152}
Showing
Please register or sign in to comment