Commit 55c84ae7 authored by Jeffrey Cohen's avatar Jeffrey Cohen Committed by Commit Bot

[Share] Fix crash from null tab in menu handler

Bug: 1083851
Change-Id: I569c5dc14de4d6590cbd96901ecae7b505dbdec2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236248Reviewed-by: default avatarDavid Trainor <dtrainor@chromium.org>
Reviewed-by: default avatarPatrick Noland <pnoland@chromium.org>
Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776557}
parent c94e4d0e
......@@ -353,9 +353,12 @@ public class RootUiCoordinator
*/
@VisibleForTesting
public void onShareMenuItemSelected(final boolean shareDirectly, final boolean isIncognito) {
if (mShareDelegateSupplier.get() == null) return;
ShareDelegate shareDelegate = mShareDelegateSupplier.get();
Tab tab = mActivityTabProvider.get();
mShareDelegateSupplier.get().share(mActivityTabProvider.get(), shareDirectly);
if (shareDelegate == null || tab == null) return;
shareDelegate.share(tab, shareDirectly);
}
// MenuOrKeyboardActionHandler implementation
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment