Commit 55d21e15 authored by Nasko Oskov's avatar Nasko Oskov Committed by Commit Bot

Enable error page isolation.

Error page isolation was introduced in https://crrev.com/c/762520 but it
had some function bugs (e.g. https://crbug.com/840485). There have been
multiple fixes since then and it should be in a shape to try and enable
it again.

Bug: 838161
Change-Id: Ic3815e26eca9850c14e2cd925ed037223f4ded11
Reviewed-on: https://chromium-review.googlesource.com/1115203
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Reviewed-by: default avatarAlex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570951}
parent 3c4c1ab4
...@@ -1700,9 +1700,7 @@ bool ChromeContentBrowserClient::ShouldSwapBrowsingInstancesForNavigation( ...@@ -1700,9 +1700,7 @@ bool ChromeContentBrowserClient::ShouldSwapBrowsingInstancesForNavigation(
bool ChromeContentBrowserClient::ShouldIsolateErrorPage(bool in_main_frame) { bool ChromeContentBrowserClient::ShouldIsolateErrorPage(bool in_main_frame) {
// TODO(nasko): Consider supporting error page isolation in subframes if // TODO(nasko): Consider supporting error page isolation in subframes if
// Site Isolation is enabled. // Site Isolation is enabled.
// Note: It is temporarily disabled to investigate functional regression return in_main_frame;
// and process terminations. See https://crbug.com/838161.
return false;
} }
bool ChromeContentBrowserClient::ShouldAssignSiteForURL(const GURL& url) { bool ChromeContentBrowserClient::ShouldAssignSiteForURL(const GURL& url) {
......
...@@ -173,7 +173,7 @@ bool ContentBrowserClient::ShouldSwapBrowsingInstancesForNavigation( ...@@ -173,7 +173,7 @@ bool ContentBrowserClient::ShouldSwapBrowsingInstancesForNavigation(
} }
bool ContentBrowserClient::ShouldIsolateErrorPage(bool in_main_frame) { bool ContentBrowserClient::ShouldIsolateErrorPage(bool in_main_frame) {
return false; return in_main_frame;
} }
std::unique_ptr<media::AudioManager> ContentBrowserClient::CreateAudioManager( std::unique_ptr<media::AudioManager> ContentBrowserClient::CreateAudioManager(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment