Commit 55dccbf6 authored by Alex Chau's avatar Alex Chau Committed by Commit Bot

Record web push message payload size

Bug: 974816
Change-Id: I0375b88459de729de40d13e96a80caa159d5b5d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710570Reviewed-by: default avatarPeter Beverloo <peter@chromium.org>
Reviewed-by: default avatarAlexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Alex Chau <alexchau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680011}
parent ca509b8c
...@@ -12,4 +12,9 @@ void LogSendWebPushMessageResult(SendWebPushMessageResult result) { ...@@ -12,4 +12,9 @@ void LogSendWebPushMessageResult(SendWebPushMessageResult result) {
base::UmaHistogramEnumeration("GCM.SendWebPushMessageResult", result); base::UmaHistogramEnumeration("GCM.SendWebPushMessageResult", result);
} }
void LogSendWebPushMessagePayloadSize(int size) {
// Note: The maximum size accepted by FCM is 4096.
base::UmaHistogramCounts10000("GCM.SendWebPushMessagePayloadSize", size);
}
} // namespace gcm } // namespace gcm
...@@ -23,6 +23,10 @@ enum class SendWebPushMessageResult { ...@@ -23,6 +23,10 @@ enum class SendWebPushMessageResult {
// is sent. // is sent.
void LogSendWebPushMessageResult(SendWebPushMessageResult result); void LogSendWebPushMessageResult(SendWebPushMessageResult result);
// Logs the size of message payload to UMA. This should be called right before a
// web push message is sent.
void LogSendWebPushMessagePayloadSize(int size);
} // namespace gcm } // namespace gcm
#endif // COMPONENTS_GCM_DRIVER_WEB_PUSH_METRICS_H_ #endif // COMPONENTS_GCM_DRIVER_WEB_PUSH_METRICS_H_
...@@ -149,6 +149,7 @@ void WebPushSender::SendMessage(const std::string& fcm_token, ...@@ -149,6 +149,7 @@ void WebPushSender::SendMessage(const std::string& fcm_token,
return; return;
} }
LogSendWebPushMessagePayloadSize(message.payload.size());
std::unique_ptr<network::SimpleURLLoader> url_loader = BuildURLLoader( std::unique_ptr<network::SimpleURLLoader> url_loader = BuildURLLoader(
fcm_token, message.time_to_live, *auth_header, message.payload); fcm_token, message.time_to_live, *auth_header, message.payload);
url_loader->DownloadToString( url_loader->DownloadToString(
......
...@@ -45656,6 +45656,15 @@ uploading your change for review. ...@@ -45656,6 +45656,15 @@ uploading your change for review.
</summary> </summary>
</histogram> </histogram>
<histogram name="GCM.SendWebPushMessagePayloadSize" expires_after="2020-02-02">
<owner>alexchau@chromium.org</owner>
<owner>peter@chromium.org</owner>
<summary>
Size of web push messages payload. Recorded right before the message is
sent.
</summary>
</histogram>
<histogram name="GCM.SendWebPushMessageResult" enum="SendWebPushMessageResult" <histogram name="GCM.SendWebPushMessageResult" enum="SendWebPushMessageResult"
expires_after="2020-02-02"> expires_after="2020-02-02">
<owner>alexchau@chromium.org</owner> <owner>alexchau@chromium.org</owner>
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment