Made desktop capture screen tab-constrained in ASH.

This should prevent their misterious disapparence when parent window ends up minimized.

BUG=375576
TEST=manual

Review URL: https://codereview.chromium.org/281383008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272619 0039d316-1c4b-4281-b951-d872f2087c98

chrome/browser/extensions/api/desktop_capture/desktop_capture_api.cc

@@ -208,7 +208,8 @@ bool DesktopCaptureChooseDesktopMediaFunction::RunAsync() {
   DesktopMediaPicker::DoneCallback callback = base::Bind(
       &DesktopCaptureChooseDesktopMediaFunction::OnPickerDialogResults, this);
 
-  picker_->Show(parent_window, parent_window,
+  picker_->Show(web_contents(),
+                parent_window, parent_window,
                 base::UTF8ToUTF16(GetExtension()->name()),
                 target_name,
                 media_list.Pass(), callback);

chrome/browser/extensions/api/desktop_capture/desktop_capture_apitest.cc

@@ -47,7 +47,8 @@ class FakeDesktopMediaPicker : public DesktopMediaPicker {
   }
 
   // DesktopMediaPicker interface.
-  virtual void Show(gfx::NativeWindow context,
+  virtual void Show(content::WebContents* web_contents,
+                    gfx::NativeWindow context,
                     gfx::NativeWindow parent,
                     const base::string16& app_name,
                     const base::string16& target_name,

chrome/browser/media/desktop_media_picker.h

@@ -14,6 +14,10 @@
 
 class DesktopMediaList;
 
+namespace content {
+class WebContents;
+}
+
 // Abstract interface for desktop media picker UI. It's used by Desktop Media
 // API to let user choose a desktop media source.
 class DesktopMediaPicker {
@@ -30,7 +34,8 @@ class DesktopMediaPicker {
   // Shows dialog with list of desktop media sources (screens, windows, tabs)
   // provided by |list| and calls |done_callback| when user chooses one of the
   // sources or closes the dialog.
-  virtual void Show(gfx::NativeWindow context,
+  virtual void Show(content::WebContents* web_contents,
+                    gfx::NativeWindow context,
                     gfx::NativeWindow parent,
                     const base::string16& app_name,
                     const base::string16& target_name,

chrome/browser/ui/cocoa/media_picker/desktop_media_picker_cocoa.h

@@ -17,7 +17,8 @@ class DesktopMediaPickerCocoa : public DesktopMediaPicker {
   virtual ~DesktopMediaPickerCocoa();
 
   // Overridden from DesktopMediaPicker:
-  virtual void Show(gfx::NativeWindow context,
+  virtual void Show(content::WebContents* web_contents,
+                    gfx::NativeWindow context,
                     gfx::NativeWindow parent,
                     const base::string16& app_name,
                     const base::string16& target_name,

chrome/browser/ui/cocoa/media_picker/desktop_media_picker_cocoa.mm

@@ -12,7 +12,8 @@ DesktopMediaPickerCocoa::DesktopMediaPickerCocoa() {
 DesktopMediaPickerCocoa::~DesktopMediaPickerCocoa() {
 }
 
-void DesktopMediaPickerCocoa::Show(gfx::NativeWindow context,
+void DesktopMediaPickerCocoa::Show(content::WebContents* web_contents,
+                                   gfx::NativeWindow context,
                                    gfx::NativeWindow parent,
                                    const base::string16& app_name,
                                    const base::string16& target_name,

chrome/browser/ui/views/desktop_media_picker_views.cc

@@ -8,6 +8,9 @@
 #include "chrome/browser/media/desktop_media_list.h"
 #include "chrome/browser/media/desktop_media_list_observer.h"
 #include "chrome/browser/ui/ash/ash_util.h"
+#include "components/web_modal/web_contents_modal_dialog_host.h"
+#include "components/web_modal/web_contents_modal_dialog_manager.h"
+#include "components/web_modal/web_contents_modal_dialog_manager_delegate.h"
 #include "content/public/browser/browser_thread.h"
 #include "grit/generated_resources.h"
 #include "ui/aura/window_tree_host.h"
@@ -27,6 +30,8 @@
 #include "ui/wm/core/shadow_types.h"
 
 using content::DesktopMediaID;
+using web_modal::WebContentsModalDialogManager;
+using web_modal::WebContentsModalDialogManagerDelegate;
 
 namespace {
 
@@ -147,7 +152,8 @@ class DesktopMediaListView : public views::View,
 // Dialog view used for DesktopMediaPickerViews.
 class DesktopMediaPickerDialogView : public views::DialogDelegateView {
  public:
-  DesktopMediaPickerDialogView(gfx::NativeWindow context,
+  DesktopMediaPickerDialogView(content::WebContents* parent_web_contents,
+                               gfx::NativeWindow context,
                                gfx::NativeWindow parent_window,
                                DesktopMediaPickerViews* parent,
                                const base::string16& app_name,
@@ -194,7 +200,8 @@ class DesktopMediaPickerViews : public DesktopMediaPicker {
   void NotifyDialogResult(DesktopMediaID source);
 
   // DesktopMediaPicker overrides.
-  virtual void Show(gfx::NativeWindow context,
+  virtual void Show(content::WebContents* web_contents,
+                    gfx::NativeWindow context,
                     gfx::NativeWindow parent,
                     const base::string16& app_name,
                     const base::string16& target_name,
@@ -485,6 +492,7 @@ void DesktopMediaListView::OnSourceThumbnailChanged(int index) {
 }
 
 DesktopMediaPickerDialogView::DesktopMediaPickerDialogView(
+    content::WebContents* parent_web_contents,
     gfx::NativeWindow context,
     gfx::NativeWindow parent_window,
     DesktopMediaPickerViews* parent,
@@ -510,7 +518,15 @@ DesktopMediaPickerDialogView::DesktopMediaPickerDialogView(
   scroll_view_->SetContents(list_view_);
   AddChildView(scroll_view_);
 
-  DialogDelegate::CreateDialogWidget(this, context, parent_window);
+  WebContentsModalDialogManager* web_contents_modal_dialog_manager =
+      WebContentsModalDialogManager::FromWebContents(parent_web_contents);
+  DCHECK(web_contents_modal_dialog_manager);
+  WebContentsModalDialogManagerDelegate* delegate =
+      web_contents_modal_dialog_manager->delegate();
+  DCHECK(delegate);
+  views::Widget::CreateWindowAsFramelessChild(
+      this,
+      delegate->GetWebContentsModalDialogHost()->GetHostView());
 
   // DesktopMediaList needs to know the ID of the picker window which
   // matches the ID it gets from the OS. Depending on the OS and configuration
@@ -531,7 +547,8 @@ DesktopMediaPickerDialogView::DesktopMediaPickerDialogView(
 
   list_view_->StartUpdating(dialog_window_id);
 
-  GetWidget()->Show();
+  web_contents_modal_dialog_manager->ShowModalDialog(
+      GetWidget()->GetNativeView());
 }
 
 DesktopMediaPickerDialogView::~DesktopMediaPickerDialogView() {}
@@ -619,7 +636,8 @@ DesktopMediaPickerViews::~DesktopMediaPickerViews() {
   }
 }
 
-void DesktopMediaPickerViews::Show(gfx::NativeWindow context,
+void DesktopMediaPickerViews::Show(content::WebContents* web_contents,
+                                   gfx::NativeWindow context,
                                    gfx::NativeWindow parent,
                                    const base::string16& app_name,
                                    const base::string16& target_name,
@@ -627,7 +645,8 @@ void DesktopMediaPickerViews::Show(gfx::NativeWindow context,
                                    const DoneCallback& done_callback) {
   callback_ = done_callback;
   dialog_ = new DesktopMediaPickerDialogView(
-      context, parent, this, app_name, target_name, media_list.Pass());
+      web_contents, context, parent, this, app_name, target_name,
+      media_list.Pass());
 }
 
 void DesktopMediaPickerViews::NotifyDialogResult(