Commit 562e1c3c authored by David Maunder's avatar David Maunder Committed by Commit Bot

Don't acquire url on uninitialized Tab in ChromeProvidedSharingOptionsProvider

We now enforce that tab attributes cannot be acquired on an
uninitialized Tab (including Tab#destroy). Adding in a fallback.

Bug: 1117396
Change-Id: I0e8eeec1a982677e64d6d7f82f2fd883c1e0d4ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411160Reviewed-by: default avatarKyle Milka <kmilka@chromium.org>
Commit-Queue: David Maunder <davidjm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807060}
parent a76dcdab
...@@ -97,7 +97,8 @@ class ChromeProvidedSharingOptionsProvider { ...@@ -97,7 +97,8 @@ class ChromeProvidedSharingOptionsProvider {
mOrderedFirstPartyOptions = new ArrayList<>(); mOrderedFirstPartyOptions = new ArrayList<>();
initializeFirstPartyOptionsInOrder(); initializeFirstPartyOptionsInOrder();
mChromeOptionShareCallback = chromeOptionShareCallback; mChromeOptionShareCallback = chromeOptionShareCallback;
mUrl = getUrlToShare(shareParams, chromeShareExtras, mTabProvider.get().getUrl().getSpec()); mUrl = getUrlToShare(shareParams, chromeShareExtras,
mTabProvider.get().isInitialized() ? mTabProvider.get().getUrl().getSpec() : "");
} }
/** /**
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment